fix(ergo): findings from reviewing the first live deploy

Seven confirmed findings from an observed-vs-expected review of a real deploy
transcript against the code (four other proposed findings were refuted and no
change was made for them).

- Caddyfile reformatted so `caddy fmt` is clean, removing the warning Caddy
  printed on every validate and every start. Two causes, not one: `caddy fmt`
  indents with TABS, and it deletes a blank line whose following line begins
  with `{` -- which is why the warning pointed at line 17, the blank before the
  global options block. The check is a whole-file byte comparison, so the line
  number was only the first difference and the entire file had to be
  reformatted. Verified whitespace-only outside the heredoc, whose body is left
  byte-identical: Caddy strips padding derived from the closing marker's
  indentation, so re-indenting it would change what the page serves.
- deploy.sh no longer upgrades Caddy behind the operator's back. A bare
  `docker compose pull` refreshed the floating `caddy:2-alpine` on every re-run
  and `up -d` then recreated it, doing exactly what CADDY_AUTOUPDATE=0 promises
  not to, with none of update.sh's health check or rollback. Pulls are now
  per service: the pinned Ergo tag always, Caddy only when absent or opted in.
- deploy.sh seeds the ACME_EMAIL and NETWORK_NAME prompts from .env, so pressing
  Enter through a re-run no longer renames the network to the hostname in the
  summary while .env keeps the real one.
- The Caddy restart guard compares the container's identity across `up -d`. A
  container compose created or recreated has already read the new Caddyfile;
  only one left running still holds the old config, and `svc_state` cannot tell
  those apart.
- Container logs are now rotated (json-file, 10m x 3) on every service. Alpine's
  docker package ships no daemon.json, so the default is unbounded, and the
  60-second health probe alone writes a log line per run.
- ergoctl notes that LUSERS counts its own probe connection, which is why a
  server with nobody on it reports one invisible user.

Verified: seven local suites pass, the embedded archive round-trips, line
endings are LF, and the reformatted Caddyfile is a verified fixed point of the
formatter (semantically identical token-for-token to the previous one).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
57_WolveandClaude Opus 5 committed 2026-09-02 15:38:13 -05:00
1 parent f916eb549a
commit 134736c082
5 files changed
+737 -690

No files matched your search

+10
View File
@@ -41,6 +41,11 @@ services:
ERGO_DOMAIN: "${ERGO_DOMAIN}"
ACME_EMAIL: "${ACME_EMAIL}"
NETWORK_NAME: "${NETWORK_NAME}"
logging:
driver: json-file
options:
max-size: "10m"
max-file: "3"
healthcheck:
# Loopback-only health site defined in the Caddyfile (the admin API is off).
test: ["CMD-SHELL", "wget -qO- http://127.0.0.1/ | grep -q '^ok'"]
@@ -69,6 +74,11 @@ services:
tmpfs: [/tmp]
volumes:
- ./ircd:/ircd
logging:
driver: json-file
options:
max-size: "10m"
max-file: "3"
healthcheck:
# IRC-level probe: Ergo answers a pre-registration QUIT with "ERROR :Quit"
# and closes. A bare TCP connect would pass even with a wedged server.