v1.10.0 carries upstream CVE fixes that the older releases predate, so stop building them. Their series move to patches/archive/<tag>/ rather than being deleted — still available for a deliberate rebuild, just not shipped — and ci/support-matrix.yaml now lists v1.10.0 alone. Dropping the matrix entries was not enough on its own. Two gaps made "not built" untrue: * apply-patches.sh only consulted the matrix `if command -v yq`, and the stock golang CI container has no yq — so in CI the registry was never actually read. The tag fell through to patches/<tag> every time. * An empty or missing patch directory was a warning and exit 0, i.e. "building vanilla upstream". Archiving the directories would therefore have made a dispatch for v1.8.0 publish an un-de-branded, unpatched, CVE-vulnerable build under this project's release name — the exact outcome we are trying to prevent. So the matrix is now an enforced allowlist: a tag it does not list exits 1, as does a patch directory with no patches in it. It is parsed with yq when present and with a small awk parse otherwise, so the allowlist holds in the CI container too. If the parse ever broke, an unmatched tag is refused rather than built, so the failure mode stays closed. PATCH_DIR remains the one bypass, and is now the documented way to rebuild an archived series on purpose. That path also needed a fix: the patch list is globbed before we cd into the source tree, so a relative PATCH_DIR — the form the new error message suggests — globbed fine and then failed in git am. PATCH_DIR is now resolved to an absolute path, with a missing directory reported as such. Also re-pointed the runnable examples in README.md, ci/run.sh and the workflow's dispatch hint from v1.5.0 to v1.10.0; following them verbatim would now hit the refusal. Verified by exercising every branch: v1.10.0 applies; v1.8.0 is refused with exit 1; PATCH_DIR=patches/archive/v1.8.0 rebuilds the archived series; an empty directory and a nonexistent one are both refused. The awk parser was checked against defaulted `patches:` fields, several tags sharing one directory, and comment lines containing decoy `- tag:` text. All seven archived patch files are recorded as pure renames. Note: existing published releases for the retired versions stay downloadable until deleted by hand in Gitea. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
24 lines
987 B
YAML
24 lines
987 B
YAML
# s3-gateway build support matrix — single source of truth for CI.
|
|
#
|
|
# This is an ALLOWLIST. ci/apply-patches.sh refuses to build any tag
|
|
# that is not listed here, so a stale or vulnerable upstream release
|
|
# cannot be published by a stray tag push or a mistyped dispatch.
|
|
#
|
|
# Each entry maps an upstream versitygw release tag to the patch set
|
|
# (a directory under patches/) applied on top of that tag before
|
|
# building. Add a row when upstream cuts a release you want a
|
|
# de-branded build of; remove one to stop building it. See
|
|
# docs/multi-version-pipeline.md for the patch-refresh workflow.
|
|
#
|
|
# The highest-version entry is treated as "latest".
|
|
#
|
|
# Superseded series are kept under patches/archive/<tag>/ rather than
|
|
# deleted — see that directory's README to rebuild one deliberately.
|
|
#
|
|
# tag upstream versitygw git tag (github.com/versity/versitygw)
|
|
# patches directory under patches/ to apply (defaults to `tag`)
|
|
|
|
versitygw:
|
|
- tag: v1.10.0
|
|
patches: v1.10.0
|