plugin: always canonicalize plugin names

Reported by Joe Doyle of Trail of Bits.
This commit is contained in:
Filippo Valsorda
2026-08-29 19:30:10 +02:00
parent 572b47c3e7
commit bebcffc2f3
3 changed files with 27 additions and 3 deletions
+20
View File
@@ -84,6 +84,26 @@ func TestIdentityV1NegativeIndex(t *testing.T) {
}
}
func TestPluginNameCase(t *testing.T) {
p, err := New("MixedCase")
if err != nil {
t.Fatal(err)
}
if p.Name() != "mixedcase" {
t.Errorf("Plugin.Name = %q", p.Name())
}
id, err := NewIdentityWithoutData("MixedCase", &ClientUI{})
if err != nil {
t.Fatal(err)
}
if id.Name() != "mixedcase" {
t.Errorf("Identity.Name = %q", id.Name())
}
if _, err := New("\u212a"); err == nil {
t.Error("New accepted a non-ASCII name")
}
}
func TestLabels(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Windows support is TODO")