Two migration files shipped as version 28: 0028_add_device_secret_lookup (08121f3) and 0028_create_stripe_processed_events (12c55ed). runMigrations keys applied migrations by the integer parsed from the filename and skips any version already present in schema_migrations, so the first file to load records 28 and the second is skipped in silence — no error, no log. loadMigrations enumerates via fs.Glob, which sorts lexically, so add_device_secret_lookup won and stripe_processed_events never ran. On an existing database that leaves stripe_processed_events missing, and StripeEventSeen then fails closed: the error wraps into ErrWebhookProcessing, the webhook returns 500, and Stripe redelivers into the same missing table forever. No subscription, tier, or dispute event is ever applied — defeating the exact idempotency12c55edwas written to add. Fresh installs were unaffected, which is why no test caught it: they take the applySchema path where schema.sql already has the table and both version-28 rows are merely recorded as applied. Renumbered to 0029 rather than renumbering the device migration, so a database that already ran this build (28 recorded, devices.secret_lookup present, stripe table missing) picks the migration up on next boot instead of staying broken. Renumbering the other file would have left that database with the table still missing and re-run its ALTER on a column that exists. Adds two guards: one asserting migration versions are distinct, and one exercising the upgrade path where a duplicate manifests as a missing schema_migrations row. Both fail on a planted duplicate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Database Migrations
This directory contains database migrations for the ATCR AppView database.
Schema vs Migrations
schema.sql (in parent directory) contains the complete base schema for fresh database installations. It includes all tables, indexes, and constraints.
Migrations (this directory) handle changes to existing databases. They are only for:
ALTER TABLEstatements (add/modify/drop columns)UPDATEstatements (data transformations)DELETEstatements (data cleanup)- Creating/modifying indexes on existing tables
NEW TABLES go in schema.sql, NOT in migrations.
Migration Format
Each migration is a YAML file with the following structure:
description: Optional human-readable description of what this migration does
query: |
SQL commands to apply the migration
Version and name are parsed from the filename, so you don't need to specify them in the YAML.
Naming Convention
Migration files must be named: {version:04d}_{migration_name}.yaml
The filename determines:
- Version: Numeric prefix (e.g.,
0001→ version 1) - Name: Everything after first underscore (e.g.,
add_repository_labels→ "add repository labels")
Examples:
0001_remove_star_count_from_repository_stats.yaml→ version 1, name "remove star count from repository stats"0002_add_repository_labels.yaml→ version 2, name "add repository labels"0003_create_webhooks_table.yaml→ version 3, name "create webhooks table"
Creating a New Migration
- Choose the next version number - Look at existing migrations and increment by 1
- Create a new YAML file with format
000N_descriptive_name.yaml - Add description (optional) - Explain what the migration does
- Write your SQL in
query- Use the|block scalar for clean multi-line SQL - Use
IF EXISTS/IF NOT EXISTSwhere possible for idempotency
Examples
Adding a column to existing table:
Filename: 0007_add_readme_url_to_manifests.yaml
description: Add readme_url column to manifests table for storing io.atcr.readme annotation
query: |
ALTER TABLE manifests ADD COLUMN readme_url TEXT;
IMPORTANT: After creating this migration, also add the column to schema.sql so fresh installations include it!
Data transformation migration:
Filename: 0005_normalize_hold_endpoint_to_did.yaml
description: Normalize hold_endpoint column to store DIDs instead of URLs
query: |
-- Convert HTTPS URLs to did:web: format
UPDATE manifests
SET hold_endpoint = 'did:web:' || substr(hold_endpoint, 9)
WHERE hold_endpoint LIKE 'https://%';
-- Convert HTTP URLs to did:web: format
UPDATE manifests
SET hold_endpoint = 'did:web:' || substr(hold_endpoint, 8)
WHERE hold_endpoint LIKE 'http://%';
Adding an index to existing table:
Filename: 0008_add_repository_description_index.yaml
description: Add index on manifests description field for faster searches
query: |
CREATE INDEX IF NOT EXISTS idx_manifests_description ON manifests(description);
How Migrations Run
- Migrations are loaded from this directory on startup
- Sorted by version number (ascending)
- Each migration is checked against the
schema_migrationstable - Only unapplied migrations are executed
- After successful execution, the version is recorded in
schema_migrations
Important Notes
- Never modify existing migrations - Once applied, they're immutable
- Test migrations before committing - Ensure they work on existing databases
- Version numbers must be unique - The migration system will fail if duplicates exist
- Migrations run automatically on
InitDB()- Schema first, then migrations - CRITICAL: Update
schema.sqlfor structural changes - When you ALTER a table or add columns, update both the migration ANDschema.sqlso fresh installations have the same structure - New tables go in
schema.sqlonly - Don't create migration files for new tables