at-container-registry/pkg/auth/hold_remote_captain_verify_test.go

package auth

import (
	"context"
	"encoding/json"
	"net/http"
	"net/http/httptest"
	"strings"
	"testing"
	"time"

	"atcr.io/pkg/atproto"
)

// 69307c0 verified captain records against the publishing DID's atcr_hold
// service before caching them, but only on the two Jetstream writers. This
// covers the third: RemoteHoldAuthorizer.GetCaptainRecord, reached during blob
// authorization with a hold DID the user chose via their sailor profile.
//
// The row matters because GetAvailableHolds offers every hold_captain_records
// row with allow_all_crew=1 to every user's hold picker, so an unverified row
// puts an arbitrary DID in front of everyone as a storage option.

// captainServer serves a captain record for any repo, with allowAllCrew set —
// the value that makes a row visible to every user rather than just its author.
func captainServer(t *testing.T) *httptest.Server {
	t.Helper()
	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		_ = json.NewEncoder(w).Encode(map[string]any{
			"uri": "at://x/io.atcr.hold.captain/self",
			"cid": "bafytest",
			"value": map[string]any{
				"$type":        atproto.CaptainCollection,
				"owner":        "did:plc:attacker",
				"public":       true,
				"allowAllCrew": true,
			},
		})
	}))
	t.Cleanup(srv.Close)
	return srv
}

func didFromServer(url string) string {
	return "did:web:" + strings.ReplaceAll(strings.TrimPrefix(url, "http://"), ":", "%3A")
}

func captainRows(t *testing.T, a *RemoteHoldAuthorizer, holdDID string) int {
	t.Helper()
	var n int
	if err := a.db.QueryRow(
		`SELECT COUNT(*) FROM hold_captain_records WHERE hold_did = ?`, holdDID,
	).Scan(&n); err != nil {
		t.Fatalf("count captain rows: %v", err)
	}
	return n
}

func newVerifyAuthorizer(t *testing.T) *RemoteHoldAuthorizer {
	t.Helper()
	atproto.SetTestMode(true)
	t.Cleanup(func() { atproto.SetTestMode(false) })
	return &RemoteHoldAuthorizer{
		db:         setupTestDB(t),
		httpClient: &http.Client{Timeout: 5 * time.Second},
		cacheTTL:   time.Hour,
		testMode:   true,
	}
}

// TestGetCaptainRecord_NonHoldDIDIsNotCached is the one that fails without the
// gate. A DID with no atcr_hold service still serves the record over its PDS
// endpoint, so the fetch succeeds and the caller gets an answer — but nothing
// durable may be written, or the picker inherits it.
func TestGetCaptainRecord_NonHoldDIDIsNotCached(t *testing.T) {
	a := newVerifyAuthorizer(t)
	srv := captainServer(t)
	holdDID := didFromServer(srv.URL)

	prev := hasHoldService
	hasHoldService = func(context.Context, string) (bool, error) { return false, nil }
	t.Cleanup(func() { hasHoldService = prev })

	rec, err := a.GetCaptainRecord(context.Background(), holdDID)
	if err != nil {
		t.Fatalf("GetCaptainRecord: %v", err)
	}
	if rec == nil || !rec.AllowAllCrew {
		t.Fatalf("expected the fetch itself to still succeed, got %+v", rec)
	}
	if n := captainRows(t, a, holdDID); n != 0 {
		t.Errorf("hold_captain_records holds %d row(s) for a DID that runs no hold; "+
			"GetAvailableHolds would offer it to every user's hold picker", n)
	}
}

// TestGetCaptainRecord_RealHoldIsStillCached is the inverse, so the gate cannot
// degrade into "never cache anything" — which would look like a pass above
// while quietly costing an XRPC round trip on every authorization.
func TestGetCaptainRecord_RealHoldIsStillCached(t *testing.T) {
	a := newVerifyAuthorizer(t)
	srv := captainServer(t)
	holdDID := didFromServer(srv.URL)

	prev := hasHoldService
	hasHoldService = func(context.Context, string) (bool, error) { return true, nil }
	t.Cleanup(func() { hasHoldService = prev })

	if _, err := a.GetCaptainRecord(context.Background(), holdDID); err != nil {
		t.Fatalf("GetCaptainRecord: %v", err)
	}
	if n := captainRows(t, a, holdDID); n != 1 {
		t.Errorf("hold_captain_records holds %d rows for a verified hold, want 1", n)
	}
}

// TestGetCaptainRecord_UnresolvableDIDIsNotCached: a resolution failure is not
// evidence that the DID runs a hold, so it must not seed a durable row either.
func TestGetCaptainRecord_UnresolvableDIDIsNotCached(t *testing.T) {
	a := newVerifyAuthorizer(t)
	srv := captainServer(t)
	holdDID := didFromServer(srv.URL)

	prev := hasHoldService
	hasHoldService = func(context.Context, string) (bool, error) {
		return false, context.DeadlineExceeded
	}
	t.Cleanup(func() { hasHoldService = prev })

	if _, err := a.GetCaptainRecord(context.Background(), holdDID); err != nil {
		t.Fatalf("GetCaptainRecord should still answer from the live fetch: %v", err)
	}
	if n := captainRows(t, a, holdDID); n != 0 {
		t.Errorf("cached %d row(s) for an unresolvable DID", n)
	}
}