Hold discovery in the registry middleware called getRecord on the repository owner's PDS for every request under /v2/: every HEAD, POST, PATCH, PUT and GET. A 10-layer push was 40 or more PDS round trips, and it was the last per-request network call on the push path that had nothing to do with moving bytes. Only two profile fields are used there: the default hold and the auto-remove-untagged flag. The users row already caches the default hold, written by the Jetstream processor on every profile event and prefilled by the backfill, and the auth gate already reads it from there. This makes the row a faithful copy of what the registry needs and switches the middleware to it. The auto-remove flag gets a nullable users column. NULL means the value has never been learned; the processor writes 0 or 1 on every profile event and never NULL. On a request whose row is missing or still NULL, the middleware does one live fetch, uses it, and writes both fields back, including a 0 for a user with no profile at all, so the fallback runs at most once per user. A failed fetch writes nothing and uses the appview default for that request, so a network error is never cached. That single mechanism covers the minutes after a deploy while the startup backfill fills the column, a brand-new user, and a user the backfill has not reached. The processor also stops returning early on an empty default hold, which left a user who removed their custom hold pushing to it forever. Empty is now written through and means the appview default, matching what the auth gate already reads. Tests count PDS requests with a test server: a populated row makes none, a NULL row makes exactly one and then none, a missing profile is cached as known, and a failed fetch degrades without writing. The migration was applied to a fresh database and to one built from the previous schema. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Yf1ZVA7sXYhQNb9tCo1m5
Database Migrations
This directory contains database migrations for the ATCR AppView database.
Schema vs Migrations
schema.sql (in parent directory) contains the complete base schema for fresh database installations. It includes all tables, indexes, and constraints.
Migrations (this directory) handle changes to existing databases:
CREATE TABLEstatements (see below — new tables need a migration too)ALTER TABLEstatements (add/modify/drop columns)UPDATEstatements (data transformations)DELETEstatements (data cleanup)- Creating/modifying indexes on existing tables
New tables go in BOTH places
InitDB skips schema.sql entirely once schema_migrations has any rows (see
hasAppliedMigrations in schema.go). A table added only to schema.sql will
never be created on an existing database — it appears on fresh installs, works
in every test, and is silently absent in production.
So a new table needs two changes:
schema.sql, for fresh installs.- A migration with
CREATE TABLE IF NOT EXISTS, for existing databases.
TestSchemaMatchesMigrations enforces this. It builds the schema both ways and
fails if they disagree, so forgetting either half is caught before it ships.
Two more rules the test cannot enforce for you
Migrations must not return rows. go-libsql rejects a row-returning statement
passed to Exec with Execute returned rows. A migration that opens with a bare
SELECT fails on every database that has not already recorded it. (Migration
0001 does exactly this; it survives only because every real database recorded it
years ago.)
Rebuild migrations must name their columns. Column order in schema.sql is
illustrative, not authoritative: migrations append with ADD COLUMN while
schema.sql places the same column mid-table, so a fresh database and an
upgraded one legitimately differ in column order on manifests, users,
devices and repo_pages. INSERT INTO new_table SELECT * FROM old_table will
therefore silently write the wrong values into the wrong columns. Always write
INSERT INTO new_table (a, b, c) SELECT a, b, c FROM old_table, as migrations
0009 and 0011 do.
Migration Format
Each migration is a YAML file with the following structure:
description: Optional human-readable description of what this migration does
query: |
SQL commands to apply the migration
Version and name are parsed from the filename, so you don't need to specify them in the YAML.
Naming Convention
Migration files must be named: {version:04d}_{migration_name}.yaml
The filename determines:
- Version: Numeric prefix (e.g.,
0001→ version 1) - Name: Everything after first underscore (e.g.,
add_repository_labels→ "add repository labels")
Examples:
0001_remove_star_count_from_repository_stats.yaml→ version 1, name "remove star count from repository stats"0002_add_repository_labels.yaml→ version 2, name "add repository labels"0003_create_webhooks_table.yaml→ version 3, name "create webhooks table"
Creating a New Migration
- Choose the next version number - Look at existing migrations and increment by 1
- Create a new YAML file with format
000N_descriptive_name.yaml - Add description (optional) - Explain what the migration does
- Write your SQL in
query- Use the|block scalar for clean multi-line SQL - Use
IF EXISTS/IF NOT EXISTSwhere possible for idempotency
Examples
Adding a column to existing table:
Filename: 0007_add_readme_url_to_manifests.yaml
description: Add readme_url column to manifests table for storing io.atcr.readme annotation
query: |
ALTER TABLE manifests ADD COLUMN readme_url TEXT;
IMPORTANT: After creating this migration, also add the column to schema.sql so fresh installations include it!
Data transformation migration:
Filename: 0005_normalize_hold_endpoint_to_did.yaml
description: Normalize hold_endpoint column to store DIDs instead of URLs
query: |
-- Convert HTTPS URLs to did:web: format
UPDATE manifests
SET hold_endpoint = 'did:web:' || substr(hold_endpoint, 9)
WHERE hold_endpoint LIKE 'https://%';
-- Convert HTTP URLs to did:web: format
UPDATE manifests
SET hold_endpoint = 'did:web:' || substr(hold_endpoint, 8)
WHERE hold_endpoint LIKE 'http://%';
Adding an index to existing table:
Filename: 0008_add_repository_description_index.yaml
description: Add index on manifests description field for faster searches
query: |
CREATE INDEX IF NOT EXISTS idx_manifests_description ON manifests(description);
How Migrations Run
- Migrations are loaded from this directory on startup
- Sorted by version number (ascending)
- Each migration is checked against the
schema_migrationstable - Only unapplied migrations are executed
- After successful execution, the version is recorded in
schema_migrations
Important Notes
- Never modify existing migrations - Once applied, they're immutable
- Test migrations before committing - Ensure they work on existing databases
- Version numbers must be unique - The migration system silently skips a duplicate, so the second file never runs (see
TestMigrationVersionsAreUnique) - Migrations run automatically on
InitDB()- Schema first, then migrations - CRITICAL: Update
schema.sqlfor every structural change - Columns, tables and indexes all need both the migration AND theschema.sqlentry, or fresh and existing databases diverge.TestSchemaMatchesMigrationsfails the build if they do - Migrations must not return rows - a bare
SELECTfails under go-libsql withExecute returned rows - Rebuild migrations must name columns explicitly - never
INSERT INTO new SELECT * FROM old; column order differs between fresh and upgraded databases - Drift is reported at boot -
InitDBlogs a warning for any difference between an existing database andschema.sql. It never fails the boot; treat the warning as a request for a corrective migration