Evan JarrettandClaude Fable 5.1 65db7945b2 appview: drop the testmode fall-back-to-default-hold probe ...

The registry middleware used to GET the user's hold's /.well-known/did.json
on every registry request in testmode builds, and fall back to the appview
default hold if it did not answer. The fallback only ever changed anything
when the user's chosen hold differed from the default AND was down; in local
development and in the integration harness the two are the same hold, so the
probe's answer was discarded every time. In the production-shaped benchmark
it was 94 of 150 hold requests per p90 push and 23 of 90 per pull, hiding
the real hold traffic behind a testmode artifact.

Remove isHoldReachable, the fallbackUnreachable field, and the probe branch.
An empty choice still means the default hold. Testmode and production now
take the same path here.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WTdBxLFU5TpwmqVdVsN1wq

2026-09-11 17:05:19 -05:00

..

authgate

remove the runtime test_mode switch; the testmode build tag is the only one

2026-09-11 11:09:44 -05:00

db

appview: read the sailor profile from the local users row, not the PDS, per request

2026-09-09 20:42:58 -05:00

handlers

scanner: fix five crash and halt classes found by a pipeline audit

2026-09-05 15:01:10 -05:00

holdclient

remove the runtime test_mode switch; the testmode build tag is the only one

2026-09-11 11:09:44 -05:00

holdhealth

vuln scanner fixes, major refactor of the credential helper.

2026-02-17 22:38:25 -06:00

holdpurge

apply go fix modernizations across the workspace

2026-09-08 22:38:01 -05:00

installscript

apply go fix modernizations across the workspace

2026-09-08 22:38:01 -05:00

jetstream

remove the runtime test_mode switch; the testmode build tag is the only one

2026-09-11 11:09:44 -05:00

labeler

fix labeler issues

2026-05-09 21:21:20 -05:00

leases

apply go fix modernizations across the workspace

2026-09-08 22:38:01 -05:00

licenses

use for range and wg.Go

2026-01-04 22:39:48 -06:00

middleware

appview: drop the testmode fall-back-to-default-hold probe

2026-09-11 17:05:19 -05:00

ogcard

more lint fixes. enable autofix

2026-01-06 23:56:17 -06:00

public

appview: give the confirm modal an accessible name and a focus trap

2026-09-02 22:31:04 -05:00

readme

large list of ui fixes for accessibility/hardening etc.

2026-04-21 21:18:13 -05:00

registryauth

appview: give each registry domain its own JWT service name

2026-08-02 20:40:55 -05:00

routes

appview: render the install scripts from config instead of shipping ATCR's

2026-09-02 21:38:10 -05:00

src

appview: give the confirm modal an accessible name and a focus trap

2026-09-02 22:31:04 -05:00

storage

appview: name uploads with a UUID, not the nanosecond clock

2026-09-10 21:43:10 -05:00

templates

appview: mark repo cards translate="no"

2026-09-11 09:25:48 -05:00

webhooks

appview: stop webhooks reaching private addresses

2026-09-02 21:37:19 -05:00

catalog_test.go

appview: refuse /v2/_catalog with UNSUPPORTED, and send Allow on every 405

2026-09-02 21:03:20 -05:00

compress_test.go

appview: gzip UI and static responses, leaving /v2 alone

2026-09-02 20:21:33 -05:00

config_test.go

remove the runtime test_mode switch; the testmode build tag is the only one

2026-09-11 11:09:44 -05:00

config.go

remove the runtime test_mode switch; the testmode build tag is the only one

2026-09-11 11:09:44 -05:00

crypto_keys_test.go

appview: stop the crypto key first-boot race

2026-08-11 21:34:42 -05:00

crypto_keys.go

appview: stop the crypto key first-boot race

2026-08-11 21:34:42 -05:00

domain_routing_test.go

appview: let a registry domain keep its port, and its /v2

2026-08-25 16:34:25 -05:00

overlay_test.go

lots of refactor and cleanup to allow for branding overrides

2026-02-02 22:42:15 -06:00

overlay.go

lots of refactor and cleanup to allow for branding overrides

2026-02-02 22:42:15 -06:00

server.go

remove the runtime test_mode switch; the testmode build tag is the only one

2026-09-11 11:09:44 -05:00

themes.go

add theme overrides

2026-02-03 20:35:13 -06:00

ui_test.go

appview: emit crane's mandatory destination in the pull command switcher

2026-09-02 21:03:01 -05:00

ui.go

appview: emit crane's mandatory destination in the pull command switcher

2026-09-02 21:03:01 -05:00