From 6d0b83f6ded5e1bc38c043a6e53ed8b876c629ec Mon Sep 17 00:00:00 2001 From: Lars Lehtonen Date: Fri, 14 Aug 2026 07:40:28 -0700 Subject: [PATCH] fix(cron): log CreateLongerRecords errors (#1926) chore(cron): comment cron tasks with pocketbase warning --- internal/records/records.go | 7 +++++-- internal/records/records_deletion.go | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/internal/records/records.go b/internal/records/records.go index fc82ac93..5162fce7 100644 --- a/internal/records/records.go +++ b/internal/records/records.go @@ -3,7 +3,7 @@ package records import ( "encoding/json" - "log" + "log/slog" "math" "time" @@ -68,15 +68,18 @@ func (rm *RecordManager) CreateLongerRecords() { }, } // wrap the operations in a transaction + // Pocketbase cron does not handle errors, log them here. rm.app.RunInTransaction(func(txApp core.App) error { var err error collections := [2]*core.Collection{} collections[0], err = txApp.FindCachedCollectionByNameOrId("system_stats") if err != nil { + slog.Error("Error finding cached collection using system stats:", "err", err) return err } collections[1], err = txApp.FindCachedCollectionByNameOrId("container_stats") if err != nil { + slog.Error("Error finding cached collection using container stats:", "err", err) return err } var systems RecordIds @@ -142,7 +145,7 @@ func (rm *RecordManager) CreateLongerRecords() { longerRecord.Set("stats", rm.AverageContainerStats(db, recordIds)) } if err := txApp.SaveNoValidate(longerRecord); err != nil { - log.Println("failed to save longer record", "err", err) + slog.Error("failed to save longer record", "err", err) } } } diff --git a/internal/records/records_deletion.go b/internal/records/records_deletion.go index 10c212d3..6632ded9 100644 --- a/internal/records/records_deletion.go +++ b/internal/records/records_deletion.go @@ -12,6 +12,7 @@ import ( // Delete old records func (rm *RecordManager) DeleteOldRecords() { + // Pocketbase cron does not handle errors, log them here. rm.app.RunInTransaction(func(txApp core.App) error { err := deleteOldSystemStats(txApp) if err != nil {