diff --git a/Makefile b/Makefile index 3bbb1ec3..8b8becda 100644 --- a/Makefile +++ b/Makefile @@ -52,7 +52,7 @@ lint: golangci-lint run test: - go test -tags=testing ./... + go test -tags='testing no_ui' ./... tidy: go mod tidy diff --git a/internal/alerts/alerts_quiet_hours_test.go b/internal/alerts/alerts_quiet_hours_test.go index 94106d5e..328e99ce 100644 --- a/internal/alerts/alerts_quiet_hours_test.go +++ b/internal/alerts/alerts_quiet_hours_test.go @@ -322,8 +322,9 @@ func TestAlertSilencedMultiUser(t *testing.T) { } func TestAlertSilencedWithActualAlert(t *testing.T) { + hub, user := beszelTests.GetHubWithUser(t) + synctest.Test(t, func(t *testing.T) { - hub, user := beszelTests.GetHubWithUser(t) defer hub.Cleanup() // Create a system diff --git a/internal/alerts/alerts_status_test.go b/internal/alerts/alerts_status_test.go index 2e2f11b9..ecfc0c0f 100644 --- a/internal/alerts/alerts_status_test.go +++ b/internal/alerts/alerts_status_test.go @@ -29,8 +29,9 @@ func setStatusAlertEmail(t *testing.T, hub core.App, userID, email string) { } func TestStatusAlerts(t *testing.T) { + hub, user := beszelTests.GetHubWithUser(t) + synctest.Test(t, func(t *testing.T) { - hub, user := beszelTests.GetHubWithUser(t) defer hub.Cleanup() systems, err := beszelTests.CreateSystems(hub, 4, user.Id, "paused") @@ -234,8 +235,9 @@ func TestHandleStatusAlertsDoesNotSendRecoveryWhileDownIsOnlyPending(t *testing. } func TestStatusAlertTimerCancellationPreventsBoundaryDelivery(t *testing.T) { + hub, user := beszelTests.GetHubWithUser(t) + synctest.Test(t, func(t *testing.T) { - hub, user := beszelTests.GetHubWithUser(t) defer hub.Cleanup() userSettings, err := hub.FindFirstRecordByFilter("user_settings", "user={:user}", map[string]any{"user": user.Id}) @@ -336,8 +338,9 @@ func TestStatusAlertDownFiresAfterDelayExpires(t *testing.T) { } func TestStatusAlertMultipleUsersRespectDifferentMinutes(t *testing.T) { + hub, user1 := beszelTests.GetHubWithUser(t) + synctest.Test(t, func(t *testing.T) { - hub, user1 := beszelTests.GetHubWithUser(t) defer hub.Cleanup() setStatusAlertEmail(t, hub, user1.Id, "user1@example.com") @@ -423,8 +426,9 @@ func TestStatusAlertMultipleUsersRespectDifferentMinutes(t *testing.T) { } func TestStatusAlertMultipleUsersRecoveryBetweenMinutesOnlyAlertsEarlierUser(t *testing.T) { + hub, user1 := beszelTests.GetHubWithUser(t) + synctest.Test(t, func(t *testing.T) { - hub, user1 := beszelTests.GetHubWithUser(t) defer hub.Cleanup() setStatusAlertEmail(t, hub, user1.Id, "user1@example.com") @@ -816,8 +820,9 @@ func TestResolveStatusAlerts(t *testing.T) { } func TestAlertsHistoryStatus(t *testing.T) { + hub, user := beszelTests.GetHubWithUser(t) + synctest.Test(t, func(t *testing.T) { - hub, user := beszelTests.GetHubWithUser(t) defer hub.Cleanup() // Create a system @@ -882,8 +887,9 @@ func TestAlertsHistoryStatus(t *testing.T) { } func TestStatusAlertClearedBeforeSend(t *testing.T) { + hub, user := beszelTests.GetHubWithUser(t) + synctest.Test(t, func(t *testing.T) { - hub, user := beszelTests.GetHubWithUser(t) defer hub.Cleanup() // Create a system diff --git a/internal/alerts/alerts_system_test.go b/internal/alerts/alerts_system_test.go index ea06350b..8c168066 100644 --- a/internal/alerts/alerts_system_test.go +++ b/internal/alerts/alerts_system_test.go @@ -95,11 +95,10 @@ func waitForSystemAlert(d time.Duration) { func testOneMinuteSystemAlert[T any](t *testing.T, alertName string, threshold float64, setValue systemAlertValueSetter[T], triggerValue, resolveValue T) { t.Helper() + fixture := newSystemAlertTestFixture(t, alertName, 1, threshold) + defer fixture.cleanup() synctest.Test(t, func(t *testing.T) { - fixture := newSystemAlertTestFixture(t, alertName, 1, threshold) - defer fixture.cleanup() - submitValue(fixture, t, triggerValue, setValue) waitForSystemAlert(time.Second) @@ -118,11 +117,10 @@ func testOneMinuteSystemAlert[T any](t *testing.T, alertName string, threshold f func testMultiMinuteSystemAlert[T any](t *testing.T, alertName string, threshold float64, min int, setValue systemAlertValueSetter[T], baselineValue, triggerValue, resolveValue T) { t.Helper() + fixture := newSystemAlertTestFixture(t, alertName, min, threshold) + defer fixture.cleanup() synctest.Test(t, func(t *testing.T) { - fixture := newSystemAlertTestFixture(t, alertName, min, threshold) - defer fixture.cleanup() - submitValue(fixture, t, baselineValue, setValue) waitForSystemAlert(time.Minute + time.Second) fixture.assertTriggered(t, false, "Alert should not be triggered yet") diff --git a/internal/alerts/alerts_test.go b/internal/alerts/alerts_test.go index cdaf5f56..a40bf913 100644 --- a/internal/alerts/alerts_test.go +++ b/internal/alerts/alerts_test.go @@ -15,8 +15,9 @@ import ( ) func TestAlertsHistory(t *testing.T) { + hub, user := beszelTests.GetHubWithUser(t) + synctest.Test(t, func(t *testing.T) { - hub, user := beszelTests.GetHubWithUser(t) defer hub.Cleanup() // Create systems and alerts diff --git a/internal/hub/config/config_test.go b/internal/hub/config/config_test.go index e38cd0f4..4675a3b4 100644 --- a/internal/hub/config/config_test.go +++ b/internal/hub/config/config_test.go @@ -64,7 +64,7 @@ func createConfigTestFingerprint(app core.App, systemID, token, fingerprint stri // TestConfigSyncWithTokens tests the config.SyncSystems function with various token scenarios func TestConfigSyncWithTokens(t *testing.T) { - testHub, err := tests.NewTestHub() + testHub, err := tests.NewTestHub(t.TempDir()) require.NoError(t, err) defer testHub.Cleanup()