From 146121e23d3d98c479ef0f629e7dacdb9e6f62b6 Mon Sep 17 00:00:00 2001 From: Alexandre Snarskii Date: Wed, 14 Jun 2017 17:56:23 +0300 Subject: [PATCH] openbgpd: generate empty list when no -a provided. --- bgpq3_printer.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/bgpq3_printer.c b/bgpq3_printer.c index 72ea83e..d470bfb 100644 --- a/bgpq3_printer.c +++ b/bgpq3_printer.c @@ -870,7 +870,14 @@ int bgpq3_print_openbgpd_prefixlist(FILE* f, struct bgpq_expander* b) { bname=b->name ? b->name : "NN"; - if (!sx_radix_tree_empty(b->tree)) { + if (sx_radix_tree_empty(b->tree)) { + fprintf(f, "# generated prefix-list %s (AS %u) is empty\n", bname, + b->asnumber); + if (!b->asnumber) + fprintf(f, "# use -a to generate \"deny from ASN \" " + "instead of this list\n"); + }; + if (!sx_radix_tree_empty(b->tree) || !b->asnumber) { if(b->name){ if(strcmp(b->name, "NN") != 0) { fprintf(f, "%s=\"", b->name); @@ -886,9 +893,7 @@ bgpq3_print_openbgpd_prefixlist(FILE* f, struct bgpq_expander* b) } fprintf(f, "\n"); } else { - fprintf(f, "# generated prefix-list %s (AS %u) is empty\n", bname, - b->asnumber); - fprintf(f, "%sdeny from AS %u\n", b->asnumber ? "": "#", b->asnumber); + fprintf(f, "deny from AS %u\n", b->asnumber); }; return 0; };