From d9bff685556864e51cad1f91c11cc0b7b6572fef Mon Sep 17 00:00:00 2001 From: Tobias Hagemann Date: Wed, 30 Nov 2016 17:22:29 +0100 Subject: [PATCH 1/6] updated localization stuff - added title text to upgrade strategy - added texts for upgrade 4 to 5 - changed most texts to title style capitalization --- .../ui/controllers/UpgradeController.java | 20 +++++-- .../cryptomator/ui/model/UpgradeStrategy.java | 9 ++- .../UpgradeVersion3DropBundleExtension.java | 7 ++- .../ui/model/UpgradeVersion3to4.java | 7 ++- .../ui/model/UpgradeVersion4to5.java | 11 +++- main/ui/src/main/resources/fxml/upgrade.fxml | 18 +++--- .../ui/src/main/resources/localization/en.txt | 60 ++++++++++--------- 7 files changed, 85 insertions(+), 47 deletions(-) diff --git a/main/ui/src/main/java/org/cryptomator/ui/controllers/UpgradeController.java b/main/ui/src/main/java/org/cryptomator/ui/controllers/UpgradeController.java index 8e6a4e97f..48dc21fa5 100644 --- a/main/ui/src/main/java/org/cryptomator/ui/controllers/UpgradeController.java +++ b/main/ui/src/main/java/org/cryptomator/ui/controllers/UpgradeController.java @@ -41,7 +41,10 @@ public class UpgradeController extends LocalizedFXMLViewController { } @FXML - private Label upgradeLabel; + private Label upgradeTitleLabel; + + @FXML + private Label upgradeMsgLabel; @FXML private SecPasswordField passwordField; @@ -60,8 +63,11 @@ public class UpgradeController extends LocalizedFXMLViewController { @Override protected void initialize() { - upgradeLabel.textProperty().bind(EasyBind.monadic(strategy).map(instruction -> { - return instruction.map(this::upgradeNotification).orElse(""); + upgradeTitleLabel.textProperty().bind(EasyBind.monadic(strategy).map(instruction -> { + return instruction.map(this::upgradeTitle).orElse(""); + }).orElse("")); + upgradeMsgLabel.textProperty().bind(EasyBind.monadic(strategy).map(instruction -> { + return instruction.map(this::upgradeMessage).orElse(""); }).orElse("")); BooleanExpression passwordProvided = passwordField.textProperty().isNotEmpty().and(passwordField.disabledProperty().not()); @@ -87,8 +93,12 @@ public class UpgradeController extends LocalizedFXMLViewController { // Upgrade label // **************************************** - private String upgradeNotification(UpgradeStrategy instruction) { - return instruction.getNotification(vault); + private String upgradeTitle(UpgradeStrategy instruction) { + return instruction.getTitle(vault); + } + + private String upgradeMessage(UpgradeStrategy instruction) { + return instruction.getMessage(vault); } // **************************************** diff --git a/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeStrategy.java b/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeStrategy.java index 9dba19a37..2ef55dd77 100644 --- a/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeStrategy.java +++ b/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeStrategy.java @@ -33,9 +33,14 @@ public abstract class UpgradeStrategy { } /** - * @return Localized string to display to the user when an upgrade is needed. + * @return Localized title string to display to the user when an upgrade is needed. */ - public abstract String getNotification(Vault vault); + public abstract String getTitle(Vault vault); + + /** + * @return Localized message string to display to the user when an upgrade is needed. + */ + public abstract String getMessage(Vault vault); /** * Upgrades a vault. Might take a moment, should be run in a background thread. diff --git a/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion3DropBundleExtension.java b/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion3DropBundleExtension.java index 873c69716..60087419f 100644 --- a/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion3DropBundleExtension.java +++ b/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion3DropBundleExtension.java @@ -32,7 +32,12 @@ class UpgradeVersion3DropBundleExtension extends UpgradeStrategy { } @Override - public String getNotification(Vault vault) { + public String getTitle(Vault vault) { + return localization.getString("upgrade.version3dropBundleExtension.title"); + } + + @Override + public String getMessage(Vault vault) { String fmt = localization.getString("upgrade.version3dropBundleExtension.msg"); Path path = vault.path().getValue(); String oldVaultName = path.getFileName().toString(); diff --git a/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion3to4.java b/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion3to4.java index 49b5c13a3..0ba05a58f 100644 --- a/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion3to4.java +++ b/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion3to4.java @@ -50,7 +50,12 @@ class UpgradeVersion3to4 extends UpgradeStrategy { } @Override - public String getNotification(Vault vault) { + public String getTitle(Vault vault) { + return localization.getString("upgrade.version3to4.title"); + } + + @Override + public String getMessage(Vault vault) { return localization.getString("upgrade.version3to4.msg"); } diff --git a/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion4to5.java b/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion4to5.java index 0629083d6..936a2c8ba 100644 --- a/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion4to5.java +++ b/main/ui/src/main/java/org/cryptomator/ui/model/UpgradeVersion4to5.java @@ -40,8 +40,13 @@ class UpgradeVersion4to5 extends UpgradeStrategy { } @Override - public String getNotification(Vault vault) { - return localization.getString("upgrade.version3to4.msg"); + public String getTitle(Vault vault) { + return localization.getString("upgrade.version4to5.title"); + } + + @Override + public String getMessage(Vault vault) { + return localization.getString("upgrade.version4to5.msg"); } @Override @@ -66,7 +71,7 @@ class UpgradeVersion4to5 extends UpgradeStrategy { }); } catch (IOException e) { LOG.error("Migration failed.", e); - throw new UpgradeFailedException(localization.getString("upgrade.version3to4.err.io")); + throw new UpgradeFailedException(localization.getString("upgrade.version4to5.err.io")); } LOG.info("Migration finished."); } diff --git a/main/ui/src/main/resources/fxml/upgrade.fxml b/main/ui/src/main/resources/fxml/upgrade.fxml index 24fc99d0a..966f529c2 100644 --- a/main/ui/src/main/resources/fxml/upgrade.fxml +++ b/main/ui/src/main/resources/fxml/upgrade.fxml @@ -31,22 +31,24 @@ -