diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 61841a0d8..2cd23a297 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -243,7 +243,7 @@ jobs: shell: pwsh - name: Download WinFsp run: | - $winfspUrl= (Select-String -Path ".\dist\win\bundle\resources\winfsp-download.url" -Pattern 'https:.*').Matches.Value + $winfspUrl= (Select-String -Path ".\bundle\resources\winFspMetaData.wxi" -Pattern '<\?define BundledWinFspDownloadLink="(.+)".*?>').Matches.Groups[1].Value curl --output dist/win/bundle/resources/winfsp.msi -L $winfspUrl shell: pwsh - name: Compile to wixObj file diff --git a/dist/win/build.ps1 b/dist/win/build.ps1 index d842423a1..74532a96a 100644 --- a/dist/win/build.ps1 +++ b/dist/win/build.ps1 @@ -153,7 +153,7 @@ $Env:JP_WIXWIZARD_RESOURCES = "$buildDir\resources" # download Winfsp [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 $ProgressPreference = 'SilentlyContinue' # disables Invoke-WebRequest's progress bar, which slows down downloads to a few bytes/s -$winfspMsiUrl= (Select-String -Path ".\bundle\resources\winfsp-download.url" -Pattern 'https:.*').Matches.Value +$winfspMsiUrl= (Select-String -Path ".\bundle\resources\winFspMetaData.wxi" -Pattern '<\?define BundledWinFspDownloadLink="(.+)".*?>').Matches.Groups[1].Value Write-Output "Downloading ${winfspMsiUrl}..." Invoke-WebRequest $winfspMsiUrl -OutFile ".\bundle\resources\winfsp.msi" # redirects are followed by default @@ -161,11 +161,11 @@ Invoke-WebRequest $winfspMsiUrl -OutFile ".\bundle\resources\winfsp.msi" # redir Copy-Item ".\installer\$AppName-*.msi" -Destination ".\bundle\resources\$AppName.msi" # create bundle including winfsp -& "$env:WIX\bin\candle.exe" .\bundle\bundleWithWinfsp.wxs -ext WixBalExtension -out bundle\ ` +& "$env:WIX\bin\candle.exe" .\bundle\bundleWithWinfsp.wxs -ext WixBalExtension -ext WixUtilextension -out bundle\ ` -dBundleVersion="$semVerNo.$revisionNo" ` -dBundleVendor="$Vendor" ` -dBundleCopyright="$copyright" ` -dAboutUrl="$AboutUrl" ` -dHelpUrl="$HelpUrl" ` -dUpdateUrl="$UpdateUrl" -& "$env:WIX\bin\light.exe" -b . .\bundle\BundlewithWinfsp.wixobj -ext WixBalExtension -out installer\$AppName-Installer.exe \ No newline at end of file +& "$env:WIX\bin\light.exe" -b . .\bundle\BundlewithWinfsp.wixobj -ext WixBalExtension -ext WixUtilextension -out installer\$AppName-Installer.exe \ No newline at end of file diff --git a/dist/win/bundle/bundleWithWinfsp.wxs b/dist/win/bundle/bundleWithWinfsp.wxs index 91093df7d..136673a72 100644 --- a/dist/win/bundle/bundleWithWinfsp.wxs +++ b/dist/win/bundle/bundleWithWinfsp.wxs @@ -1,13 +1,30 @@ - + + + + + + + (InstalledWinFspVersion = v0.0.0.0) OR ($(var.BundledWinFspVersion) <= InstalledWinFspVersion) + diff --git a/dist/win/bundle/customBootstrapperTheme.xml b/dist/win/bundle/customBootstrapperTheme.xml index 792f51a35..ef986bd27 100644 --- a/dist/win/bundle/customBootstrapperTheme.xml +++ b/dist/win/bundle/customBootstrapperTheme.xml @@ -10,6 +10,7 @@ Segoe UI Segoe UI Segoe UI + Segoe UI #(loc.Title) @@ -82,7 +83,7 @@ #(loc.FailureUninstallHeader) #(loc.FailureRepairHeader) #(loc.FailureHyperlinkLogText) - + #(loc.FailureRestartText) diff --git a/dist/win/bundle/resources/winFspMetaData.wxi b/dist/win/bundle/resources/winFspMetaData.wxi new file mode 100644 index 000000000..372c8c9e6 --- /dev/null +++ b/dist/win/bundle/resources/winFspMetaData.wxi @@ -0,0 +1,7 @@ + + + + + + + \ No newline at end of file diff --git a/dist/win/bundle/resources/winfsp-download.url b/dist/win/bundle/resources/winfsp-download.url deleted file mode 100644 index d29e5e1a5..000000000 --- a/dist/win/bundle/resources/winfsp-download.url +++ /dev/null @@ -1,2 +0,0 @@ -[InternetShortcut] -URL=https://github.com/winfsp/winfsp/releases/download/v1.12.22339/winfsp-1.12.22339.msi \ No newline at end of file