From 0ddd6d767d3c380a88aba872d27f124543fe6238 Mon Sep 17 00:00:00 2001 From: jellemdekker Date: Mon, 9 Jul 2018 16:42:53 +0200 Subject: [PATCH 01/22] Implemented confirmation dialog when graceful shutdown of Cryptomator fails, so that the user can try again or opt to shutdown forcefully. --- .../ui/controllers/MainController.java | 22 ++++++++++++++++++- .../ui/util/DialogBuilderUtil.java | 4 ++++ .../ui/src/main/resources/localization/en.txt | 5 +++++ 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/main/ui/src/main/java/org/cryptomator/ui/controllers/MainController.java b/main/ui/src/main/java/org/cryptomator/ui/controllers/MainController.java index 9cb42f13d..e994b3180 100644 --- a/main/ui/src/main/java/org/cryptomator/ui/controllers/MainController.java +++ b/main/ui/src/main/java/org/cryptomator/ui/controllers/MainController.java @@ -216,7 +216,27 @@ public class MainController implements ViewController { private void gracefulShutdown() { vaults.filtered(Vault.NOT_LOCKED).forEach(Vault::prepareForShutdown); - Platform.runLater(Platform::exit); + if (!vaults.filtered(Vault.NOT_LOCKED).isEmpty()) { + ButtonType tryAgainButtonType = new ButtonType( + localization.getString("main.gracefulShutdown.button.tryAgain")); + ButtonType forceShutdownButtonType = new ButtonType( + localization.getString("main.gracefulShutdown.button.forceShutdown")); + Alert gracefulShutdownDialog = DialogBuilderUtil.buildGracefulShutdownDialog( + localization.getString("main.gracefulShutdown.dialog.title"), + localization.getString("main.gracefulShutdown.dialog.header"), + localization.getString("main.gracefulShutdown.dialog.content"), + tryAgainButtonType, + forceShutdownButtonType); + + Optional choice = gracefulShutdownDialog.showAndWait(); + if (choice.isPresent()) { + if (tryAgainButtonType.equals(choice.get())) { + gracefulShutdown(); + } else if (forceShutdownButtonType.equals(choice.get())) { + Platform.runLater(Platform::exit); + } + } + } } private void loadFont(String resourcePath) { diff --git a/main/ui/src/main/java/org/cryptomator/ui/util/DialogBuilderUtil.java b/main/ui/src/main/java/org/cryptomator/ui/util/DialogBuilderUtil.java index 59741e2f2..0f6990415 100644 --- a/main/ui/src/main/java/org/cryptomator/ui/util/DialogBuilderUtil.java +++ b/main/ui/src/main/java/org/cryptomator/ui/util/DialogBuilderUtil.java @@ -38,6 +38,10 @@ public class DialogBuilderUtil { return buildDialog(title, header, content, Alert.AlertType.CONFIRMATION, defaultButton, ButtonType.YES, ButtonType.NO); } + public static Alert buildGracefulShutdownDialog(String title, String header, String content, ButtonType tryAgainButton, ButtonType forceShutdownButton) { + return buildDialog(title, header, content, Alert.AlertType.WARNING, tryAgainButton, tryAgainButton, forceShutdownButton); + } + private static Alert buildDialog(String title, String header, String content, Alert.AlertType type, ButtonType defaultButton, ButtonType... buttons) { Text contentText = new Text(content); contentText.setWrappingWidth(360.0); diff --git a/main/ui/src/main/resources/localization/en.txt b/main/ui/src/main/resources/localization/en.txt index 42d63b7ce..4885ed0e4 100644 --- a/main/ui/src/main/resources/localization/en.txt +++ b/main/ui/src/main/resources/localization/en.txt @@ -19,6 +19,11 @@ main.directoryList.remove.confirmation.content=The vault will only be removed fr main.createVault.nonEmptyDir.title=Creating vault failed main.createVault.nonEmptyDir.header=Chosen directory is not empty main.createVault.nonEmptyDir.content=The selected directory already contains files (possibly hidden). A vault can only be created in an empty directory. +main.gracefulShutdown.dialog.title=Locking vault(s) failed +main.gracefulShutdown.dialog.header=Vault(s) in use +main.gracefulShutdown.dialog.content=One or more vaults are still in use by other programs. Please close them to allow Cryptomator to shut down properly, then try again.\n\nIf this doesn't work, Cryptomator can shut down forcefully, but this can incur data loss and is not recommended. +main.gracefulShutdown.button.tryAgain=Try again +main.gracefulShutdown.button.forceShutdown=Force shutdown # welcome.fxml welcome.checkForUpdates.label.currentlyChecking=Checking for Updates... From 7392a99da5ca7f7dfc33f648b56fdd4cd1814816 Mon Sep 17 00:00:00 2001 From: infeo Date: Tue, 17 Jul 2018 18:17:27 +0200 Subject: [PATCH 02/22] small ui fix: text for using individual mount path is not shown completely --- main/ui/src/main/resources/fxml/unlock.fxml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main/ui/src/main/resources/fxml/unlock.fxml b/main/ui/src/main/resources/fxml/unlock.fxml index 3e7d88940..43928d9e4 100644 --- a/main/ui/src/main/resources/fxml/unlock.fxml +++ b/main/ui/src/main/resources/fxml/unlock.fxml @@ -88,7 +88,7 @@ - +