From d19e77432e271327701aff9b4e3554e12d9d692b Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Wed, 21 Sep 2022 09:28:37 +0200 Subject: [PATCH 01/35] build with jdk 19 --- .github/workflows/appimage.yml | 4 ++-- .github/workflows/build.yml | 4 ++-- .github/workflows/debian.yml | 4 ++-- .github/workflows/mac-dmg.yml | 4 ++-- .github/workflows/pullrequest.yml | 4 ++-- .github/workflows/win-exe.yml | 4 ++-- .idea/misc.xml | 2 +- pom.xml | 16 ++++++++-------- 8 files changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/appimage.yml b/.github/workflows/appimage.yml index 7027c9ddf..e18f048a6 100644 --- a/.github/workflows/appimage.yml +++ b/.github/workflows/appimage.yml @@ -10,7 +10,7 @@ on: required: false env: - JAVA_VERSION: 17 + JAVA_VERSION: 19 jobs: build: @@ -23,7 +23,7 @@ jobs: - name: Setup Java uses: actions/setup-java@v2 with: - distribution: 'temurin' + distribution: 'zulu' java-version: ${{ env.JAVA_VERSION }} cache: 'maven' - id: versions diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5270365b3..3707cd46f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -6,7 +6,7 @@ on: types: [labeled] env: - JAVA_VERSION: 17 + JAVA_VERSION: 19 defaults: run: @@ -21,7 +21,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-java@v2 with: - distribution: 'temurin' + distribution: 'zulu' java-version: ${{ env.JAVA_VERSION }} cache: 'maven' - name: Cache SonarCloud packages diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index 6f43b5155..fb0a8f9e3 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -15,7 +15,7 @@ on: required: false env: - JAVA_VERSION: 17 + JAVA_VERSION: 19 jobs: build: @@ -32,7 +32,7 @@ jobs: - name: Setup Java uses: actions/setup-java@v2 with: - distribution: 'temurin' + distribution: 'zulu' java-version: ${{ env.JAVA_VERSION }} cache: 'maven' - id: versions diff --git a/.github/workflows/mac-dmg.yml b/.github/workflows/mac-dmg.yml index 0d175fbf9..21a790fa0 100644 --- a/.github/workflows/mac-dmg.yml +++ b/.github/workflows/mac-dmg.yml @@ -10,7 +10,7 @@ on: required: false env: - JAVA_VERSION: 17 + JAVA_VERSION: 19 jobs: build: @@ -33,7 +33,7 @@ jobs: - name: Setup Java uses: actions/setup-java@v3 with: - distribution: 'temurin' + distribution: 'zulu' java-version: ${{ env.JAVA_VERSION }} architecture: ${{ matrix.architecture }} cache: 'maven' diff --git a/.github/workflows/pullrequest.yml b/.github/workflows/pullrequest.yml index 79a0d5a21..66fab46a5 100644 --- a/.github/workflows/pullrequest.yml +++ b/.github/workflows/pullrequest.yml @@ -4,7 +4,7 @@ on: pull_request: env: - JAVA_VERSION: 17 + JAVA_VERSION: 19 defaults: run: @@ -19,7 +19,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-java@v2 with: - distribution: 'temurin' + distribution: 'zulu' java-version: ${{ env.JAVA_VERSION }} cache: 'maven' - name: Build and Test diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 91d967bf7..8cbdad21e 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -15,7 +15,7 @@ on: default: false env: - JAVA_VERSION: 17 + JAVA_VERSION: 19 defaults: run: @@ -32,7 +32,7 @@ jobs: - name: Setup Java uses: actions/setup-java@v2 with: - distribution: 'temurin' + distribution: 'zulu' java-version: ${{ env.JAVA_VERSION }} cache: 'maven' - id: versions diff --git a/.idea/misc.xml b/.idea/misc.xml index 4731638fd..e5d629592 100644 --- a/.idea/misc.xml +++ b/.idea/misc.xml @@ -8,7 +8,7 @@ - + \ No newline at end of file diff --git a/pom.xml b/pom.xml index ba9f44c88..1fd9855d8 100644 --- a/pom.xml +++ b/pom.xml @@ -21,7 +21,7 @@ UTF-8 - 17 + 19 com.github.serceman,com.github.jnr,org.ow2.asm,net.java.dev.jna,org.apache.jackrabbit,org.apache.httpcomponents,de.swiesend,org.purejava,com.github.hypfvieh @@ -52,14 +52,14 @@ 1.7.0 - 5.8.1 - 4.4.0 + 5.9.1 + 4.8.0 2.2 23.0.0 - 7.1.0 - 0.8.7 + 7.2.1 + 0.8.8 @@ -263,7 +263,7 @@ org.apache.maven.plugins maven-resources-plugin - 3.2.0 + 3.3.0 org.apache.maven.plugins @@ -273,7 +273,7 @@ org.apache.maven.plugins maven-surefire-plugin - 3.0.0-M5 + 3.0.0-M7 org.codehaus.mojo @@ -283,7 +283,7 @@ org.apache.maven.plugins maven-jar-plugin - 3.2.2 + 3.3.0 org.jacoco From cde67966daf644cd899a275d781f57c35eee6401 Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Wed, 21 Sep 2022 09:49:57 +0200 Subject: [PATCH 02/35] fix test --- .../java/org/cryptomator/launcher/SupportedLanguagesTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/cryptomator/launcher/SupportedLanguagesTest.java b/src/test/java/org/cryptomator/launcher/SupportedLanguagesTest.java index 5a9f1bc07..7d76409e8 100644 --- a/src/test/java/org/cryptomator/launcher/SupportedLanguagesTest.java +++ b/src/test/java/org/cryptomator/launcher/SupportedLanguagesTest.java @@ -18,7 +18,7 @@ public class SupportedLanguagesTest { var locale = Locale.forLanguageTag(tag); Assertions.assertNotEquals("und", locale.toLanguageTag(), "Undefined language tag"); - var bundle = Assertions.assertDoesNotThrow(() -> ResourceBundle.getBundle("/i18n/strings", locale)); + var bundle = Assertions.assertDoesNotThrow(() -> ResourceBundle.getBundle("i18n.strings", locale)); Assertions.assertEquals(locale, bundle.getLocale()); Assertions.assertFalse(bundle.keySet().isEmpty()); From dd31908f3a784dc27412b9dad772eb44e0a3b8a2 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Wed, 21 Sep 2022 15:50:08 +0200 Subject: [PATCH 03/35] Use for windows exe and msi build same JDKs --- .github/workflows/win-exe.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 8cbdad21e..55ee4b2b0 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -16,6 +16,8 @@ on: env: JAVA_VERSION: 19 + JAVA_DIST: 'zulu' + JAVA_CACHE: 'maven' defaults: run: @@ -32,9 +34,9 @@ jobs: - name: Setup Java uses: actions/setup-java@v2 with: - distribution: 'zulu' + distribution: ${{ env.JAVA_DIST }} java-version: ${{ env.JAVA_VERSION }} - cache: 'maven' + cache: ${{ env.JAVA_CACHE }} - id: versions name: Apply version information run: | @@ -223,9 +225,9 @@ jobs: run: mv dist/win/bundle/resources/Cryptomator*.msi dist/win/bundle/resources/Cryptomator.msi - uses: actions/setup-java@v2 with: - distribution: 'temurin' + distribution: ${{ env.JAVA_DIST }} java-version: ${{ env.JAVA_VERSION }} - cache: 'maven' + cache: ${{ env.JAVA_CACHE }} - name: Generate license for exe run: > mvn -B license:add-third-party From 76e7a0a7b83e087d088470c959cb21cc644ac7b0 Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Mon, 10 Oct 2022 10:24:42 +0200 Subject: [PATCH 04/35] bump OpenJFX to version 19 replaced EasyBind with `ObservableValue.map()` where possible --- pom.xml | 2 +- .../ui/common/NewPasswordController.java | 3 +- .../ui/health/CheckDetailController.java | 54 ++++++++-------- .../ui/health/CheckListCellController.java | 15 +++-- .../ui/health/ResultListCellController.java | 13 ++-- .../ui/mainwindow/VaultDetailController.java | 13 ++-- .../VaultDetailLockedController.java | 4 +- .../mainwindow/VaultListCellController.java | 13 ++-- .../VaultListContextMenuController.java | 62 +++++++++---------- 9 files changed, 86 insertions(+), 93 deletions(-) diff --git a/pom.xml b/pom.xml index bf13f4771..106949421 100644 --- a/pom.xml +++ b/pom.xml @@ -43,7 +43,7 @@ 2.2 31.1-jre 2.9.1 - 18.0.2 + 19 4.0.0 9.25.4 1.4.3 diff --git a/src/main/java/org/cryptomator/ui/common/NewPasswordController.java b/src/main/java/org/cryptomator/ui/common/NewPasswordController.java index caa0962f8..6f029efe1 100644 --- a/src/main/java/org/cryptomator/ui/common/NewPasswordController.java +++ b/src/main/java/org/cryptomator/ui/common/NewPasswordController.java @@ -1,6 +1,5 @@ package org.cryptomator.ui.common; -import com.tobiasdiez.easybind.EasyBind; import org.cryptomator.ui.controls.FontAwesome5IconView; import org.cryptomator.ui.controls.NiceSecurePasswordField; @@ -42,7 +41,7 @@ public class NewPasswordController implements FxController { passwordStrength.bind(Bindings.createIntegerBinding(() -> strengthRater.computeRate(passwordField.getCharacters()), passwordField.textProperty())); passwordStrengthLabel.graphicProperty().bind(Bindings.createObjectBinding(this::getIconViewForPasswordStrengthLabel, passwordField.textProperty(), passwordStrength)); - passwordStrengthLabel.textProperty().bind(EasyBind.map(passwordStrength, strengthRater::getStrengthDescription)); + passwordStrengthLabel.textProperty().bind(passwordStrength.map(strengthRater::getStrengthDescription)); BooleanBinding passwordsMatch = Bindings.createBooleanBinding(this::passwordFieldsMatch, passwordField.textProperty(), reenterField.textProperty()); BooleanBinding reenterFieldNotEmpty = reenterField.textProperty().isNotEmpty(); diff --git a/src/main/java/org/cryptomator/ui/health/CheckDetailController.java b/src/main/java/org/cryptomator/ui/health/CheckDetailController.java index 66f2e9bf5..c467a5328 100644 --- a/src/main/java/org/cryptomator/ui/health/CheckDetailController.java +++ b/src/main/java/org/cryptomator/ui/health/CheckDetailController.java @@ -3,12 +3,12 @@ package org.cryptomator.ui.health; import com.tobiasdiez.easybind.EasyBind; import com.tobiasdiez.easybind.EasyObservableList; import com.tobiasdiez.easybind.Subscription; -import com.tobiasdiez.easybind.optional.OptionalBinding; import org.cryptomator.cryptofs.health.api.DiagnosticResult; import org.cryptomator.ui.common.FxController; import javax.inject.Inject; import javafx.beans.binding.Binding; +import javafx.beans.binding.BooleanExpression; import javafx.beans.property.ObjectProperty; import javafx.beans.value.ObservableValue; import javafx.collections.FXCollections; @@ -22,15 +22,15 @@ public class CheckDetailController implements FxController { private final EasyObservableList results; private final ObjectProperty check; - private final OptionalBinding checkState; - private final Binding checkName; - private final Binding checkRunning; - private final Binding checkScheduled; - private final Binding checkFinished; - private final Binding checkSkipped; - private final Binding checkSucceeded; - private final Binding checkFailed; - private final Binding checkCancelled; + private final ObservableValue checkState; + private final ObservableValue checkName; + private final BooleanExpression checkRunning; + private final BooleanExpression checkScheduled; + private final BooleanExpression checkFinished; + private final BooleanExpression checkSkipped; + private final BooleanExpression checkSucceeded; + private final BooleanExpression checkFailed; + private final BooleanExpression checkCancelled; private final Binding countOfWarnSeverity; private final Binding countOfCritSeverity; private final Binding warnOrCritsExist; @@ -44,15 +44,15 @@ public class CheckDetailController implements FxController { this.resultListCellFactory = resultListCellFactory; this.results = EasyBind.wrapList(FXCollections.observableArrayList()); this.check = selectedTask; - this.checkState = EasyBind.wrapNullable(selectedTask).mapObservable(Check::stateProperty); - this.checkName = EasyBind.wrapNullable(selectedTask).map(Check::getName).orElse(""); - this.checkRunning = checkState.map(Check.CheckState.RUNNING::equals).orElse(false); - this.checkScheduled = checkState.map(Check.CheckState.SCHEDULED::equals).orElse(false); - this.checkSkipped = checkState.map(Check.CheckState.SKIPPED::equals).orElse(false); - this.checkSucceeded = checkState.map(Check.CheckState.SUCCEEDED::equals).orElse(false); - this.checkFailed = checkState.map(Check.CheckState.ERROR::equals).orElse(false); - this.checkCancelled = checkState.map(Check.CheckState.CANCELLED::equals).orElse(false); - this.checkFinished = EasyBind.combine(checkSucceeded, checkFailed, checkCancelled, (a, b, c) -> a || b || c); + this.checkState = selectedTask.flatMap(Check::stateProperty); + this.checkName = selectedTask.map(Check::getName).orElse(""); + this.checkRunning = BooleanExpression.booleanExpression(checkState.map(Check.CheckState.RUNNING::equals).orElse(false)); + this.checkScheduled = BooleanExpression.booleanExpression(checkState.map(Check.CheckState.SCHEDULED::equals).orElse(false)); + this.checkSkipped =BooleanExpression.booleanExpression(checkState.map(Check.CheckState.SKIPPED::equals).orElse(false)); + this.checkSucceeded = BooleanExpression.booleanExpression(checkState.map(Check.CheckState.SUCCEEDED::equals).orElse(false)); + this.checkFailed = BooleanExpression.booleanExpression(checkState.map(Check.CheckState.ERROR::equals).orElse(false)); + this.checkCancelled = BooleanExpression.booleanExpression(checkState.map(Check.CheckState.CANCELLED::equals).orElse(false)); + this.checkFinished = checkSucceeded.or(checkFailed).or(checkCancelled); this.countOfWarnSeverity = results.reduce(countSeverity(DiagnosticResult.Severity.WARN)); this.countOfCritSeverity = results.reduce(countSeverity(DiagnosticResult.Severity.CRITICAL)); this.warnOrCritsExist = EasyBind.combine(checkSucceeded, countOfWarnSeverity, countOfCritSeverity, (suceeded, warns, crits) -> suceeded && (warns.longValue() > 0 || crits.longValue() > 0) ); @@ -84,7 +84,7 @@ public class CheckDetailController implements FxController { return checkName.getValue(); } - public Binding checkNameProperty() { + public ObservableValue checkNameProperty() { return checkName; } @@ -108,7 +108,7 @@ public class CheckDetailController implements FxController { return checkRunning.getValue(); } - public Binding checkRunningProperty() { + public BooleanExpression checkRunningProperty() { return checkRunning; } @@ -116,7 +116,7 @@ public class CheckDetailController implements FxController { return checkFinished.getValue(); } - public Binding checkFinishedProperty() { + public BooleanExpression checkFinishedProperty() { return checkFinished; } @@ -124,7 +124,7 @@ public class CheckDetailController implements FxController { return checkScheduled.getValue(); } - public Binding checkScheduledProperty() { + public BooleanExpression checkScheduledProperty() { return checkScheduled; } @@ -132,7 +132,7 @@ public class CheckDetailController implements FxController { return checkSkipped.getValue(); } - public Binding checkSkippedProperty() { + public BooleanExpression checkSkippedProperty() { return checkSkipped; } @@ -140,7 +140,7 @@ public class CheckDetailController implements FxController { return checkSucceeded.getValue(); } - public Binding checkSucceededProperty() { + public BooleanExpression checkSucceededProperty() { return checkSucceeded; } @@ -148,7 +148,7 @@ public class CheckDetailController implements FxController { return checkFailed.getValue(); } - public Binding checkFailedProperty() { + public BooleanExpression checkFailedProperty() { return checkFailed; } @@ -164,7 +164,7 @@ public class CheckDetailController implements FxController { return warnOrCritsExist.getValue(); } - public Binding checkCancelledProperty() { + public BooleanExpression checkCancelledProperty() { return checkCancelled; } diff --git a/src/main/java/org/cryptomator/ui/health/CheckListCellController.java b/src/main/java/org/cryptomator/ui/health/CheckListCellController.java index 5ef2926ef..6357be558 100644 --- a/src/main/java/org/cryptomator/ui/health/CheckListCellController.java +++ b/src/main/java/org/cryptomator/ui/health/CheckListCellController.java @@ -1,21 +1,20 @@ package org.cryptomator.ui.health; -import com.tobiasdiez.easybind.EasyBind; import org.cryptomator.ui.common.FxController; import javax.inject.Inject; -import javafx.beans.binding.Binding; import javafx.beans.binding.Bindings; import javafx.beans.property.ObjectProperty; import javafx.beans.property.SimpleObjectProperty; +import javafx.beans.value.ObservableValue; import javafx.scene.control.CheckBox; public class CheckListCellController implements FxController { private final ObjectProperty check; - private final Binding checkName; - private final Binding checkRunnable; + private final ObservableValue checkRunnable; + private final ObservableValue checkName; /* FXML */ public CheckBox checkbox; @@ -23,8 +22,8 @@ public class CheckListCellController implements FxController { @Inject public CheckListCellController() { check = new SimpleObjectProperty<>(); - checkRunnable = EasyBind.wrapNullable(check).mapObservable(Check::stateProperty).map(Check.CheckState.RUNNABLE::equals).orElse(false); - checkName = EasyBind.wrapNullable(check).map(Check::getName).orElse(""); + checkRunnable = check.flatMap(Check::stateProperty).map(Check.CheckState.RUNNABLE::equals).orElse(false); + checkName = check.map(Check::getName).orElse(""); } public void initialize() { @@ -50,7 +49,7 @@ public class CheckListCellController implements FxController { check.set(c); } - public Binding checkNameProperty() { + public ObservableValue checkNameProperty() { return checkName; } @@ -58,7 +57,7 @@ public class CheckListCellController implements FxController { return checkName.getValue(); } - public Binding checkRunnableProperty() { + public ObservableValue checkRunnableProperty() { return checkRunnable; } diff --git a/src/main/java/org/cryptomator/ui/health/ResultListCellController.java b/src/main/java/org/cryptomator/ui/health/ResultListCellController.java index 59ee2fa67..ad9f575d7 100644 --- a/src/main/java/org/cryptomator/ui/health/ResultListCellController.java +++ b/src/main/java/org/cryptomator/ui/health/ResultListCellController.java @@ -20,6 +20,7 @@ import javafx.beans.binding.ObjectBinding; import javafx.beans.property.ObjectProperty; import javafx.beans.property.SimpleObjectProperty; import javafx.beans.value.ObservableObjectValue; +import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; import javafx.scene.control.Tooltip; import javafx.util.Duration; @@ -38,7 +39,7 @@ public class ResultListCellController implements FxController { private final Logger LOG = LoggerFactory.getLogger(ResultListCellController.class); private final ObjectProperty result; - private final ObservableObjectValue severity; + private final ObservableValue severity; private final Binding description; private final ResultFixApplier fixApplier; private final ObservableObjectValue fixState; @@ -62,7 +63,7 @@ public class ResultListCellController implements FxController { @Inject public ResultListCellController(ResultFixApplier fixApplier, ResourceBundle resourceBundle) { this.result = new SimpleObjectProperty<>(null); - this.severity = EasyBind.wrapNullable(result).map(r -> r.diagnosis().getSeverity()).asOrdinary(); + this.severity = result.map(Result::diagnosis).map(DiagnosticResult::getSeverity); this.description = EasyBind.wrapNullable(result).map(Result::getDescription).orElse(""); this.fixApplier = fixApplier; this.fixState = EasyBind.wrapNullable(result).mapObservable(Result::fixState).asOrdinary(); @@ -83,10 +84,10 @@ public class ResultListCellController implements FxController { @FXML public void initialize() { // see getGlyph() for relevant glyphs: - subscriptions.addAll(List.of(EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-muted", Bindings.equal(severity, DiagnosticResult.Severity.INFO)), // - EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-primary", Bindings.equal(severity, DiagnosticResult.Severity.GOOD)), // - EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-orange", Bindings.equal(severity, DiagnosticResult.Severity.WARN)), // - EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-red", Bindings.equal(severity, DiagnosticResult.Severity.CRITICAL)) // + subscriptions.addAll(List.of(EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-muted", severity.map(DiagnosticResult.Severity.INFO::equals).orElse(false)), // + EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-primary", severity.map(DiagnosticResult.Severity.GOOD::equals).orElse(false)), // + EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-orange", severity.map(DiagnosticResult.Severity.WARN::equals).orElse(false)), // + EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-red", severity.map(DiagnosticResult.Severity.CRITICAL::equals).orElse(false)) // )); var animation = Animations.createDiscrete360Rotation(fixView); this.fixRunningRotator = AutoAnimator.animate(animation) // diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailController.java index b38710023..7e309fdaf 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailController.java @@ -1,6 +1,5 @@ package org.cryptomator.ui.mainwindow; -import com.tobiasdiez.easybind.EasyBind; import org.cryptomator.common.vaults.Vault; import org.cryptomator.common.vaults.VaultState; import org.cryptomator.ui.common.Animations; @@ -11,10 +10,10 @@ import org.cryptomator.ui.controls.FontAwesome5IconView; import javax.inject.Inject; import javafx.application.Application; -import javafx.beans.binding.Binding; import javafx.beans.binding.BooleanBinding; import javafx.beans.property.ObjectProperty; import javafx.beans.property.ReadOnlyObjectProperty; +import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; @MainWindowScoped @@ -22,7 +21,7 @@ public class VaultDetailController implements FxController { private final ReadOnlyObjectProperty vault; private final Application application; - private final Binding glyph; + private final ObservableValue glyph; private final BooleanBinding anyVaultSelected; private AutoAnimator spinAnimation; @@ -35,15 +34,13 @@ public class VaultDetailController implements FxController { VaultDetailController(ObjectProperty vault, Application application) { this.vault = vault; this.application = application; - this.glyph = EasyBind.select(vault) // - .selectObject(Vault::stateProperty) // - .map(this::getGlyphForVaultState); + this.glyph = vault.flatMap(Vault::stateProperty).map(this::getGlyphForVaultState); this.anyVaultSelected = vault.isNotNull(); } public void initialize() { this.spinAnimation = AutoAnimator.animate(Animations.createDiscrete360Rotation(vaultStateView)) // - .onCondition(EasyBind.select(vault).selectObject(Vault::stateProperty).map(VaultState.Value.PROCESSING::equals)) // + .onCondition(vault.flatMap(Vault::stateProperty).map(VaultState.Value.PROCESSING::equals).orElse(false)) // .afterStop(() -> vaultStateView.setRotate(0)) // .build(); } @@ -77,7 +74,7 @@ public class VaultDetailController implements FxController { return vault.get(); } - public Binding glyphProperty() { + public ObservableValue glyphProperty() { return glyph; } diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java index cf1009ea9..1bb863c57 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java @@ -1,6 +1,5 @@ package org.cryptomator.ui.mainwindow; -import com.tobiasdiez.easybind.EasyBind; import org.cryptomator.common.keychain.KeychainManager; import org.cryptomator.common.vaults.Vault; import org.cryptomator.ui.common.FxController; @@ -34,7 +33,8 @@ public class VaultDetailLockedController implements FxController { this.keychain = keychain; this.mainWindow = mainWindow; if (keychain.isSupported() && !keychain.isLocked()) { - this.passwordSaved = BooleanExpression.booleanExpression(EasyBind.select(vault).selectObject(v -> keychain.getPassphraseStoredProperty(v.getId()))); + var stored = vault.flatMap(v -> keychain.getPassphraseStoredProperty(v.getId())).orElse(false); + this.passwordSaved = BooleanExpression.booleanExpression(stored); } else { this.passwordSaved = new SimpleBooleanProperty(false); } diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultListCellController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultListCellController.java index ef1ef1973..6374d7ae3 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultListCellController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultListCellController.java @@ -1,6 +1,5 @@ package org.cryptomator.ui.mainwindow; -import com.tobiasdiez.easybind.EasyBind; import org.cryptomator.common.vaults.Vault; import org.cryptomator.common.vaults.VaultState; import org.cryptomator.ui.common.Animations; @@ -10,15 +9,15 @@ import org.cryptomator.ui.controls.FontAwesome5Icon; import org.cryptomator.ui.controls.FontAwesome5IconView; import javax.inject.Inject; -import javafx.beans.binding.Binding; import javafx.beans.property.ObjectProperty; import javafx.beans.property.SimpleObjectProperty; +import javafx.beans.value.ObservableValue; // unscoped because each cell needs its own controller public class VaultListCellController implements FxController { private final ObjectProperty vault = new SimpleObjectProperty<>(); - private final Binding glyph; + private final ObservableValue glyph; private AutoAnimator spinAnimation; @@ -27,14 +26,12 @@ public class VaultListCellController implements FxController { @Inject VaultListCellController() { - this.glyph = EasyBind.select(vault) // - .selectObject(Vault::stateProperty) // - .map(this::getGlyphForVaultState); + this.glyph = vault.flatMap(Vault::stateProperty).map(this::getGlyphForVaultState); } public void initialize() { this.spinAnimation = AutoAnimator.animate(Animations.createDiscrete360Rotation(vaultStateView)) // - .onCondition(EasyBind.select(vault).selectObject(Vault::stateProperty).map(VaultState.Value.PROCESSING::equals)) // + .onCondition(vault.flatMap(Vault::stateProperty).map(VaultState.Value.PROCESSING::equals).orElse(false)) // .afterStop(() -> vaultStateView.setRotate(0)) // .build(); } @@ -55,7 +52,7 @@ public class VaultListCellController implements FxController { /* Getter/Setter */ - public Binding glyphProperty() { + public ObservableValue glyphProperty() { return glyph; } diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java index 23f8e889d..a6baa0baf 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java @@ -1,8 +1,5 @@ package org.cryptomator.ui.mainwindow; -import com.tobiasdiez.easybind.EasyBind; -import com.tobiasdiez.easybind.optional.ObservableOptionalValue; -import com.tobiasdiez.easybind.optional.OptionalBinding; import org.cryptomator.common.keychain.KeychainManager; import org.cryptomator.common.vaults.Vault; import org.cryptomator.common.vaults.VaultState; @@ -14,33 +11,39 @@ import org.cryptomator.ui.vaultoptions.SelectedVaultOptionsTab; import org.cryptomator.ui.vaultoptions.VaultOptionsComponent; import javax.inject.Inject; -import javafx.beans.binding.Binding; import javafx.beans.property.ObjectProperty; +import javafx.beans.property.ReadOnlyObjectProperty; +import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; import javafx.stage.Stage; import java.util.EnumSet; +import java.util.Objects; -import static org.cryptomator.common.vaults.VaultState.Value.*; +import static org.cryptomator.common.vaults.VaultState.Value.ERROR; +import static org.cryptomator.common.vaults.VaultState.Value.LOCKED; +import static org.cryptomator.common.vaults.VaultState.Value.MISSING; +import static org.cryptomator.common.vaults.VaultState.Value.NEEDS_MIGRATION; +import static org.cryptomator.common.vaults.VaultState.Value.UNLOCKED; @MainWindowScoped public class VaultListContextMenuController implements FxController { - private final ObservableOptionalValue selectedVault; + private final ReadOnlyObjectProperty selectedVault; private final Stage mainWindow; private final FxApplicationWindows appWindows; private final VaultService vaultService; private final KeychainManager keychain; private final RemoveVaultComponent.Builder removeVault; private final VaultOptionsComponent.Factory vaultOptionsWindow; - private final OptionalBinding selectedVaultState; - private final Binding selectedVaultPassphraseStored; - private final Binding selectedVaultRemovable; - private final Binding selectedVaultUnlockable; - private final Binding selectedVaultLockable; + private final ObservableValue selectedVaultState; + private final ObservableValue selectedVaultPassphraseStored; + private final ObservableValue selectedVaultRemovable; + private final ObservableValue selectedVaultUnlockable; + private final ObservableValue selectedVaultLockable; @Inject VaultListContextMenuController(ObjectProperty selectedVault, @MainWindow Stage mainWindow, FxApplicationWindows appWindows, VaultService vaultService, KeychainManager keychain, RemoveVaultComponent.Builder removeVault, VaultOptionsComponent.Factory vaultOptionsWindow) { - this.selectedVault = EasyBind.wrapNullable(selectedVault); + this.selectedVault = selectedVault; this.mainWindow = mainWindow; this.appWindows = appWindows; this.vaultService = vaultService; @@ -48,8 +51,8 @@ public class VaultListContextMenuController implements FxController { this.removeVault = removeVault; this.vaultOptionsWindow = vaultOptionsWindow; - this.selectedVaultState = this.selectedVault.mapObservable(Vault::stateProperty); - this.selectedVaultPassphraseStored = this.selectedVault.map(this::isPasswordStored).orElse(false); + this.selectedVaultState = selectedVault.flatMap(Vault::stateProperty).orElse(null); + this.selectedVaultPassphraseStored = selectedVault.map(this::isPasswordStored).orElse(false); this.selectedVaultRemovable = selectedVaultState.map(EnumSet.of(LOCKED, MISSING, ERROR, NEEDS_MIGRATION)::contains).orElse(false); this.selectedVaultUnlockable = selectedVaultState.map(LOCKED::equals).orElse(false); this.selectedVaultLockable = selectedVaultState.map(UNLOCKED::equals).orElse(false); @@ -61,40 +64,37 @@ public class VaultListContextMenuController implements FxController { @FXML public void didClickRemoveVault() { - selectedVault.ifValuePresent(v -> { - removeVault.vault(v).build().showRemoveVault(); - }); + var vault = Objects.requireNonNull(selectedVault.get()); + removeVault.vault(vault).build().showRemoveVault(); } @FXML public void didClickShowVaultOptions() { - selectedVault.ifValuePresent(v -> { - vaultOptionsWindow.create(v).showVaultOptionsWindow(SelectedVaultOptionsTab.ANY); - }); + var vault = Objects.requireNonNull(selectedVault.get()); + vaultOptionsWindow.create(vault).showVaultOptionsWindow(SelectedVaultOptionsTab.ANY); } @FXML public void didClickUnlockVault() { - selectedVault.ifValuePresent(v -> { - appWindows.startUnlockWorkflow(v, mainWindow); - }); + var vault = Objects.requireNonNull(selectedVault.get()); + appWindows.startUnlockWorkflow(vault, mainWindow); } @FXML public void didClickLockVault() { - selectedVault.ifValuePresent(v -> { - appWindows.startLockWorkflow(v, mainWindow); - }); + var vault = Objects.requireNonNull(selectedVault.get()); + appWindows.startLockWorkflow(vault, mainWindow); } @FXML public void didClickRevealVault() { - selectedVault.ifValuePresent(vaultService::reveal); + var vault = Objects.requireNonNull(selectedVault.get()); + vaultService.reveal(vault); } // Getter and Setter - public Binding selectedVaultUnlockableProperty() { + public ObservableValue selectedVaultUnlockableProperty() { return selectedVaultUnlockable; } @@ -102,7 +102,7 @@ public class VaultListContextMenuController implements FxController { return selectedVaultUnlockable.getValue(); } - public Binding selectedVaultLockableProperty() { + public ObservableValue selectedVaultLockableProperty() { return selectedVaultLockable; } @@ -110,7 +110,7 @@ public class VaultListContextMenuController implements FxController { return selectedVaultLockable.getValue(); } - public Binding selectedVaultRemovableProperty() { + public ObservableValue selectedVaultRemovableProperty() { return selectedVaultRemovable; } @@ -118,7 +118,7 @@ public class VaultListContextMenuController implements FxController { return selectedVaultRemovable.getValue(); } - public Binding selectedVaultPassphraseStoredProperty() { + public ObservableValue selectedVaultPassphraseStoredProperty() { return selectedVaultPassphraseStored; } From 8040b71a5174a4e02e3277da86a871582cfb3bed Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Mon, 10 Oct 2022 12:09:30 +0200 Subject: [PATCH 05/35] simplified some more bindings --- .../org/cryptomator/common/CommonsModule.java | 9 ++++---- .../org/cryptomator/common/LicenseHolder.java | 14 ++++------- .../common/settings/VaultSettings.java | 11 +++++---- .../org/cryptomator/common/vaults/Vault.java | 7 +++--- .../common/vaults/VaultModule.java | 7 +++--- .../CreateNewVaultPasswordController.java | 4 ++-- .../ui/controls/NiceSecurePasswordField.java | 6 +---- .../ui/health/ResultListCellController.java | 23 +++++++++---------- .../PassphraseEntryController.java | 4 ++-- .../ui/mainwindow/ResizeController.java | 5 ++-- .../VaultDetailLockedController.java | 13 ++++------- .../ui/migration/MigrationRunController.java | 7 ++---- .../MasterkeyOptionsController.java | 14 ++++------- .../common/settings/VaultSettingsTest.java | 15 ++++++++---- 14 files changed, 63 insertions(+), 76 deletions(-) diff --git a/src/main/java/org/cryptomator/common/CommonsModule.java b/src/main/java/org/cryptomator/common/CommonsModule.java index 101dc1e28..8d9155d8b 100644 --- a/src/main/java/org/cryptomator/common/CommonsModule.java +++ b/src/main/java/org/cryptomator/common/CommonsModule.java @@ -23,6 +23,7 @@ import javax.inject.Named; import javax.inject.Singleton; import javafx.beans.binding.Binding; import javafx.beans.binding.Bindings; +import javafx.beans.value.ObservableValue; import java.net.InetSocketAddress; import java.security.NoSuchAlgorithmException; import java.security.SecureRandom; @@ -130,16 +131,16 @@ public abstract class CommonsModule { @Provides @Singleton - static Binding provideServerSocketAddressBinding(Settings settings) { - return Bindings.createObjectBinding(() -> { + static ObservableValue provideServerSocketAddressBinding(Settings settings) { + return settings.port().map(port -> { String host = SystemUtils.IS_OS_WINDOWS ? "127.0.0.1" : "localhost"; return InetSocketAddress.createUnresolved(host, settings.port().intValue()); - }, settings.port()); + }); } @Provides @Singleton - static WebDavServer provideWebDavServer(Binding serverSocketAddressBinding) { + static WebDavServer provideWebDavServer(ObservableValue serverSocketAddressBinding) { WebDavServer server = WebDavServer.create(); // no need to unsubscribe eventually, because server is a singleton EasyBind.subscribe(serverSocketAddressBinding, server::bind); diff --git a/src/main/java/org/cryptomator/common/LicenseHolder.java b/src/main/java/org/cryptomator/common/LicenseHolder.java index a31807a8d..be36e6968 100644 --- a/src/main/java/org/cryptomator/common/LicenseHolder.java +++ b/src/main/java/org/cryptomator/common/LicenseHolder.java @@ -10,6 +10,7 @@ import javafx.beans.binding.BooleanBinding; import javafx.beans.binding.StringBinding; import javafx.beans.property.ObjectProperty; import javafx.beans.property.SimpleObjectProperty; +import javafx.beans.value.ObservableValue; import java.util.Optional; @Singleton @@ -18,7 +19,7 @@ public class LicenseHolder { private final Settings settings; private final LicenseChecker licenseChecker; private final ObjectProperty validJwtClaims; - private final StringBinding licenseSubject; + private final ObservableValue licenseSubject; private final BooleanBinding validLicenseProperty; @Inject @@ -26,7 +27,7 @@ public class LicenseHolder { this.settings = settings; this.licenseChecker = licenseChecker; this.validJwtClaims = new SimpleObjectProperty<>(); - this.licenseSubject = Bindings.createStringBinding(this::getLicenseSubject, validJwtClaims); + this.licenseSubject = validJwtClaims.map(DecodedJWT::getSubject); this.validLicenseProperty = validJwtClaims.isNotNull(); Optional claims = licenseChecker.check(settings.licenseKey().get()); @@ -55,17 +56,12 @@ public class LicenseHolder { } } - public StringBinding licenseSubjectProperty() { + public ObservableValue licenseSubjectProperty() { return licenseSubject; } public String getLicenseSubject() { - DecodedJWT claims = validJwtClaims.get(); - if (claims != null) { - return claims.getSubject(); - } else { - return null; - } + return licenseSubject.getValue(); } public BooleanBinding validLicenseProperty() { diff --git a/src/main/java/org/cryptomator/common/settings/VaultSettings.java b/src/main/java/org/cryptomator/common/settings/VaultSettings.java index 8ae20406c..742a4d1b4 100644 --- a/src/main/java/org/cryptomator/common/settings/VaultSettings.java +++ b/src/main/java/org/cryptomator/common/settings/VaultSettings.java @@ -12,6 +12,7 @@ import com.google.common.io.BaseEncoding; import javafx.beans.Observable; import javafx.beans.binding.Bindings; import javafx.beans.binding.StringBinding; +import javafx.beans.binding.StringExpression; import javafx.beans.property.BooleanProperty; import javafx.beans.property.IntegerProperty; import javafx.beans.property.ObjectProperty; @@ -20,6 +21,7 @@ import javafx.beans.property.SimpleIntegerProperty; import javafx.beans.property.SimpleObjectProperty; import javafx.beans.property.SimpleStringProperty; import javafx.beans.property.StringProperty; +import javafx.beans.value.ObservableValue; import java.nio.file.Path; import java.util.Objects; import java.util.Optional; @@ -56,11 +58,11 @@ public class VaultSettings { private final ObjectProperty actionAfterUnlock = new SimpleObjectProperty<>(DEFAULT_ACTION_AFTER_UNLOCK); private final BooleanProperty autoLockWhenIdle = new SimpleBooleanProperty(DEFAULT_AUTOLOCK_WHEN_IDLE); private final IntegerProperty autoLockIdleSeconds = new SimpleIntegerProperty(DEFAULT_AUTOLOCK_IDLE_SECONDS); - private final StringBinding mountName; + private final StringExpression mountName; public VaultSettings(String id) { this.id = Objects.requireNonNull(id); - this.mountName = Bindings.createStringBinding(this::normalizeDisplayName, displayName); + this.mountName = StringExpression.stringExpression(displayName.map(VaultSettings::normalizeDisplayName).orElse("")); } Observable[] observables() { @@ -78,8 +80,7 @@ public class VaultSettings { } //visible for testing - String normalizeDisplayName() { - var original = displayName.getValueSafe(); + static String normalizeDisplayName(String original) { if (original.isBlank() || ".".equals(original) || "..".equals(original)) { return "_"; } @@ -105,7 +106,7 @@ public class VaultSettings { return displayName; } - public StringBinding mountName() { + public StringExpression mountName() { return mountName; } diff --git a/src/main/java/org/cryptomator/common/vaults/Vault.java b/src/main/java/org/cryptomator/common/vaults/Vault.java index 5bba0b79b..54d37d5e3 100644 --- a/src/main/java/org/cryptomator/common/vaults/Vault.java +++ b/src/main/java/org/cryptomator/common/vaults/Vault.java @@ -34,6 +34,7 @@ import javafx.beans.binding.BooleanBinding; import javafx.beans.binding.StringBinding; import javafx.beans.property.BooleanProperty; import javafx.beans.property.ObjectProperty; +import javafx.beans.property.ReadOnlyStringProperty; import javafx.beans.property.SimpleBooleanProperty; import java.io.IOException; import java.nio.file.Path; @@ -60,7 +61,6 @@ public class Vault { private final ObjectProperty lastKnownException; private final VaultConfigCache configCache; private final VaultStats stats; - private final StringBinding displayName; private final StringBinding displayablePath; private final BooleanBinding locked; private final BooleanBinding processing; @@ -84,7 +84,6 @@ public class Vault { this.state = state; this.lastKnownException = lastKnownException; this.stats = stats; - this.displayName = Bindings.createStringBinding(this::getDisplayName, vaultSettings.displayName()); this.displayablePath = Bindings.createStringBinding(this::getDisplayablePath, vaultSettings.path()); this.locked = Bindings.createBooleanBinding(this::isLocked, state); this.processing = Bindings.createBooleanBinding(this::isProcessing, state); @@ -266,8 +265,8 @@ public class Vault { return state.get() == VaultState.Value.ERROR; } - public StringBinding displayNameProperty() { - return displayName; + public ReadOnlyStringProperty displayNameProperty() { + return vaultSettings.displayName(); } public String getDisplayName() { diff --git a/src/main/java/org/cryptomator/common/vaults/VaultModule.java b/src/main/java/org/cryptomator/common/vaults/VaultModule.java index cc38e6933..902b2d872 100644 --- a/src/main/java/org/cryptomator/common/vaults/VaultModule.java +++ b/src/main/java/org/cryptomator/common/vaults/VaultModule.java @@ -19,6 +19,7 @@ import org.slf4j.LoggerFactory; import javax.inject.Named; import javafx.beans.binding.Bindings; import javafx.beans.binding.StringBinding; +import javafx.beans.binding.StringExpression; import javafx.beans.property.BooleanProperty; import javafx.beans.property.ObjectProperty; import javafx.beans.property.ReadOnlyBooleanProperty; @@ -68,7 +69,7 @@ public class VaultModule { @DefaultMountFlags public StringBinding provideDefaultMountFlags(Settings settings, VaultSettings vaultSettings) { ObjectProperty preferredVolumeImpl = settings.preferredVolumeImpl(); - StringBinding mountName = vaultSettings.mountName(); + StringExpression mountName = vaultSettings.mountName(); BooleanProperty readOnly = vaultSettings.usesReadOnlyMode(); return Bindings.createStringBinding(() -> { @@ -88,7 +89,7 @@ public class VaultModule { } // see: https://github.com/osxfuse/osxfuse/wiki/Mount-options - private String getMacFuseDefaultMountFlags(StringBinding mountName, ReadOnlyBooleanProperty readOnly) { + private String getMacFuseDefaultMountFlags(StringExpression mountName, ReadOnlyBooleanProperty readOnly) { assert SystemUtils.IS_OS_MAC_OSX; StringBuilder flags = new StringBuilder(); if (readOnly.get()) { @@ -139,7 +140,7 @@ public class VaultModule { // see https://github.com/billziss-gh/winfsp/blob/5d0b10d0b643652c00ebb4704dc2bb28e7244973/src/dll/fuse/fuse_main.c#L53-L62 for syntax guide // see https://github.com/billziss-gh/winfsp/blob/5d0b10d0b643652c00ebb4704dc2bb28e7244973/src/dll/fuse/fuse.c#L295-L319 for options (-o <...>) // see https://github.com/billziss-gh/winfsp/wiki/Frequently-Asked-Questions/5ba00e4be4f5e938eaae6ef1500b331de12dee77 (FUSE 4.) on why the given defaults were chosen - private String getWindowsFuseDefaultMountFlags(StringBinding mountName, ReadOnlyBooleanProperty readOnly) { + private String getWindowsFuseDefaultMountFlags(StringExpression mountName, ReadOnlyBooleanProperty readOnly) { assert SystemUtils.IS_OS_WINDOWS; StringBuilder flags = new StringBuilder(); diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultPasswordController.java b/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultPasswordController.java index c6bfb3f0e..db35b5a11 100644 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultPasswordController.java +++ b/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultPasswordController.java @@ -102,7 +102,7 @@ public class CreateNewVaultPasswordController implements FxController { this.masterkeyFileAccess = masterkeyFileAccess; this.processing = new SimpleBooleanProperty(); this.readyToCreateVault = new SimpleBooleanProperty(); - this.createVaultButtonState = Bindings.createObjectBinding(this::getCreateVaultButtonState, processing); + this.createVaultButtonState = Bindings.when(processing).then(ContentDisplay.LEFT).otherwise(ContentDisplay.TEXT_ONLY); } @FXML @@ -231,6 +231,6 @@ public class CreateNewVaultPasswordController implements FxController { } public ContentDisplay getCreateVaultButtonState() { - return processing.get() ? ContentDisplay.LEFT : ContentDisplay.TEXT_ONLY; + return createVaultButtonState.get(); } } diff --git a/src/main/java/org/cryptomator/ui/controls/NiceSecurePasswordField.java b/src/main/java/org/cryptomator/ui/controls/NiceSecurePasswordField.java index 4d09707b9..e16c3ff21 100644 --- a/src/main/java/org/cryptomator/ui/controls/NiceSecurePasswordField.java +++ b/src/main/java/org/cryptomator/ui/controls/NiceSecurePasswordField.java @@ -46,7 +46,7 @@ public class NiceSecurePasswordField extends StackPane { nonPrintableCharsIcon.managedProperty().bind(passwordField.containingNonPrintableCharsProperty()); revealPasswordIcon.setGlyph(FontAwesome5Icon.EYE); - revealPasswordIcon.glyphProperty().bind(Bindings.createObjectBinding(this::getRevealPasswordGlyph, revealPasswordButton.selectedProperty())); + revealPasswordIcon.glyphProperty().bind(Bindings.when(revealPasswordButton.selectedProperty()).then(FontAwesome5Icon.EYE_SLASH).otherwise(FontAwesome5Icon.EYE)); revealPasswordIcon.setGlyphSize(ICON_SIZE); revealPasswordButton.setContentDisplay(ContentDisplay.LEFT); @@ -61,10 +61,6 @@ public class NiceSecurePasswordField extends StackPane { disabledProperty().addListener(this::disabledChanged); } - private FontAwesome5Icon getRevealPasswordGlyph() { - return revealPasswordButton.isSelected() ? FontAwesome5Icon.EYE_SLASH : FontAwesome5Icon.EYE; - } - private void disabledChanged(@SuppressWarnings("unused") Observable observable) { revealPasswordButton.setSelected(false); } diff --git a/src/main/java/org/cryptomator/ui/health/ResultListCellController.java b/src/main/java/org/cryptomator/ui/health/ResultListCellController.java index ad9f575d7..d655d0058 100644 --- a/src/main/java/org/cryptomator/ui/health/ResultListCellController.java +++ b/src/main/java/org/cryptomator/ui/health/ResultListCellController.java @@ -13,13 +13,11 @@ import org.slf4j.LoggerFactory; import javax.inject.Inject; import javafx.application.Platform; -import javafx.beans.binding.Binding; import javafx.beans.binding.Bindings; import javafx.beans.binding.BooleanBinding; import javafx.beans.binding.ObjectBinding; import javafx.beans.property.ObjectProperty; import javafx.beans.property.SimpleObjectProperty; -import javafx.beans.value.ObservableObjectValue; import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; import javafx.scene.control.Tooltip; @@ -40,9 +38,9 @@ public class ResultListCellController implements FxController { private final ObjectProperty result; private final ObservableValue severity; - private final Binding description; + private final ObservableValue description; private final ResultFixApplier fixApplier; - private final ObservableObjectValue fixState; + private final ObservableValue fixState; private final ObjectBinding severityGlyph; private final ObjectBinding fixGlyph; private final BooleanBinding fixable; @@ -64,9 +62,9 @@ public class ResultListCellController implements FxController { public ResultListCellController(ResultFixApplier fixApplier, ResourceBundle resourceBundle) { this.result = new SimpleObjectProperty<>(null); this.severity = result.map(Result::diagnosis).map(DiagnosticResult::getSeverity); - this.description = EasyBind.wrapNullable(result).map(Result::getDescription).orElse(""); + this.description = result.map(Result::getDescription).orElse(""); this.fixApplier = fixApplier; - this.fixState = EasyBind.wrapNullable(result).mapObservable(Result::fixState).asOrdinary(); + this.fixState = result.flatMap(Result::fixState); this.severityGlyph = Bindings.createObjectBinding(this::getSeverityGlyph, result); this.fixGlyph = Bindings.createObjectBinding(this::getFixGlyph, fixState); this.fixable = Bindings.createBooleanBinding(this::isFixable, fixState); @@ -89,9 +87,10 @@ public class ResultListCellController implements FxController { EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-orange", severity.map(DiagnosticResult.Severity.WARN::equals).orElse(false)), // EasyBind.includeWhen(severityView.getStyleClass(), "glyph-icon-red", severity.map(DiagnosticResult.Severity.CRITICAL::equals).orElse(false)) // )); + var animation = Animations.createDiscrete360Rotation(fixView); this.fixRunningRotator = AutoAnimator.animate(animation) // - .onCondition(Bindings.equal(fixState, Result.FixState.FIXING)) // + .onCondition(fixing) // .afterStop(() -> fixView.setRotate(0)) // .build(); } @@ -128,7 +127,7 @@ public class ResultListCellController implements FxController { return result; } - public Binding descriptionProperty() { + public ObservableValue descriptionProperty() { return description; } @@ -174,7 +173,7 @@ public class ResultListCellController implements FxController { } public boolean isFixable() { - return Result.FixState.FIXABLE.equals(fixState.get()); + return Result.FixState.FIXABLE.equals(fixState.getValue()); } public BooleanBinding fixingProperty() { @@ -182,7 +181,7 @@ public class ResultListCellController implements FxController { } public boolean isFixing() { - return Result.FixState.FIXING.equals(fixState.get()); + return Result.FixState.FIXING.equals(fixState.getValue()); } public BooleanBinding fixedProperty() { @@ -190,7 +189,7 @@ public class ResultListCellController implements FxController { } public boolean isFixed() { - return Result.FixState.FIXED.equals(fixState.get()); + return Result.FixState.FIXED.equals(fixState.getValue()); } public BooleanBinding fixFailedProperty() { @@ -198,7 +197,7 @@ public class ResultListCellController implements FxController { } public Boolean isFixFailed() { - return Result.FixState.FIX_FAILED.equals(fixState.get()); + return Result.FixState.FIX_FAILED.equals(fixState.getValue()); } public BooleanBinding fixRunningOrDoneProperty() { diff --git a/src/main/java/org/cryptomator/ui/keyloading/masterkeyfile/PassphraseEntryController.java b/src/main/java/org/cryptomator/ui/keyloading/masterkeyfile/PassphraseEntryController.java index 5d2b9b52a..baadb9a12 100644 --- a/src/main/java/org/cryptomator/ui/keyloading/masterkeyfile/PassphraseEntryController.java +++ b/src/main/java/org/cryptomator/ui/keyloading/masterkeyfile/PassphraseEntryController.java @@ -50,7 +50,7 @@ public class PassphraseEntryController implements FxController { private final KeychainManager keychain; private final StringBinding vaultName; private final BooleanProperty unlockInProgress = new SimpleBooleanProperty(); - private final ObjectBinding unlockButtonContentDisplay = Bindings.createObjectBinding(this::getUnlockButtonContentDisplay, unlockInProgress); + private final ObjectBinding unlockButtonContentDisplay = Bindings.when(unlockInProgress).then(ContentDisplay.LEFT).otherwise(ContentDisplay.TEXT_ONLY); private final BooleanProperty unlockButtonDisabled = new SimpleBooleanProperty(); /* FXML */ @@ -186,7 +186,7 @@ public class PassphraseEntryController implements FxController { } public ContentDisplay getUnlockButtonContentDisplay() { - return unlockInProgress.get() ? ContentDisplay.LEFT : ContentDisplay.TEXT_ONLY; + return unlockButtonContentDisplay.get(); } public ReadOnlyBooleanProperty userInteractionDisabledProperty() { diff --git a/src/main/java/org/cryptomator/ui/mainwindow/ResizeController.java b/src/main/java/org/cryptomator/ui/mainwindow/ResizeController.java index 448d54d91..11f035124 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/ResizeController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/ResizeController.java @@ -46,7 +46,7 @@ public class ResizeController implements FxController { ResizeController(@MainWindow Stage window, Settings settings) { this.window = window; this.settings = settings; - this.showResizingArrows = Bindings.createBooleanBinding(this::isShowResizingArrows, window.fullScreenProperty()); + this.showResizingArrows = window.fullScreenProperty().not(); } @FXML @@ -181,8 +181,7 @@ public class ResizeController implements FxController { } public boolean isShowResizingArrows() { - //If in fullscreen resizing is not be possible; - return !window.isFullScreen(); + return showResizingArrows.get(); } } \ No newline at end of file diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java index 1bb863c57..f90ad61c2 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailLockedController.java @@ -8,10 +8,10 @@ import org.cryptomator.ui.vaultoptions.SelectedVaultOptionsTab; import org.cryptomator.ui.vaultoptions.VaultOptionsComponent; import javax.inject.Inject; -import javafx.beans.binding.BooleanExpression; import javafx.beans.property.ObjectProperty; import javafx.beans.property.ReadOnlyObjectProperty; import javafx.beans.property.SimpleBooleanProperty; +import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; import javafx.stage.Stage; @@ -23,7 +23,7 @@ public class VaultDetailLockedController implements FxController { private final VaultOptionsComponent.Factory vaultOptionsWindow; private final KeychainManager keychain; private final Stage mainWindow; - private final BooleanExpression passwordSaved; + private final ObservableValue passwordSaved; @Inject VaultDetailLockedController(ObjectProperty vault, FxApplicationWindows appWindows, VaultOptionsComponent.Factory vaultOptionsWindow, KeychainManager keychain, @MainWindow Stage mainWindow) { @@ -33,8 +33,7 @@ public class VaultDetailLockedController implements FxController { this.keychain = keychain; this.mainWindow = mainWindow; if (keychain.isSupported() && !keychain.isLocked()) { - var stored = vault.flatMap(v -> keychain.getPassphraseStoredProperty(v.getId())).orElse(false); - this.passwordSaved = BooleanExpression.booleanExpression(stored); + this.passwordSaved = vault.flatMap(v -> keychain.getPassphraseStoredProperty(v.getId())).orElse(false); } else { this.passwordSaved = new SimpleBooleanProperty(false); } @@ -65,13 +64,11 @@ public class VaultDetailLockedController implements FxController { return vault.get(); } - public BooleanExpression passwordSavedProperty() { + public ObservableValue passwordSavedProperty() { return passwordSaved; } public boolean isPasswordSaved() { - if (keychain.isSupported() && vault.get() != null) { - return keychain.getPassphraseStoredProperty(vault.get().getId()).get(); - } else return false; + return passwordSaved.getValue(); } } diff --git a/src/main/java/org/cryptomator/ui/migration/MigrationRunController.java b/src/main/java/org/cryptomator/ui/migration/MigrationRunController.java index c68456523..9b2c74c1e 100644 --- a/src/main/java/org/cryptomator/ui/migration/MigrationRunController.java +++ b/src/main/java/org/cryptomator/ui/migration/MigrationRunController.java @@ -83,7 +83,7 @@ public class MigrationRunController implements FxController { this.appWindows = appWindows; this.startScene = startScene; this.successScene = successScene; - this.migrateButtonContentDisplay = Bindings.createObjectBinding(this::getMigrateButtonContentDisplay, vault.stateProperty()); + this.migrateButtonContentDisplay = Bindings.when(vault.processingProperty()).then(ContentDisplay.LEFT).otherwise(ContentDisplay.TEXT_ONLY); this.capabilityErrorScene = capabilityErrorScene; this.migrationButtonDisabled = new SimpleBooleanProperty(); this.migrationProgress = new SimpleDoubleProperty(volatileMigrationProgress); @@ -211,10 +211,7 @@ public class MigrationRunController implements FxController { } public ContentDisplay getMigrateButtonContentDisplay() { - return switch (vault.getState()) { - case PROCESSING -> ContentDisplay.LEFT; - default -> ContentDisplay.TEXT_ONLY; - }; + return migrateButtonContentDisplay.get(); } public ReadOnlyDoubleProperty migrationProgressProperty() { diff --git a/src/main/java/org/cryptomator/ui/vaultoptions/MasterkeyOptionsController.java b/src/main/java/org/cryptomator/ui/vaultoptions/MasterkeyOptionsController.java index a9bc88cf7..4978335c7 100644 --- a/src/main/java/org/cryptomator/ui/vaultoptions/MasterkeyOptionsController.java +++ b/src/main/java/org/cryptomator/ui/vaultoptions/MasterkeyOptionsController.java @@ -2,7 +2,6 @@ package org.cryptomator.ui.vaultoptions; import org.cryptomator.common.keychain.KeychainManager; import org.cryptomator.common.vaults.Vault; -import org.cryptomator.integrations.keychain.KeychainAccessException; import org.cryptomator.ui.changepassword.ChangePasswordComponent; import org.cryptomator.ui.common.FxController; import org.cryptomator.ui.forgetPassword.ForgetPasswordComponent; @@ -11,9 +10,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import javax.inject.Inject; -import javafx.beans.binding.Bindings; -import javafx.beans.binding.BooleanExpression; import javafx.beans.property.SimpleBooleanProperty; +import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; import javafx.stage.Stage; @@ -28,7 +26,7 @@ public class MasterkeyOptionsController implements FxController { private final RecoveryKeyComponent.Builder recoveryKeyWindow; private final ForgetPasswordComponent.Builder forgetPasswordWindow; private final KeychainManager keychain; - private final BooleanExpression passwordSaved; + private final ObservableValue passwordSaved; @Inject @@ -40,7 +38,7 @@ public class MasterkeyOptionsController implements FxController { this.forgetPasswordWindow = forgetPasswordWindow; this.keychain = keychain; if (keychain.isSupported() && !keychain.isLocked()) { - this.passwordSaved = Bindings.createBooleanBinding(this::isPasswordSaved, keychain.getPassphraseStoredProperty(vault.getId())); + this.passwordSaved = keychain.getPassphraseStoredProperty(vault.getId()).orElse(false); } else { this.passwordSaved = new SimpleBooleanProperty(false); } @@ -67,13 +65,11 @@ public class MasterkeyOptionsController implements FxController { forgetPasswordWindow.vault(vault).owner(window).build().showForgetPassword(); } - public BooleanExpression passwordSavedProperty() { + public ObservableValue passwordSavedProperty() { return passwordSaved; } public boolean isPasswordSaved() { - if (keychain.isSupported() && !keychain.isLocked() && vault != null) { - return keychain.getPassphraseStoredProperty(vault.getId()).get(); - } else return false; + return passwordSaved.getValue(); } } diff --git a/src/test/java/org/cryptomator/common/settings/VaultSettingsTest.java b/src/test/java/org/cryptomator/common/settings/VaultSettingsTest.java index 198e2937c..b555542c7 100644 --- a/src/test/java/org/cryptomator/common/settings/VaultSettingsTest.java +++ b/src/test/java/org/cryptomator/common/settings/VaultSettingsTest.java @@ -15,12 +15,17 @@ import static org.junit.jupiter.api.Assertions.assertEquals; public class VaultSettingsTest { - @ParameterizedTest - @CsvSource({"a\u000Fa,a_a", ": \\,_ _", "汉语,汉语", "..,_", "a\ta,a\u0020a", "\t\n\r,_"}) + @ParameterizedTest(name = "VaultSettings.normalizeDisplayName({0}) = {1}") + @CsvSource(value = { + "a\u000Fa,a_a", + ": \\,_ _", + "汉语,汉语", + "..,_", + "a\ta,a\u0020a", + "'\t\n\r',_" + }) public void testNormalize(String test, String expected) { - VaultSettings settings = new VaultSettings("id"); - settings.displayName().setValue(test); - assertEquals(expected, settings.normalizeDisplayName()); + assertEquals(expected, VaultSettings.normalizeDisplayName(test)); } } From 6367cc2dfb5aa0bdf30dd54d2a61d74659333fc0 Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Fri, 14 Oct 2022 13:10:37 +0200 Subject: [PATCH 06/35] depend on coffeelibs-jdk-19 --- .github/workflows/debian.yml | 2 +- dist/linux/debian/control | 2 +- dist/linux/debian/rules | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index 687dd0834..e225e7f38 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -20,7 +20,7 @@ env: jobs: build: name: Build Debian Package - runs-on: ubuntu-18.04 + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v3 with: diff --git a/dist/linux/debian/control b/dist/linux/debian/control index ef06120b3..77aba901c 100644 --- a/dist/linux/debian/control +++ b/dist/linux/debian/control @@ -2,7 +2,7 @@ Source: cryptomator Maintainer: Cryptobot Section: utils Priority: optional -Build-Depends: debhelper (>=10), openjdk-17-jdk +Build-Depends: debhelper (>=10), coffeelibs-jdk-19 Standards-Version: 4.5.0 Homepage: https://cryptomator.org Vcs-Git: https://github.com/cryptomator/cryptomator.git diff --git a/dist/linux/debian/rules b/dist/linux/debian/rules index b77e6f8f2..04c256f60 100755 --- a/dist/linux/debian/rules +++ b/dist/linux/debian/rules @@ -4,6 +4,8 @@ # Uncomment this to turn on verbose mode. #export DH_VERBOSE=1 +JAVA_HOME = /usr/lib/jvm/java-19-coffeelibs + %: dh $@ @@ -16,7 +18,7 @@ override_dh_auto_clean: override_dh_auto_build: mkdir resources ln -s ../common/org.cryptomator.Cryptomator512.png resources/cryptomator.png - jlink \ + $(JAVA_HOME)/bin/jlink \ --output runtime \ --add-modules java.base,java.desktop,java.instrument,java.logging,java.naming,java.net.http,java.scripting,java.sql,java.xml,jdk.unsupported,jdk.crypto.ec,jdk.accessibility,jdk.management.jfr \ --strip-native-commands \ @@ -24,7 +26,7 @@ override_dh_auto_build: --no-man-pages \ --strip-debug \ --compress=2 - jpackage \ + $(JAVA_HOME)/bin/jpackage \ --type app-image \ --runtime-image runtime \ --input libs \ From 01698d139397797a490b661aa09a931414b8be76 Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Fri, 14 Oct 2022 13:21:28 +0200 Subject: [PATCH 07/35] install required build-dependency --- .github/workflows/debian.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index e225e7f38..cf5a108f2 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -27,8 +27,9 @@ jobs: fetch-depth: 0 - name: Install build tools run: | + sudo add-apt-repository ppa:coffeelibs/openjdk sudo apt-get update - sudo apt-get install debhelper devscripts dput + sudo apt-get install debhelper devscripts dput java-19-coffeelibs - name: Setup Java uses: actions/setup-java@v3 with: From 687bed6984a5d179a74c185bb4d034b2f99489ac Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Fri, 14 Oct 2022 13:24:08 +0200 Subject: [PATCH 08/35] use the correct name of required build-dependency --- .github/workflows/debian.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index cf5a108f2..088adf87e 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -29,7 +29,7 @@ jobs: run: | sudo add-apt-repository ppa:coffeelibs/openjdk sudo apt-get update - sudo apt-get install debhelper devscripts dput java-19-coffeelibs + sudo apt-get install debhelper devscripts dput coffeelibs-jdk-19 - name: Setup Java uses: actions/setup-java@v3 with: From 1f019231693931ae23f7f59e0179d9bb8d10b03f Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Fri, 14 Oct 2022 13:44:50 +0200 Subject: [PATCH 09/35] build on Ubuntu Focal --- dist/linux/debian/changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dist/linux/debian/changelog b/dist/linux/debian/changelog index 2c7606733..84a9756f9 100644 --- a/dist/linux/debian/changelog +++ b/dist/linux/debian/changelog @@ -1,4 +1,4 @@ -cryptomator (${PPA_VERSION}) bionic; urgency=low +cryptomator (${PPA_VERSION}) focal; urgency=low * Full changelog can be found on https://github.com/cryptomator/cryptomator/releases From 01a6475d5ff94b35362c12fa464db6726196e830 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Mon, 17 Oct 2022 17:13:12 +0200 Subject: [PATCH 10/35] replace deprecated method call --- .../cryptomator/ui/keyloading/hub/HubKeyLoadingModule.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/cryptomator/ui/keyloading/hub/HubKeyLoadingModule.java b/src/main/java/org/cryptomator/ui/keyloading/hub/HubKeyLoadingModule.java index 6e28b8796..a23a5f1b3 100644 --- a/src/main/java/org/cryptomator/ui/keyloading/hub/HubKeyLoadingModule.java +++ b/src/main/java/org/cryptomator/ui/keyloading/hub/HubKeyLoadingModule.java @@ -56,8 +56,10 @@ public abstract class HubKeyLoadingModule { @Named("deviceId") static String provideDeviceId(DeviceKey deviceKey) { var publicKey = Objects.requireNonNull(deviceKey.get()).getPublic().getEncoded(); - var hashedKey = MessageDigestSupplier.SHA256.get().digest(publicKey); - return BaseEncoding.base16().encode(hashedKey); + try (var instance = MessageDigestSupplier.SHA256.instance()) { + var hashedKey = instance.get().digest(publicKey); + return BaseEncoding.base16().encode(hashedKey); + } } @Provides From d619a0cbf4103d6ea89a0d84bdce889442ab9aab Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Wed, 26 Oct 2022 11:40:09 +0200 Subject: [PATCH 11/35] bump jwt version --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 20a4ffab2..0eb618328 100644 --- a/pom.xml +++ b/pom.xml @@ -28,7 +28,7 @@ 2.1.0-rc1 - 2.4.4 + 2.4.5 1.1.0 1.1.2 1.1.2 @@ -44,7 +44,7 @@ 31.1-jre 2.9.1 18.0.2 - 4.0.0 + 4.2.1 9.25.4 1.4.4 2.0.3 From fbe33e21fba3cebdfbf8552e712d5198109ea5a1 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Thu, 3 Nov 2022 10:14:57 +0100 Subject: [PATCH 12/35] Fixes #2498 Bump winfsp for windows bundle distribution --- dist/win/bundle/resources/winfsp-download.url | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dist/win/bundle/resources/winfsp-download.url b/dist/win/bundle/resources/winfsp-download.url index 35472c1ba..6bb0c7daf 100644 --- a/dist/win/bundle/resources/winfsp-download.url +++ b/dist/win/bundle/resources/winfsp-download.url @@ -1,2 +1,2 @@ [InternetShortcut] -URL=https://github.com/winfsp/winfsp/releases/download/v1.11/winfsp-1.11.22176.msi \ No newline at end of file +URL=https://github.com/winfsp/winfsp/releases/download/v1.12/winfsp-1.12.22301.msi \ No newline at end of file From 6caf132cfb1fdef4759505aba38dd4c50b25fe58 Mon Sep 17 00:00:00 2001 From: Tobias Hagemann Date: Thu, 10 Nov 2022 18:18:34 +0100 Subject: [PATCH 13/35] fixes #2512 --- .../ChooseExistingVaultController.java | 82 +++++++++++++++++-- 1 file changed, 77 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java b/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java index 432007c99..50cbb73e0 100644 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java +++ b/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java @@ -2,10 +2,15 @@ package org.cryptomator.ui.addvaultwizard; import dagger.Lazy; import org.apache.commons.lang3.SystemUtils; +import org.cryptomator.common.LicenseHolder; import org.cryptomator.common.settings.Settings; import org.cryptomator.common.settings.UiTheme; import org.cryptomator.common.vaults.Vault; import org.cryptomator.common.vaults.VaultListManager; +import org.cryptomator.integrations.uiappearance.Theme; +import org.cryptomator.integrations.uiappearance.UiAppearanceException; +import org.cryptomator.integrations.uiappearance.UiAppearanceListener; +import org.cryptomator.integrations.uiappearance.UiAppearanceProvider; import org.cryptomator.ui.common.FxController; import org.cryptomator.ui.common.FxmlFile; import org.cryptomator.ui.common.FxmlScene; @@ -15,6 +20,8 @@ import org.slf4j.LoggerFactory; import javax.inject.Inject; import javafx.beans.property.ObjectProperty; +import javafx.beans.property.SimpleObjectProperty; +import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; import javafx.scene.Scene; import javafx.scene.image.Image; @@ -23,6 +30,7 @@ import javafx.stage.Stage; import java.io.File; import java.io.IOException; import java.nio.file.Path; +import java.util.Optional; import java.util.ResourceBundle; import static org.cryptomator.common.Constants.CRYPTOMATOR_FILENAME_GLOB; @@ -41,11 +49,14 @@ public class ChooseExistingVaultController implements FxController { private final VaultListManager vaultListManager; private final ResourceBundle resourceBundle; private final Settings settings; + private final Optional appearanceProvider; + private final LicenseHolder licenseHolder; + private final UiAppearanceListener systemInterfaceThemeListener = this::systemInterfaceThemeChanged; - private Image screenshot; + private final ObjectProperty screenshot = new SimpleObjectProperty<>(); @Inject - ChooseExistingVaultController(@AddVaultWizardWindow Stage window, @FxmlScene(FxmlFile.ADDVAULT_WELCOME) Lazy welcomeScene, @FxmlScene(FxmlFile.ADDVAULT_SUCCESS) Lazy successScene, FxApplicationWindows appWindows, ObjectProperty vaultPath, @AddVaultWizardWindow ObjectProperty vault, VaultListManager vaultListManager, ResourceBundle resourceBundle, Settings settings) { + ChooseExistingVaultController(@AddVaultWizardWindow Stage window, @FxmlScene(FxmlFile.ADDVAULT_WELCOME) Lazy welcomeScene, @FxmlScene(FxmlFile.ADDVAULT_SUCCESS) Lazy successScene, FxApplicationWindows appWindows, ObjectProperty vaultPath, @AddVaultWizardWindow ObjectProperty vault, VaultListManager vaultListManager, ResourceBundle resourceBundle, Settings settings, Optional appearanceProvider, LicenseHolder licenseHolder) { this.window = window; this.welcomeScene = welcomeScene; this.successScene = successScene; @@ -55,17 +66,73 @@ public class ChooseExistingVaultController implements FxController { this.vaultListManager = vaultListManager; this.resourceBundle = resourceBundle; this.settings = settings; + this.appearanceProvider = appearanceProvider; + this.licenseHolder = licenseHolder; } @FXML public void initialize() { if (SystemUtils.IS_OS_MAC) { - this.screenshot = new Image(getClass().getResource("/img/select-masterkey-mac"+(UiTheme.LIGHT == settings.theme().get()? "":"-dark")+".png").toString()); + settings.theme().addListener(this::appThemeChanged); + setSelectedMacScreenshot(settings.theme().get()); } else { - this.screenshot = new Image(getClass().getResource("/img/select-masterkey-win.png").toString()); + this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-win.png").toString())); } } + private void appThemeChanged(@SuppressWarnings("unused") ObservableValue observable, @SuppressWarnings("unused") UiTheme oldValue, UiTheme newValue) { + if (appearanceProvider.isPresent() && oldValue == UiTheme.AUTOMATIC && newValue != UiTheme.AUTOMATIC) { + try { + appearanceProvider.get().removeListener(systemInterfaceThemeListener); + } catch (UiAppearanceException e) { + LOG.error("Failed to disable automatic theme switching."); + } + } + setSelectedMacScreenshot(newValue); + } + + private void setSelectedMacScreenshot(UiTheme desiredTheme) { + UiTheme theme = licenseHolder.isValidLicense() ? desiredTheme : UiTheme.LIGHT; + switch (theme) { + case LIGHT -> setLightMacScreenshot(); + case DARK -> setDarkMacScreenshot(); + case AUTOMATIC -> { + appearanceProvider.ifPresent(provider -> { + try { + provider.addListener(systemInterfaceThemeListener); + } catch (UiAppearanceException e) { + LOG.error("Failed to enable automatic theme switching."); + } + }); + setSystemMacScreenshot(); + } + } + } + + private void systemInterfaceThemeChanged(Theme theme) { + switch (theme) { + case LIGHT -> setLightMacScreenshot(); + case DARK -> setDarkMacScreenshot(); + } + } + + private void setSystemMacScreenshot() { + if (appearanceProvider.isPresent()) { + systemInterfaceThemeChanged(appearanceProvider.get().getSystemTheme()); + } else { + LOG.warn("No UiAppearanceProvider present, assuming LIGHT theme..."); + setLightMacScreenshot(); + } + } + + private void setLightMacScreenshot() { + this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-mac.png").toString())); + } + + private void setDarkMacScreenshot() { + this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-mac-dark.png").toString())); + } + @FXML public void back() { window.setScene(welcomeScene.get()); @@ -92,8 +159,13 @@ public class ChooseExistingVaultController implements FxController { /* Getter */ - public Image getScreenshot() { + public ObjectProperty screenshotProperty() { return screenshot; } + public Image getScreenshot() { + return screenshot.get(); + } + + } From dda7255d8e2f303c05660fd844aab488dff8e994 Mon Sep 17 00:00:00 2001 From: Tobias Hagemann Date: Thu, 10 Nov 2022 18:36:14 +0100 Subject: [PATCH 14/35] deduplicated code --- .../ChooseExistingVaultController.java | 75 +++---------------- .../ui/fxapp/FxApplicationStyle.java | 11 ++- 2 files changed, 21 insertions(+), 65 deletions(-) diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java b/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java index 50cbb73e0..0a0dc3d2e 100644 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java +++ b/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java @@ -2,18 +2,13 @@ package org.cryptomator.ui.addvaultwizard; import dagger.Lazy; import org.apache.commons.lang3.SystemUtils; -import org.cryptomator.common.LicenseHolder; -import org.cryptomator.common.settings.Settings; -import org.cryptomator.common.settings.UiTheme; import org.cryptomator.common.vaults.Vault; import org.cryptomator.common.vaults.VaultListManager; import org.cryptomator.integrations.uiappearance.Theme; -import org.cryptomator.integrations.uiappearance.UiAppearanceException; -import org.cryptomator.integrations.uiappearance.UiAppearanceListener; -import org.cryptomator.integrations.uiappearance.UiAppearanceProvider; import org.cryptomator.ui.common.FxController; import org.cryptomator.ui.common.FxmlFile; import org.cryptomator.ui.common.FxmlScene; +import org.cryptomator.ui.fxapp.FxApplicationStyle; import org.cryptomator.ui.fxapp.FxApplicationWindows; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -30,7 +25,6 @@ import javafx.stage.Stage; import java.io.File; import java.io.IOException; import java.nio.file.Path; -import java.util.Optional; import java.util.ResourceBundle; import static org.cryptomator.common.Constants.CRYPTOMATOR_FILENAME_GLOB; @@ -48,15 +42,12 @@ public class ChooseExistingVaultController implements FxController { private final ObjectProperty vault; private final VaultListManager vaultListManager; private final ResourceBundle resourceBundle; - private final Settings settings; - private final Optional appearanceProvider; - private final LicenseHolder licenseHolder; - private final UiAppearanceListener systemInterfaceThemeListener = this::systemInterfaceThemeChanged; + private final FxApplicationStyle applicationStyle; private final ObjectProperty screenshot = new SimpleObjectProperty<>(); @Inject - ChooseExistingVaultController(@AddVaultWizardWindow Stage window, @FxmlScene(FxmlFile.ADDVAULT_WELCOME) Lazy welcomeScene, @FxmlScene(FxmlFile.ADDVAULT_SUCCESS) Lazy successScene, FxApplicationWindows appWindows, ObjectProperty vaultPath, @AddVaultWizardWindow ObjectProperty vault, VaultListManager vaultListManager, ResourceBundle resourceBundle, Settings settings, Optional appearanceProvider, LicenseHolder licenseHolder) { + ChooseExistingVaultController(@AddVaultWizardWindow Stage window, @FxmlScene(FxmlFile.ADDVAULT_WELCOME) Lazy welcomeScene, @FxmlScene(FxmlFile.ADDVAULT_SUCCESS) Lazy successScene, FxApplicationWindows appWindows, ObjectProperty vaultPath, @AddVaultWizardWindow ObjectProperty vault, VaultListManager vaultListManager, ResourceBundle resourceBundle, FxApplicationStyle applicationStyle) { this.window = window; this.welcomeScene = welcomeScene; this.successScene = successScene; @@ -65,74 +56,30 @@ public class ChooseExistingVaultController implements FxController { this.vault = vault; this.vaultListManager = vaultListManager; this.resourceBundle = resourceBundle; - this.settings = settings; - this.appearanceProvider = appearanceProvider; - this.licenseHolder = licenseHolder; + this.applicationStyle = applicationStyle; } @FXML public void initialize() { if (SystemUtils.IS_OS_MAC) { - settings.theme().addListener(this::appThemeChanged); - setSelectedMacScreenshot(settings.theme().get()); + applicationStyle.appliedThemeProperty().addListener(this::appliedThemeChanged); + setMacScreenshot(applicationStyle.appliedThemeProperty().get()); } else { this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-win.png").toString())); } } - private void appThemeChanged(@SuppressWarnings("unused") ObservableValue observable, @SuppressWarnings("unused") UiTheme oldValue, UiTheme newValue) { - if (appearanceProvider.isPresent() && oldValue == UiTheme.AUTOMATIC && newValue != UiTheme.AUTOMATIC) { - try { - appearanceProvider.get().removeListener(systemInterfaceThemeListener); - } catch (UiAppearanceException e) { - LOG.error("Failed to disable automatic theme switching."); - } - } - setSelectedMacScreenshot(newValue); + private void appliedThemeChanged(@SuppressWarnings("unused") ObservableValue observable, @SuppressWarnings("unused") Theme oldValue, Theme newValue) { + setMacScreenshot(newValue); } - private void setSelectedMacScreenshot(UiTheme desiredTheme) { - UiTheme theme = licenseHolder.isValidLicense() ? desiredTheme : UiTheme.LIGHT; + private void setMacScreenshot(Theme theme) { switch (theme) { - case LIGHT -> setLightMacScreenshot(); - case DARK -> setDarkMacScreenshot(); - case AUTOMATIC -> { - appearanceProvider.ifPresent(provider -> { - try { - provider.addListener(systemInterfaceThemeListener); - } catch (UiAppearanceException e) { - LOG.error("Failed to enable automatic theme switching."); - } - }); - setSystemMacScreenshot(); - } + case LIGHT -> this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-mac.png").toString())); + case DARK -> this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-mac-dark.png").toString())); } } - private void systemInterfaceThemeChanged(Theme theme) { - switch (theme) { - case LIGHT -> setLightMacScreenshot(); - case DARK -> setDarkMacScreenshot(); - } - } - - private void setSystemMacScreenshot() { - if (appearanceProvider.isPresent()) { - systemInterfaceThemeChanged(appearanceProvider.get().getSystemTheme()); - } else { - LOG.warn("No UiAppearanceProvider present, assuming LIGHT theme..."); - setLightMacScreenshot(); - } - } - - private void setLightMacScreenshot() { - this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-mac.png").toString())); - } - - private void setDarkMacScreenshot() { - this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-mac-dark.png").toString())); - } - @FXML public void back() { window.setScene(welcomeScene.get()); diff --git a/src/main/java/org/cryptomator/ui/fxapp/FxApplicationStyle.java b/src/main/java/org/cryptomator/ui/fxapp/FxApplicationStyle.java index 711da7948..b6681f728 100644 --- a/src/main/java/org/cryptomator/ui/fxapp/FxApplicationStyle.java +++ b/src/main/java/org/cryptomator/ui/fxapp/FxApplicationStyle.java @@ -12,6 +12,8 @@ import org.slf4j.LoggerFactory; import javax.inject.Inject; import javafx.application.Application; +import javafx.beans.property.ObjectProperty; +import javafx.beans.property.SimpleObjectProperty; import javafx.beans.value.ObservableValue; import java.util.Optional; @@ -24,9 +26,10 @@ public class FxApplicationStyle { private final Optional appearanceProvider; private final LicenseHolder licenseHolder; private final UiAppearanceListener systemInterfaceThemeListener = this::systemInterfaceThemeChanged; + private final ObjectProperty appliedTheme = new SimpleObjectProperty<>(Theme.LIGHT); @Inject - public FxApplicationStyle(Settings settings, Optional appearanceProvider, LicenseHolder licenseHolder){ + public FxApplicationStyle(Settings settings, Optional appearanceProvider, LicenseHolder licenseHolder) { this.settings = settings; this.appearanceProvider = appearanceProvider; this.licenseHolder = licenseHolder; @@ -91,6 +94,7 @@ public class FxApplicationStyle { } else { Application.setUserAgentStylesheet(stylesheet.toString()); appearanceProvider.ifPresent(provider -> provider.adjustToTheme(Theme.LIGHT)); + appliedTheme.set(Theme.LIGHT); } } @@ -103,6 +107,11 @@ public class FxApplicationStyle { } else { Application.setUserAgentStylesheet(stylesheet.toString()); appearanceProvider.ifPresent(provider -> provider.adjustToTheme(Theme.DARK)); + appliedTheme.set(Theme.DARK); } } + + public ObjectProperty appliedThemeProperty() { + return appliedTheme; + } } From 37f89fd2352485905d076e523ed3db94f344be6a Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 18 Nov 2022 10:46:22 +0100 Subject: [PATCH 15/35] Move release precondition checks to own workflow (#2535) --- .github/workflows/build.yml | 35 ----------------------- .github/workflows/release-check.yml | 43 +++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 35 deletions(-) create mode 100644 .github/workflows/release-check.yml diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 94c9ab037..d94048ee9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -13,44 +13,9 @@ defaults: shell: bash jobs: - release-check-precondition: - name: Validate pushed commit to release/hotfix branch or pushed tag - runs-on: ubuntu-latest - if: "(startsWith(github.ref, 'refs/tags/') || startsWith(github.ref, 'refs/heads/hotfix/') || startsWith(github.ref, 'refs/heads/release/')) - && !(contains(github.event.head_commit.message, '[ci skip]') || contains(github.event.head_commit.message, '[skip ci]'))" - steps: - - uses: actions/checkout@v2 - - id: validate-pom-version - name: Validate POM version - run: | - if [[ $GITHUB_REF =~ refs/heads/(hotfix|release)/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR=${GITHUB_REF##*/} - elif [[ $GITHUB_REF =~ refs/tags/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR=${GITHUB_REF##*/} - else - echo "Failed to parse version" - exit 1 - fi - - if [[ ${SEM_VER_STR} == `mvn help:evaluate -Dexpression=project.version -q -DforceStdout` ]]; then - echo "::set-output name=semVerStr::${SEM_VER_STR}" - else - echo "Version not set in POM" - exit 1 - fi - - name: Validate release in org.cryptomator.Cryptomator.metainfo.xml file - run: | - if ! grep -q "" dist/linux/common/org.cryptomator.Cryptomator.metainfo.xml; then - echo "Release not set in dist/linux/common/org.cryptomator.Cryptomator.metainfo.xml" - exit 1 - fi test: name: Compile and Test - needs: release-check-precondition runs-on: ubuntu-latest - if: "always() - && (needs.release-check-precondition.result=='success' || needs.release-check-precondition.result=='skipped') - && !(contains(github.event.head_commit.message, '[ci skip]') || contains(github.event.head_commit.message, '[skip ci]'))" steps: - uses: actions/checkout@v3 - uses: actions/setup-java@v3 diff --git a/.github/workflows/release-check.yml b/.github/workflows/release-check.yml new file mode 100644 index 000000000..e2f116130 --- /dev/null +++ b/.github/workflows/release-check.yml @@ -0,0 +1,43 @@ +name: Release Check + +on: + push: + branches: + - 'release/**' + - 'hotfix/**' + +env: + JAVA_VERSION: 19 + +defaults: + run: + shell: bash + +jobs: + release-check-precondition: + name: Validate commits pushed to release/hotfix branch to fulfill release requirements + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - id: validate-pom-version + name: Validate POM version + run: | + if [[ $GITHUB_REF =~ refs/heads/(hotfix|release)/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then + SEM_VER_STR=${GITHUB_REF##*/} + else + echo "Failed to parse version" + exit 1 + fi + + if [[ ${SEM_VER_STR} == `mvn help:evaluate -Dexpression=project.version -q -DforceStdout` ]]; then + echo "::set-output name=semVerStr::${SEM_VER_STR}" + else + echo "Version not set in POM" + exit 1 + fi + - name: Validate release in org.cryptomator.Cryptomator.metainfo.xml file + run: | + if ! grep -q "" dist/linux/common/org.cryptomator.Cryptomator.metainfo.xml; then + echo "Release not set in dist/linux/common/org.cryptomator.Cryptomator.metainfo.xml" + exit 1 + fi \ No newline at end of file From 14d0d95f23a80d37ec2b0318fa5ac742d5dcb23c Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 18 Nov 2022 11:20:51 +0100 Subject: [PATCH 16/35] add variable to skip legacy check in installer --- dist/win/resources/main.wxs | 20 ++++++++++---------- dist/win/resources/overrides.wxi | 4 ++++ 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/dist/win/resources/main.wxs b/dist/win/resources/main.wxs index b8703a14d..659a89979 100644 --- a/dist/win/resources/main.wxs +++ b/dist/win/resources/main.wxs @@ -65,16 +65,16 @@ - - - - - - - - - - + + + + + + + + + + diff --git a/dist/win/resources/overrides.wxi b/dist/win/resources/overrides.wxi index 60133a35b..3d63573cc 100644 --- a/dist/win/resources/overrides.wxi +++ b/dist/win/resources/overrides.wxi @@ -36,4 +36,8 @@ Default value is `yes`. + + From 38062f9a8d58b3db9257cafed9bbec7256ab2562 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 18 Nov 2022 11:32:39 +0100 Subject: [PATCH 17/35] Move Cryptomator installer defaults to actual installer file --- dist/win/resources/main.wxs | 7 ++++++- dist/win/resources/overrides.wxi | 21 ++++++++++++++------- 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/dist/win/resources/main.wxs b/dist/win/resources/main.wxs index 659a89979..d6247bf05 100644 --- a/dist/win/resources/main.wxs +++ b/dist/win/resources/main.wxs @@ -23,6 +23,11 @@ + + + + + - + diff --git a/dist/win/resources/overrides.wxi b/dist/win/resources/overrides.wxi index 3d63573cc..c4c946868 100644 --- a/dist/win/resources/overrides.wxi +++ b/dist/win/resources/overrides.wxi @@ -1,7 +1,7 @@ - - - - + - +Non-opening ProgID settings: +- IconFileEncryptedData +Full file name of icon file used for encrypted data files. Default is "Cryptomator-Vault.ico" - From 043184cf530088425b9c5032da61966c0598ad7d Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 18 Nov 2022 12:36:10 +0100 Subject: [PATCH 18/35] set loopback device alias during build instead of hardcode --- .github/workflows/win-exe.yml | 12 ++++++++++++ dist/win/build.ps1 | 9 +++++++++ dist/win/contrib/patchWebDAV.bat | 2 +- 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 46e1dbed1..dd2bdb8a2 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -22,6 +22,8 @@ jobs: build-msi: name: Build .msi Installer runs-on: windows-latest + env: + LOOPBACK_ALIAS: 'cryptomator-vault' steps: - uses: actions/checkout@v3 with: @@ -105,6 +107,16 @@ jobs: - name: Patch Application Directory run: | cp dist/win/contrib/* appdir/Cryptomator + - name: Set LOOPBACK_ALIAS in patchWebDAV.bat + shell: pwsh + run: | + $patchScript = "appdir\Cryptomator\patchWebDAV.bat" + try { + (Get-Content $patchScript ) -replace '::REPLACE ME', "SET LOOPBACK_ALIAS=`"${{ evn.LOOPBACK_ALIAS}}`"" | Set-Content $patchScript + } catch { + Write-Host "Failed to set LOOPBACK_ALIAS for patchWebDAV.bat" + exit 1 + } - name: Fix permissions run: attrib -r appdir/Cryptomator/Cryptomator.exe shell: pwsh diff --git a/dist/win/build.ps1 b/dist/win/build.ps1 index 50cdbd011..940384f64 100644 --- a/dist/win/build.ps1 +++ b/dist/win/build.ps1 @@ -105,6 +105,15 @@ if ($clean -and (Test-Path -Path $appPath)) { # patch app dir Copy-Item "contrib\*" -Destination "$AppName" attrib -r "$AppName\$AppName.exe" +# patch batch script to set hostfile +$webDAVPatcher = "$AppName\patchWebDAV.bat" +$alias = 'cryptomator-vault' +try { + (Get-Content $webDAVPatcher ) -replace '::REPLACE ME', "SET LOOPBACK_ALIAS=`"$alias`"" | Set-Content $webDAVPatcher +} catch { + Write-Host "Failed to set LOOPBACK_ALIAS for patchWebDAV.bat" + exit 1 +} # create .msi $Env:JP_WIXWIZARD_RESOURCES = "$buildDir\resources" diff --git a/dist/win/contrib/patchWebDAV.bat b/dist/win/contrib/patchWebDAV.bat index 1726147d2..aad226881 100644 --- a/dist/win/contrib/patchWebDAV.bat +++ b/dist/win/contrib/patchWebDAV.bat @@ -1,6 +1,6 @@ @echo off :: Default values for Cryptomator builds -SET LOOPBACK_ALIAS="cryptomator-vault" +::REPLACE ME cd %~dp0 powershell -NoLogo -NonInteractive -ExecutionPolicy Unrestricted -Command .\patchWebDAV.ps1^ From 5729e2885d73819942d7a97aeca789ea3b0205a2 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 18 Nov 2022 12:41:29 +0100 Subject: [PATCH 19/35] fix typo [ci skip] --- .github/workflows/win-exe.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index dd2bdb8a2..f1a2b3515 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -112,7 +112,7 @@ jobs: run: | $patchScript = "appdir\Cryptomator\patchWebDAV.bat" try { - (Get-Content $patchScript ) -replace '::REPLACE ME', "SET LOOPBACK_ALIAS=`"${{ evn.LOOPBACK_ALIAS}}`"" | Set-Content $patchScript + (Get-Content $patchScript ) -replace '::REPLACE ME', "SET LOOPBACK_ALIAS=`"${{ env.LOOPBACK_ALIAS}}`"" | Set-Content $patchScript } catch { Write-Host "Failed to set LOOPBACK_ALIAS for patchWebDAV.bat" exit 1 From 13debaafbe52e93cc996555f322344d6af55c0ad Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 18 Nov 2022 13:34:38 +0100 Subject: [PATCH 20/35] set loopback alias in Cryptomator app during build time --- .github/workflows/win-exe.yml | 1 + dist/win/build.ps1 | 5 ++-- .../org/cryptomator/common/Environment.java | 17 ++++++------- .../common/vaults/WebDavVolume.java | 24 ++++++++++--------- 4 files changed, 24 insertions(+), 23 deletions(-) diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index f1a2b3515..244cbfc36 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -98,6 +98,7 @@ jobs: --java-options "-Dcryptomator.p12Path=\"~/AppData/Roaming/Cryptomator/key.p12\"" --java-options "-Dcryptomator.ipcSocketPath=\"~/AppData/Roaming/Cryptomator/ipc.socket\"" --java-options "-Dcryptomator.mountPointsDir=\"~/Cryptomator\"" + --java-options "-Dcryptomator.loopbackAlias=\"${{ env.LOOPBACK_ALIAS }}\"" --java-options "-Dcryptomator.showTrayIcon=true" --java-options "-Dcryptomator.buildNumber=\"msi-${{ steps.versions.outputs.revNum }}\"" --java-options "-Dcryptomator.integrationsWin.autoStartShellLinkName=\"Cryptomator\"" diff --git a/dist/win/build.ps1 b/dist/win/build.ps1 index 940384f64..565194e7d 100644 --- a/dist/win/build.ps1 +++ b/dist/win/build.ps1 @@ -35,6 +35,7 @@ Write-Output "`$buildDir=$buildDir" Write-Output "`$Env:JAVA_HOME=$Env:JAVA_HOME" $copyright = "(C) $CopyrightStartYear - $((Get-Date).Year) $Vendor" +$loopbackAlias = 'cryptomator-vault' # compile &mvn -B -f $buildDir/../../pom.xml clean package -DskipTests -Pwin @@ -85,6 +86,7 @@ if ($clean -and (Test-Path -Path $appPath)) { --java-options "-Dcryptomator.ipcSocketPath=`"~/AppData/Roaming/$AppName/ipc.socket`"" ` --java-options "-Dcryptomator.p12Path=`"~/AppData/Roaming/$AppName/key.p12`"" ` --java-options "-Dcryptomator.mountPointsDir=`"~/$AppName`"" ` + --java-options "-Dcryptomator.loopbackAlias=`"$loopbackAlias`"" ` --java-options "-Dcryptomator.integrationsWin.autoStartShellLinkName=`"$AppName`"" ` --java-options "-Dcryptomator.integrationsWin.keychainPaths=`"~/AppData/Roaming/$AppName/keychain.json`"" ` --java-options "-Dcryptomator.showTrayIcon=true" ` @@ -107,9 +109,8 @@ Copy-Item "contrib\*" -Destination "$AppName" attrib -r "$AppName\$AppName.exe" # patch batch script to set hostfile $webDAVPatcher = "$AppName\patchWebDAV.bat" -$alias = 'cryptomator-vault' try { - (Get-Content $webDAVPatcher ) -replace '::REPLACE ME', "SET LOOPBACK_ALIAS=`"$alias`"" | Set-Content $webDAVPatcher + (Get-Content $webDAVPatcher ) -replace '::REPLACE ME', "SET LOOPBACK_ALIAS=`"$loopbackAlias`"" | Set-Content $webDAVPatcher } catch { Write-Host "Failed to set LOOPBACK_ALIAS for patchWebDAV.bat" exit 1 diff --git a/src/main/java/org/cryptomator/common/Environment.java b/src/main/java/org/cryptomator/common/Environment.java index 261750ad1..383261119 100644 --- a/src/main/java/org/cryptomator/common/Environment.java +++ b/src/main/java/org/cryptomator/common/Environment.java @@ -26,6 +26,7 @@ public class Environment { private static final String KEYCHAIN_PATHS_PROP_NAME = "cryptomator.integrationsWin.keychainPaths"; private static final String P12_PATH_PROP_NAME = "cryptomator.p12Path"; private static final String LOG_DIR_PROP_NAME = "cryptomator.logDir"; + private static final String LOOPBACK_ALIAS_PROP_NAME = "cryptomator.loopbackAlias"; private static final String MOUNTPOINT_DIR_PROP_NAME = "cryptomator.mountPointsDir"; private static final String MIN_PW_LENGTH_PROP_NAME = "cryptomator.minPwLength"; private static final String APP_VERSION_PROP_NAME = "cryptomator.appVersion"; @@ -45,6 +46,7 @@ public class Environment { logCryptomatorSystemProperty(IPC_SOCKET_PATH_PROP_NAME); logCryptomatorSystemProperty(KEYCHAIN_PATHS_PROP_NAME); logCryptomatorSystemProperty(LOG_DIR_PROP_NAME); + logCryptomatorSystemProperty(LOOPBACK_ALIAS_PROP_NAME); logCryptomatorSystemProperty(PLUGIN_DIR_PROP_NAME); logCryptomatorSystemProperty(MOUNTPOINT_DIR_PROP_NAME); logCryptomatorSystemProperty(MIN_PW_LENGTH_PROP_NAME); @@ -90,6 +92,10 @@ public class Environment { return getPath(LOG_DIR_PROP_NAME).map(this::replaceHomeDir); } + public Optional getLoopbackAlias() { + return Optional.ofNullable(System.getProperty(LOOPBACK_ALIAS_PROP_NAME)); + } + public Optional getPluginDir() { return getPath(PLUGIN_DIR_PROP_NAME).map(this::replaceHomeDir); } @@ -112,22 +118,13 @@ public class Environment { } public int getMinPwLength() { - return getInt(MIN_PW_LENGTH_PROP_NAME, DEFAULT_MIN_PW_LENGTH); + return Integer.getInteger(MIN_PW_LENGTH_PROP_NAME, DEFAULT_MIN_PW_LENGTH); } public boolean showTrayIcon() { return Boolean.getBoolean(TRAY_ICON_PROP_NAME); } - private int getInt(String propertyName, int defaultValue) { - String value = System.getProperty(propertyName); - try { - return Integer.parseInt(value); - } catch (NumberFormatException e) { // includes "null" values - return defaultValue; - } - } - private Optional getPath(String propertyName) { String value = System.getProperty(propertyName); return Optional.ofNullable(value).map(Paths::get); diff --git a/src/main/java/org/cryptomator/common/vaults/WebDavVolume.java b/src/main/java/org/cryptomator/common/vaults/WebDavVolume.java index 3ac1820d4..af7ca10f2 100644 --- a/src/main/java/org/cryptomator/common/vaults/WebDavVolume.java +++ b/src/main/java/org/cryptomator/common/vaults/WebDavVolume.java @@ -2,6 +2,7 @@ package org.cryptomator.common.vaults; import com.google.common.base.CharMatcher; +import org.cryptomator.common.Environment; import org.cryptomator.common.settings.Settings; import org.cryptomator.common.settings.VaultSettings; import org.cryptomator.common.settings.VolumeImpl; @@ -22,12 +23,11 @@ import java.util.function.Supplier; public class WebDavVolume implements Volume { - private static final String LOCALHOST_ALIAS = "cryptomator-vault"; - private final Provider serverProvider; private final VaultSettings vaultSettings; private final Settings settings; private final WindowsDriveLetters windowsDriveLetters; + private final Environment environment; private WebDavServer server; private WebDavServletController servlet; @@ -35,11 +35,12 @@ public class WebDavVolume implements Volume { private Consumer onExitAction; @Inject - public WebDavVolume(Provider serverProvider, VaultSettings vaultSettings, Settings settings, WindowsDriveLetters windowsDriveLetters) { + public WebDavVolume(Provider serverProvider, VaultSettings vaultSettings, Settings settings, WindowsDriveLetters windowsDriveLetters, Environment environment) { this.serverProvider = serverProvider; this.vaultSettings = vaultSettings; this.settings = settings; this.windowsDriveLetters = windowsDriveLetters; + this.environment = environment; } @Override @@ -129,16 +130,17 @@ public class WebDavVolume implements Volume { } private String getLocalhostAliasOrNull() { - try { - InetAddress alias = InetAddress.getByName(LOCALHOST_ALIAS); - if (alias.getHostAddress().equals("127.0.0.1")) { - return LOCALHOST_ALIAS; - } else { - return null; + return environment.getLoopbackAlias().map(alias -> { + try { + var address = InetAddress.getByName(alias); + if (address.getHostAddress().equals("127.0.0.1")) { + return alias; + } + } catch (UnknownHostException e) { + //no-op } - } catch (UnknownHostException e) { return null; - } + }).orElse(null); } private void cleanup() { From 65e26971ff3f2c2cec323daaa16e5c5bf6d57a85 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Mon, 21 Nov 2022 13:12:32 +0100 Subject: [PATCH 21/35] make loopback alias depend on appName --- dist/win/build.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dist/win/build.ps1 b/dist/win/build.ps1 index 565194e7d..d80904182 100644 --- a/dist/win/build.ps1 +++ b/dist/win/build.ps1 @@ -35,7 +35,7 @@ Write-Output "`$buildDir=$buildDir" Write-Output "`$Env:JAVA_HOME=$Env:JAVA_HOME" $copyright = "(C) $CopyrightStartYear - $((Get-Date).Year) $Vendor" -$loopbackAlias = 'cryptomator-vault' +$loopbackAlias = "$AppName-vault" # compile &mvn -B -f $buildDir/../../pom.xml clean package -DskipTests -Pwin From 79952418f45dd0d5d636f56553cdace1f170efa2 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Mon, 21 Nov 2022 13:26:14 +0100 Subject: [PATCH 22/35] only use lower characters in loopback alias --- dist/win/build.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dist/win/build.ps1 b/dist/win/build.ps1 index d80904182..2769e790f 100644 --- a/dist/win/build.ps1 +++ b/dist/win/build.ps1 @@ -35,7 +35,7 @@ Write-Output "`$buildDir=$buildDir" Write-Output "`$Env:JAVA_HOME=$Env:JAVA_HOME" $copyright = "(C) $CopyrightStartYear - $((Get-Date).Year) $Vendor" -$loopbackAlias = "$AppName-vault" +$loopbackAlias = $AppName.toLower() + "-vault" # compile &mvn -B -f $buildDir/../../pom.xml clean package -DskipTests -Pwin From 1b0eb34734dc190bc0b2e9454c1c0cfc86b82a93 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Mon, 21 Nov 2022 13:46:12 +0100 Subject: [PATCH 23/35] set loopback alias via parameter in ps1 script --- dist/win/build.bat | 4 +++- dist/win/build.ps1 | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dist/win/build.bat b/dist/win/build.bat index c97ebbb35..997d94328 100644 --- a/dist/win/build.bat +++ b/dist/win/build.bat @@ -9,8 +9,9 @@ SET ABOUT_URL="https://cryptomator.org" SET UPDATE_URL="https://cryptomator.org/downloads/" SET HELP_URL="https://cryptomator.org/contact/" SET MODULE_AND_MAIN_CLASS="org.cryptomator.desktop/org.cryptomator.launcher.Cryptomator" +SET LOOPBACK_ALIAS="cryptomator-vault" -powershell -NoLogo -NoExit -ExecutionPolicy Unrestricted -Command .\build.ps1^ +powershell -NoLogo -ExecutionPolicy Unrestricted -Command .\build.ps1^ -AppName %APPNAME%^ -MainJarGlob "%MAIN_JAR_GLOB%"^ -ModuleAndMainClass "%MODULE_AND_MAIN_CLASS%"^ @@ -20,4 +21,5 @@ powershell -NoLogo -NoExit -ExecutionPolicy Unrestricted -Command .\build.ps1^ -AboutUrl "%ABOUT_URL%"^ -HelpUrl "%HELP_URL%"^ -UpdateUrl "%UPDATE_URL%"^ + -LoopbackAlias "%LOOPBACK_ALIAS%"^ -Clean 1 \ No newline at end of file diff --git a/dist/win/build.ps1 b/dist/win/build.ps1 index 2769e790f..1e316d5f2 100644 --- a/dist/win/build.ps1 +++ b/dist/win/build.ps1 @@ -8,6 +8,7 @@ Param( [Parameter(Mandatory, HelpMessage="Please provide a help url")][string] $HelpUrl, [Parameter(Mandatory, HelpMessage="Please provide an update url")][string] $UpdateUrl, [Parameter(Mandatory, HelpMessage="Please provide an about url")][string] $AboutUrl, + [Parameter(Mandatory, HelpMessage="Please provide an alias for localhost")][string] $LoopbackAlias, [bool] $clean ) @@ -35,7 +36,6 @@ Write-Output "`$buildDir=$buildDir" Write-Output "`$Env:JAVA_HOME=$Env:JAVA_HOME" $copyright = "(C) $CopyrightStartYear - $((Get-Date).Year) $Vendor" -$loopbackAlias = $AppName.toLower() + "-vault" # compile &mvn -B -f $buildDir/../../pom.xml clean package -DskipTests -Pwin @@ -86,7 +86,7 @@ if ($clean -and (Test-Path -Path $appPath)) { --java-options "-Dcryptomator.ipcSocketPath=`"~/AppData/Roaming/$AppName/ipc.socket`"" ` --java-options "-Dcryptomator.p12Path=`"~/AppData/Roaming/$AppName/key.p12`"" ` --java-options "-Dcryptomator.mountPointsDir=`"~/$AppName`"" ` - --java-options "-Dcryptomator.loopbackAlias=`"$loopbackAlias`"" ` + --java-options "-Dcryptomator.loopbackAlias=`"$LoopbackAlias`"" ` --java-options "-Dcryptomator.integrationsWin.autoStartShellLinkName=`"$AppName`"" ` --java-options "-Dcryptomator.integrationsWin.keychainPaths=`"~/AppData/Roaming/$AppName/keychain.json`"" ` --java-options "-Dcryptomator.showTrayIcon=true" ` @@ -110,7 +110,7 @@ attrib -r "$AppName\$AppName.exe" # patch batch script to set hostfile $webDAVPatcher = "$AppName\patchWebDAV.bat" try { - (Get-Content $webDAVPatcher ) -replace '::REPLACE ME', "SET LOOPBACK_ALIAS=`"$loopbackAlias`"" | Set-Content $webDAVPatcher + (Get-Content $webDAVPatcher ) -replace '::REPLACE ME', "SET LOOPBACK_ALIAS=`"$LoopbackAlias`"" | Set-Content $webDAVPatcher } catch { Write-Host "Failed to set LOOPBACK_ALIAS for patchWebDAV.bat" exit 1 From 83af5e796fe5c757c7dfc65e2600dd4711b87bdf Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Mon, 21 Nov 2022 22:10:06 +0100 Subject: [PATCH 24/35] publish only production versions to winget --- .github/workflows/win-exe.yml | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 244cbfc36..332e1e725 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -24,6 +24,11 @@ jobs: runs-on: windows-latest env: LOOPBACK_ALIAS: 'cryptomator-vault' + outputs: + semVerNum: ${{ steps.versions.outputs.semVerNum }} + semVerStr: ${{ steps.versions.outputs.semVerStr }} + revNum: ${{ steps.versions.outputs.revNum }} + isProductionVersion: ${{ steps.versions.outputs.isProductionVersion}} steps: - uses: actions/checkout@v3 with: @@ -34,7 +39,7 @@ jobs: distribution: ${{ env.JAVA_DIST }} java-version: ${{ env.JAVA_VERSION }} cache: ${{ env.JAVA_CACHE }} - - id: versions + - id: versions name: Apply version information run: | if [[ $GITHUB_REF =~ refs/tags/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then @@ -48,9 +53,14 @@ jobs: fi SEM_VER_NUM=`echo ${SEM_VER_STR} | sed -E 's/([0-9]+\.[0-9]+\.[0-9]+).*/\1/'` REVCOUNT=`git rev-list --count HEAD` + PRODUCTION_READY_VERSION="false" + if [[ $SEM_VER_STR =~ [0-9]+\.[0-9].[0-9]+ ]]; then + PRODUCTION_READY_VERSION="true" + fi echo "::set-output name=semVerStr::${SEM_VER_STR}" echo "::set-output name=semVerNum::${SEM_VER_NUM}" echo "::set-output name=revNum::${REVCOUNT}" + echo "::set-output name=isProductionVersion::${PRODUCTION_READY_VERSION}" - name: Validate Version uses: skymatic/semver-validation-action@v1 with: @@ -199,17 +209,14 @@ jobs: files: | *.msi *.asc - outputs: - semVerNum: ${{ steps.versions.outputs.semVerNum }} - semVerStr: ${{ steps.versions.outputs.semVerStr }} - revNum: ${{ steps.versions.outputs.revNum }} call-winget-flow: needs: [build-msi] - if: github.event.action == 'published' + if: github.event.action == 'published' && needs.build-msi.outputs.isProductionVersion uses: ./.github/workflows/winget.yml with: releaseTag: ${{ github.event.release.tag_name }} + secrets: inherit build-exe: From 3223ea2e5dfb7fbf4385e1c32ab940e200053c67 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Tue, 22 Nov 2022 11:18:05 +0100 Subject: [PATCH 25/35] Refactor version parsing and validation to reusable workflow --- .github/workflows/get-version-info.yml | 62 ++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 .github/workflows/get-version-info.yml diff --git a/.github/workflows/get-version-info.yml b/.github/workflows/get-version-info.yml new file mode 100644 index 000000000..1aa97b60a --- /dev/null +++ b/.github/workflows/get-version-info.yml @@ -0,0 +1,62 @@ +name: Parse and Validate a version string or tag + +on: + workflow_call: + inputs: + version: + description: "A specific version to use" + required: false + type: string + outputs: + semVerStr: + description: "The full version string." + value: ${{ jobs.determine-version.outputs.semVerStr}} + semVerNum: + description: "The numerical part of the version string" + value: ${{ jobs.determine-version.outputs.semVerNum}} + revNum: + description: "The revision number" + value: ${{ jobs.determine-version.outputs.revNum}} + +env: + JAVA_VERSION: 19 + JAVA_DIST: 'temurin' + JAVA_CACHE: 'maven' + +jobs: + determine-version: + name: 'Determines the version following semver' + runs-on: ubuntu-latest + outputs: + semVerNum: ${{ steps.versions.outputs.semVerNum }} + semVerStr: ${{ steps.versions.outputs.semVerStr }} + revNum: ${{ steps.versions.outputs.revNum }} + steps: + - uses: actions/checkout@v3 + with: + fetch-depth: 0 + - name: Setup Java + uses: actions/setup-java@v3 + with: + distribution: ${{ env.JAVA_DIST }} + java-version: ${{ env.JAVA_VERSION }} + cache: ${{ env.JAVA_CACHE }} + - id: versions + name: Get version information # TODO: is Github ref inherited when called from super workflow? + run: | + if [[ $GITHUB_REF =~ refs/tags/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then + SEM_VER_STR=${GITHUB_REF##*/} + elif [[ "${{ inputs.version }}" =~ [0-9]+\.[0-9]+\.[0-9]+.* ]]; then + SEM_VER_STR="${{ github.event.inputs.version }}" + else + SEM_VER_STR=`mvn help:evaluate -Dexpression=project.version -q -DforceStdout` + fi + SEM_VER_NUM=`echo ${SEM_VER_STR} | sed -E 's/([0-9]+\.[0-9]+\.[0-9]+).*/\1/'` + REVCOUNT=`git rev-list --count HEAD` + echo "::set-output name=semVerStr::${SEM_VER_STR}" + echo "::set-output name=semVerNum::${SEM_VER_NUM}" + echo "::set-output name=revNum::${REVCOUNT}" + - name: Validate Version + uses: skymatic/semver-validation-action@v1 + with: + version: ${{ steps.versions.outputs.semVerStr }} \ No newline at end of file From 9ca8072ab6335e50852d32339823ece07f5cf83b Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Tue, 22 Nov 2022 14:45:49 +0100 Subject: [PATCH 26/35] Rename workflow and add type output --- .../{get-version-info.yml => get-version.yml} | 15 +++++++++++++++ 1 file changed, 15 insertions(+) rename .github/workflows/{get-version-info.yml => get-version.yml} (76%) diff --git a/.github/workflows/get-version-info.yml b/.github/workflows/get-version.yml similarity index 76% rename from .github/workflows/get-version-info.yml rename to .github/workflows/get-version.yml index 1aa97b60a..e4f49bf74 100644 --- a/.github/workflows/get-version-info.yml +++ b/.github/workflows/get-version.yml @@ -17,6 +17,9 @@ on: revNum: description: "The revision number" value: ${{ jobs.determine-version.outputs.revNum}} + versionType: + description: "Type of the version. Values are [stable, alpha, beta, rc, unknown]" + value: ${{ jobs.determine-version.outputs.type }} env: JAVA_VERSION: 19 @@ -31,6 +34,7 @@ jobs: semVerNum: ${{ steps.versions.outputs.semVerNum }} semVerStr: ${{ steps.versions.outputs.semVerStr }} revNum: ${{ steps.versions.outputs.revNum }} + type: ${{ steps.versions.outputs.type}} steps: - uses: actions/checkout@v3 with: @@ -53,9 +57,20 @@ jobs: fi SEM_VER_NUM=`echo ${SEM_VER_STR} | sed -E 's/([0-9]+\.[0-9]+\.[0-9]+).*/\1/'` REVCOUNT=`git rev-list --count HEAD` + TYPE="unknown" + if [[ $SEM_VER_STR =~ [0-9]+\.[0-9]+\.[0-9]+ ]]; then + TYPE="stable" + elif [[ $SEM_VER_STR =~ [0-9]+\.[0-9]+\.[0-9]+-alpha[1-9] ]]; then + TYPE="alpha" + elif [[ $SEM_VER_STR =~ [0-9]+\.[0-9]+\.[0-9]+-beta[1-9] ]]; then + TYPE="beta" + elif [[ $SEM_VER_STR =~ [0-9]+\.[0-9]+\.[0-9]+-rc[1-9] ]]; then + TYPE="rc" + fi echo "::set-output name=semVerStr::${SEM_VER_STR}" echo "::set-output name=semVerNum::${SEM_VER_NUM}" echo "::set-output name=revNum::${REVCOUNT}" + echo "::set-output name=type::${TYPE}" - name: Validate Version uses: skymatic/semver-validation-action@v1 with: From 083d0cfbc486f78c7e9c7312672c913cb3e9eb48 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Tue, 22 Nov 2022 14:51:12 +0100 Subject: [PATCH 27/35] migrate windows build to use get-version workflow --- .github/workflows/win-exe.yml | 61 +++++++++++------------------------ 1 file changed, 18 insertions(+), 43 deletions(-) diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 332e1e725..3fdea0c43 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -19,52 +19,27 @@ defaults: shell: bash jobs: + get-version: + uses: ./.github/workflows/get-version.yml + with: + version: ${{ github.event.inputs.version }} + build-msi: name: Build .msi Installer runs-on: windows-latest + needs: [get-version] env: LOOPBACK_ALIAS: 'cryptomator-vault' - outputs: - semVerNum: ${{ steps.versions.outputs.semVerNum }} - semVerStr: ${{ steps.versions.outputs.semVerStr }} - revNum: ${{ steps.versions.outputs.revNum }} - isProductionVersion: ${{ steps.versions.outputs.isProductionVersion}} steps: - uses: actions/checkout@v3 - with: - fetch-depth: 0 - name: Setup Java uses: actions/setup-java@v3 with: distribution: ${{ env.JAVA_DIST }} java-version: ${{ env.JAVA_VERSION }} cache: ${{ env.JAVA_CACHE }} - - id: versions - name: Apply version information - run: | - if [[ $GITHUB_REF =~ refs/tags/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR=${GITHUB_REF##*/} - mvn versions:set -DnewVersion=${SEM_VER_STR} - elif [[ "${{ github.event.inputs.version }}" =~ [0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR="${{ github.event.inputs.version }}" - mvn versions:set -DnewVersion=${SEM_VER_STR} - else - SEM_VER_STR=`mvn help:evaluate -Dexpression=project.version -q -DforceStdout` - fi - SEM_VER_NUM=`echo ${SEM_VER_STR} | sed -E 's/([0-9]+\.[0-9]+\.[0-9]+).*/\1/'` - REVCOUNT=`git rev-list --count HEAD` - PRODUCTION_READY_VERSION="false" - if [[ $SEM_VER_STR =~ [0-9]+\.[0-9].[0-9]+ ]]; then - PRODUCTION_READY_VERSION="true" - fi - echo "::set-output name=semVerStr::${SEM_VER_STR}" - echo "::set-output name=semVerNum::${SEM_VER_NUM}" - echo "::set-output name=revNum::${REVCOUNT}" - echo "::set-output name=isProductionVersion::${PRODUCTION_READY_VERSION}" - - name: Validate Version - uses: skymatic/semver-validation-action@v1 - with: - version: ${{ steps.versions.outputs.semVerStr }} + - name: Set version + run : mvn versions:set -DnewVersion=${{ needs.get-version.outputs.semVerStr }} - name: Run maven run: mvn -B clean package -Pdependency-check,win -DskipTests - name: Patch target dir @@ -97,10 +72,10 @@ jobs: --name Cryptomator --vendor "Skymatic GmbH" --copyright "(C) 2016 - 2022 Skymatic GmbH" - --app-version "${{ steps.versions.outputs.semVerNum }}.${{ steps.versions.outputs.revNum }}" + --app-version "${{ needs.get-version.outputs.semVerNum }}.${{ needs.get-version.outputs.revNum }}" --java-options "-Xss5m" --java-options "-Xmx256m" - --java-options "-Dcryptomator.appVersion=\"${{ steps.versions.outputs.semVerStr }}\"" + --java-options "-Dcryptomator.appVersion=\"${{ needs.get-version.outputs.semVerStr }}\"" --java-options "-Dfile.encoding=\"utf-8\"" --java-options "-Dcryptomator.logDir=\"~/AppData/Roaming/Cryptomator\"" --java-options "-Dcryptomator.pluginDir=\"~/AppData/Roaming/Cryptomator/Plugins\"" @@ -110,7 +85,7 @@ jobs: --java-options "-Dcryptomator.mountPointsDir=\"~/Cryptomator\"" --java-options "-Dcryptomator.loopbackAlias=\"${{ env.LOOPBACK_ALIAS }}\"" --java-options "-Dcryptomator.showTrayIcon=true" - --java-options "-Dcryptomator.buildNumber=\"msi-${{ steps.versions.outputs.revNum }}\"" + --java-options "-Dcryptomator.buildNumber=\"msi-${{ needs.get-version.outputs.revNum }}\"" --java-options "-Dcryptomator.integrationsWin.autoStartShellLinkName=\"Cryptomator\"" --java-options "-Dcryptomator.integrationsWin.keychainPaths=\"~/AppData/Roaming/Cryptomator/keychain.json\"" --resource-dir dist/win/resources @@ -163,7 +138,7 @@ jobs: --name Cryptomator --vendor "Skymatic GmbH" --copyright "(C) 2016 - 2022 Skymatic GmbH" - --app-version "${{ steps.versions.outputs.semVerNum }}" + --app-version "${{ needs.get-version.outputs.semVerNum }}" --win-menu --win-dir-chooser --win-shortcut-prompt @@ -184,7 +159,7 @@ jobs: timestampUrl: 'http://timestamp.digicert.com' folder: installer - name: Add possible alpha/beta tags to installer name - run: mv installer/Cryptomator-*.msi Cryptomator-${{ steps.versions.outputs.semVerStr }}-x64.msi + run: mv installer/Cryptomator-*.msi Cryptomator-${{ needs.get-version.outputs.semVerStr }}-x64.msi - name: Create detached GPG signature with key 615D449FE6E6A235 run: | echo "${GPG_PRIVATE_KEY}" | gpg --batch --quiet --import @@ -211,8 +186,8 @@ jobs: *.asc call-winget-flow: - needs: [build-msi] - if: github.event.action == 'published' && needs.build-msi.outputs.isProductionVersion + needs: [get-version, build-msi] + if: github.event.action == 'published' && needs.get-version.outputs.type == 'stable' uses: ./.github/workflows/winget.yml with: releaseTag: ${{ github.event.release.tag_name }} @@ -222,7 +197,7 @@ jobs: build-exe: name: Build .exe installer runs-on: windows-latest - needs: [build-msi] + needs: [version, build-msi] steps: - uses: actions/checkout@v3 - name: Download .msi @@ -258,7 +233,7 @@ jobs: "${WIX}/bin/candle.exe" dist/win/bundle/bundleWithWinfsp.wxs -ext WixBalExtension -out dist/win/bundle/ - -dBundleVersion="${{ needs.build-msi.outputs.semVerNum }}.${{ needs.build-msi.outputs.revNum }}" + -dBundleVersion="${{ needs.get-version.outputs.semVerNum }}.${{ needs.get-version.outputs.revNum }}" -dBundleVendor="Skymatic GmbH" -dBundleCopyright="(C) 2016 - 2022 Skymatic GmbH" -dAboutUrl="https://cryptomator.org" @@ -298,7 +273,7 @@ jobs: timestampUrl: 'http://timestamp.digicert.com' folder: installer - name: Add possible alpha/beta tags to installer name - run: mv installer/Cryptomator-Installer.exe Cryptomator-${{ needs.build-msi.outputs.semVerStr }}-x64.exe + run: mv installer/Cryptomator-Installer.exe Cryptomator-${{ needs.get-version.outputs.semVerStr }}-x64.exe - name: Create detached GPG signature with key 615D449FE6E6A235 run: | echo "${GPG_PRIVATE_KEY}" | gpg --batch --quiet --import From faf39c2507eb20813f892040c742fcd8ef458a9c Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Tue, 22 Nov 2022 15:01:47 +0100 Subject: [PATCH 28/35] fix wrong name --- .github/workflows/win-exe.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 3fdea0c43..055d5d194 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -197,7 +197,7 @@ jobs: build-exe: name: Build .exe installer runs-on: windows-latest - needs: [version, build-msi] + needs: [get-version, build-msi] steps: - uses: actions/checkout@v3 - name: Download .msi From 23d9521724ec57408198546abd0f56319896de93 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 25 Nov 2022 17:29:36 +0100 Subject: [PATCH 29/35] Remove resolved TODO (see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_call) --- .github/workflows/get-version.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/get-version.yml b/.github/workflows/get-version.yml index e4f49bf74..7ccb1b9a3 100644 --- a/.github/workflows/get-version.yml +++ b/.github/workflows/get-version.yml @@ -46,7 +46,7 @@ jobs: java-version: ${{ env.JAVA_VERSION }} cache: ${{ env.JAVA_CACHE }} - id: versions - name: Get version information # TODO: is Github ref inherited when called from super workflow? + name: Get version information run: | if [[ $GITHUB_REF =~ refs/tags/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then SEM_VER_STR=${GITHUB_REF##*/} From 34986f59193c666e3da08d087936bedcb419f79e Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 25 Nov 2022 17:46:24 +0100 Subject: [PATCH 30/35] migrate other build worfklows to use get-version.yml --- .github/workflows/appimage.yml | 43 +++++++++++--------------------- .github/workflows/debian.yml | 32 +++++++----------------- .github/workflows/mac-dmg.yml | 45 ++++++++++++---------------------- 3 files changed, 38 insertions(+), 82 deletions(-) diff --git a/.github/workflows/appimage.yml b/.github/workflows/appimage.yml index 0bd519d39..26d455b8f 100644 --- a/.github/workflows/appimage.yml +++ b/.github/workflows/appimage.yml @@ -13,40 +13,25 @@ env: JAVA_VERSION: 19 jobs: + get-version: + uses: ./.github/workflows/get-version.yml + with: + version: ${{ github.event.inputs.version }} + build: name: Build AppImage runs-on: ubuntu-latest + needs: [get-version] steps: - uses: actions/checkout@v3 - with: - fetch-depth: 0 - name: Setup Java uses: actions/setup-java@v3 with: distribution: 'zulu' java-version: ${{ env.JAVA_VERSION }} cache: 'maven' - - id: versions - name: Apply version information - run: | - if [[ $GITHUB_REF =~ refs/tags/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR=${GITHUB_REF##*/} - mvn versions:set -DnewVersion=${SEM_VER_STR} - elif [[ "${{ github.event.inputs.version }}" =~ [0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR="${{ github.event.inputs.version }}" - mvn versions:set -DnewVersion=${SEM_VER_STR} - else - SEM_VER_STR=`mvn help:evaluate -Dexpression=project.version -q -DforceStdout` - fi - SEM_VER_NUM=`echo ${SEM_VER_STR} | sed -E 's/([0-9]+\.[0-9]+\.[0-9]+).*/\1/'` - REVCOUNT=`git rev-list --count HEAD` - echo "::set-output name=semVerStr::${SEM_VER_STR}" - echo "::set-output name=semVerNum::${SEM_VER_NUM}" - echo "::set-output name=revNum::${REVCOUNT}" - - name: Validate Version - uses: skymatic/semver-validation-action@v1 - with: - version: ${{ steps.versions.outputs.semVerStr }} + - name: Set version + run : mvn versions:set -DnewVersion=${{ needs.get-version.outputs.semVerStr }} - name: Run maven run: mvn -B clean package -Pdependency-check,linux -DskipTests - name: Patch target dir @@ -69,8 +54,8 @@ jobs: - name: Prepare additional launcher run: envsubst '${SEMVER_STR} ${REVISION_NUM}' < dist/linux/launcher-gtk2.properties > launcher-gtk2.properties env: - SEMVER_STR: ${{ steps.versions.outputs.semVerStr }} - REVISION_NUM: ${{ steps.versions.outputs.revNum }} + SEMVER_STR: ${{ needs.get-version.outputs.semVerStr }} + REVISION_NUM: ${{ needs.get-version.outputs.revNum }} - name: Run jpackage run: > ${JAVA_HOME}/bin/jpackage @@ -84,10 +69,10 @@ jobs: --name Cryptomator --vendor "Skymatic GmbH" --copyright "(C) 2016 - 2022 Skymatic GmbH" - --app-version "${{ steps.versions.outputs.semVerNum }}.${{ steps.versions.outputs.revNum }}" + --app-version "${{ needs.get-version.outputs.semVerNum }}.${{ needs.get-version.outputs.revNum }}" --java-options "-Xss5m" --java-options "-Xmx256m" - --java-options "-Dcryptomator.appVersion=\"${{ steps.versions.outputs.semVerStr }}\"" + --java-options "-Dcryptomator.appVersion=\"${{ needs.get-version.outputs.semVerStr }}\"" --java-options "-Dfile.encoding=\"utf-8\"" --java-options "-Dcryptomator.logDir=\"~/.local/share/Cryptomator/logs\"" --java-options "-Dcryptomator.pluginDir=\"~/.local/share/Cryptomator/plugins\"" @@ -96,7 +81,7 @@ jobs: --java-options "-Dcryptomator.ipcSocketPath=\"~/.config/Cryptomator/ipc.socket\"" --java-options "-Dcryptomator.mountPointsDir=\"~/.local/share/Cryptomator/mnt\"" --java-options "-Dcryptomator.showTrayIcon=false" - --java-options "-Dcryptomator.buildNumber=\"appimage-${{ steps.versions.outputs.revNum }}\"" + --java-options "-Dcryptomator.buildNumber=\"appimage-${{ needs.get-version.outputs.revNum }}\"" --add-launcher Cryptomator-gtk2=launcher-gtk2.properties --resource-dir dist/linux/resources - name: Patch Cryptomator.AppDir @@ -134,7 +119,7 @@ jobs: GPG_PASSPHRASE: ${{ secrets.RELEASES_GPG_PASSPHRASE }} - name: Build AppImage run: > - ./squashfs-root/AppRun Cryptomator.AppDir cryptomator-${{ steps.versions.outputs.semVerStr }}-x86_64.AppImage + ./squashfs-root/AppRun Cryptomator.AppDir cryptomator-${{ needs.get-version.outputs.semVerStr }}-x86_64.AppImage -u 'gh-releases-zsync|cryptomator|cryptomator|latest|cryptomator-*-x86_64.AppImage.zsync' --sign --sign-key=615D449FE6E6A235 --sign-args="--batch --pinentry-mode loopback" - name: Create detached GPG signatures diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index 500587444..5fe3b7195 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -23,8 +23,6 @@ jobs: runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v3 - with: - fetch-depth: 0 - name: Install build tools run: | sudo add-apt-repository ppa:coffeelibs/openjdk @@ -36,24 +34,12 @@ jobs: distribution: 'zulu' java-version: ${{ env.JAVA_VERSION }} cache: 'maven' - - id: versions - name: Apply version information - run: | - if [[ $GITHUB_REF =~ refs/tags/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR=${GITHUB_REF##*/} - mvn versions:set -DnewVersion=${SEM_VER_STR} - elif [[ "${{ github.event.inputs.version }}" =~ [0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR="${{ github.event.inputs.version }}" - mvn versions:set -DnewVersion=${SEM_VER_STR} - else - SEM_VER_STR=`mvn help:evaluate -Dexpression=project.version -q -DforceStdout` - fi - SEM_VER_NUM=`echo ${SEM_VER_STR} | sed -E 's/([0-9]+\.[0-9]+\.[0-9]+).*/\1/'` - REVCOUNT=`git rev-list --count HEAD` - echo "::set-output name=semVerStr::${SEM_VER_STR}" - echo "::set-output name=semVerNum::${SEM_VER_NUM}" - echo "::set-output name=revNum::${REVCOUNT}" - echo "::set-output name=ppaVerStr::${SEM_VER_STR/-/\~}-${REVCOUNT}" + - id: versions + name: Create PPA version string + run: echo "::set-output name=ppaVerStr::${SEM_VER_STR/-/\~}-${REVCOUNT}" + env: + SEM_VER_STR: ${{ needs.get-version.outputs.semVerStr }} + REVCOUNT: ${{ needs.get-version.outputs.revNum }} - name: Validate Version uses: skymatic/semver-validation-action@v1 with: @@ -77,9 +63,9 @@ jobs: find . -name "*.jar" >> pkgdir/debian/source/include-binaries mv pkgdir cryptomator_${{ steps.versions.outputs.ppaVerStr }} env: - SEMVER_STR: ${{ steps.versions.outputs.semVerStr }} - VERSION_NUM: ${{ steps.versions.outputs.semVerNum }} - REVISION_NUM: ${{ steps.versions.outputs.revNum }} + SEMVER_STR: ${{ needs.get-version.outputs.semVerStr }} + VERSION_NUM: ${{ needs.get-version.outputs.semVerNum }} + REVISION_NUM: ${{ needs.get-version.outputs.revNum }} PPA_VERSION: ${{ steps.versions.outputs.ppaVerStr }}-0ppa1 - name: Prepare GPG-Agent for signing with key 615D449FE6E6A235 run: | diff --git a/.github/workflows/mac-dmg.yml b/.github/workflows/mac-dmg.yml index b51430ee0..446760deb 100644 --- a/.github/workflows/mac-dmg.yml +++ b/.github/workflows/mac-dmg.yml @@ -13,9 +13,15 @@ env: JAVA_VERSION: 19 jobs: + get-version: + uses: ./.github/workflows/get-version.yml + with: + version: ${{ github.event.inputs.version }} + build: name: Build Cryptomator.app for ${{ matrix.output-suffix }} runs-on: ${{ matrix.os }} + needs: [get-version] strategy: fail-fast: false matrix: @@ -30,8 +36,6 @@ jobs: xcode-path: '/Applications/Xcode_13.2.1.app' steps: - uses: actions/checkout@v3 - with: - fetch-depth: 0 - name: Setup Java uses: actions/setup-java@v3 with: @@ -39,27 +43,8 @@ jobs: java-version: ${{ env.JAVA_VERSION }} architecture: ${{ matrix.architecture }} cache: 'maven' - - id: versions - name: Apply version information - run: | - if [[ $GITHUB_REF =~ refs/tags/[0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR=${GITHUB_REF##*/} - mvn versions:set -DnewVersion=${SEM_VER_STR} - elif [[ "${{ github.event.inputs.version }}" =~ [0-9]+\.[0-9]+\.[0-9]+.* ]]; then - SEM_VER_STR="${{ github.event.inputs.version }}" - mvn versions:set -DnewVersion=${SEM_VER_STR} - else - SEM_VER_STR=`mvn help:evaluate -Dexpression=project.version -q -DforceStdout` - fi - SEM_VER_NUM=`echo ${SEM_VER_STR} | sed -E 's/([0-9]+\.[0-9]+\.[0-9]+).*/\1/'` - REVCOUNT=`git rev-list --count HEAD` - echo "::set-output name=semVerStr::${SEM_VER_STR}" - echo "::set-output name=semVerNum::${SEM_VER_NUM}" - echo "::set-output name=revNum::${REVCOUNT}" - - name: Validate Version - uses: skymatic/semver-validation-action@v1 - with: - version: ${{ steps.versions.outputs.semVerStr }} + - name: Set version + run : mvn versions:set -DnewVersion=${{ needs.get-version.outputs.semVerStr }} - name: Run maven run: mvn -B clean package -Pdependency-check,mac -DskipTests - name: Patch target dir @@ -92,13 +77,13 @@ jobs: --name Cryptomator --vendor "Skymatic GmbH" --copyright "(C) 2016 - 2022 Skymatic GmbH" - --app-version "${{ steps.versions.outputs.semVerNum }}" + --app-version "${{ needs.get-version.outputs.semVerNum }} --java-options "-Xss5m" --java-options "-Xmx256m" --java-options "-Dfile.encoding=\"utf-8\"" --java-options "-Dapple.awt.enableTemplateImages=true" --java-options "-Dsun.java2d.metal=true" - --java-options "-Dcryptomator.appVersion=\"${{ steps.versions.outputs.semVerStr }}\"" + --java-options "-Dcryptomator.appVersion=\"${{ needs.get-version.outputs.semVerStr }}\"" --java-options "-Dcryptomator.logDir=\"~/Library/Logs/Cryptomator\"" --java-options "-Dcryptomator.pluginDir=\"~/Library/Application Support/Cryptomator/Plugins\"" --java-options "-Dcryptomator.settingsPath=\"~/Library/Application Support/Cryptomator/settings.json\"" @@ -106,7 +91,7 @@ jobs: --java-options "-Dcryptomator.ipcSocketPath=\"~/Library/Application Support/Cryptomator/ipc.socket\"" --java-options "-Dcryptomator.integrationsMac.keychainServiceName=\"Cryptomator\"" --java-options "-Dcryptomator.showTrayIcon=true" - --java-options "-Dcryptomator.buildNumber=\"dmg-${{ steps.versions.outputs.revNum }}\"" + --java-options "-Dcryptomator.buildNumber=\"dmg-${{ needs.get-version.outputs.revNum }}\"" --mac-package-identifier org.cryptomator --resource-dir dist/mac/resources - name: Patch Cryptomator.app @@ -116,8 +101,8 @@ jobs: sed -i '' "s|###BUNDLE_SHORT_VERSION_STRING###|${VERSION_NO}|g" Cryptomator.app/Contents/Info.plist sed -i '' "s|###BUNDLE_VERSION###|${REVISION_NO}|g" Cryptomator.app/Contents/Info.plist env: - VERSION_NO: ${{ steps.versions.outputs.semVerNum }} - REVISION_NO: ${{ steps.versions.outputs.revNum }} + VERSION_NO: ${{ needs.get-version.outputs.semVerNum }} + REVISION_NO: ${{ needs.get-version.outputs.revNum }} - name: Generate license for dmg run: > mvn -B license:add-third-party @@ -201,7 +186,7 @@ jobs: --icon ".VolumeIcon.icns" 512 758 Cryptomator-${VERSION_NO}-${{ matrix.output-suffix }}.dmg dmg env: - VERSION_NO: ${{ steps.versions.outputs.semVerNum }} + VERSION_NO: ${{ needs.get-version.outputs.semVerNum }} - name: Notarize .dmg if: startsWith(github.ref, 'refs/tags/') uses: cocoalibs/xcode-notarization-action@v1 @@ -212,7 +197,7 @@ jobs: team-id: ${{ secrets.MACOS_NOTARIZATION_TEAM_ID }} xcode-path: ${{ matrix.xcode-path }} - name: Add possible alpha/beta tags to installer name - run: mv Cryptomator-*.dmg Cryptomator-${{ steps.versions.outputs.semVerStr }}-${{ matrix.output-suffix }}.dmg + run: mv Cryptomator-*.dmg Cryptomator-${{ needs.get-version.outputs.semVerStr }}-${{ matrix.output-suffix }}.dmg - name: Create detached GPG signature with key 615D449FE6E6A235 run: | echo "${GPG_PRIVATE_KEY}" | gpg --batch --quiet --import From 9984b2af9b84ad9de3449336e67202c38a2fda4a Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 25 Nov 2022 17:56:24 +0100 Subject: [PATCH 31/35] Fix errors --- .github/workflows/debian.yml | 12 +++++++----- .github/workflows/mac-dmg.yml | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index 5fe3b7195..646c8e814 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -18,9 +18,15 @@ env: JAVA_VERSION: 19 jobs: + get-version: + uses: ./.github/workflows/get-version.yml + with: + version: ${{ github.event.inputs.version }} + build: name: Build Debian Package runs-on: ubuntu-20.04 + needs: [get-version] steps: - uses: actions/checkout@v3 - name: Install build tools @@ -40,10 +46,6 @@ jobs: env: SEM_VER_STR: ${{ needs.get-version.outputs.semVerStr }} REVCOUNT: ${{ needs.get-version.outputs.revNum }} - - name: Validate Version - uses: skymatic/semver-validation-action@v1 - with: - version: ${{ steps.versions.outputs.semVerStr }} - name: Run maven run: mvn -B clean package -Pdependency-check,linux -DskipTests - name: Create orig.tar.gz with common/ libs/ mods/ @@ -61,7 +63,7 @@ jobs: envsubst '${SEMVER_STR} ${VERSION_NUM} ${REVISION_NUM}' < dist/linux/debian/rules > pkgdir/debian/rules envsubst '${PPA_VERSION} ${RFC2822_TIMESTAMP}' < dist/linux/debian/changelog > pkgdir/debian/changelog find . -name "*.jar" >> pkgdir/debian/source/include-binaries - mv pkgdir cryptomator_${{ steps.versions.outputs.ppaVerStr }} + mv pkgdir cryptomator_${PPA_VERSION} env: SEMVER_STR: ${{ needs.get-version.outputs.semVerStr }} VERSION_NUM: ${{ needs.get-version.outputs.semVerNum }} diff --git a/.github/workflows/mac-dmg.yml b/.github/workflows/mac-dmg.yml index 446760deb..d52441a0e 100644 --- a/.github/workflows/mac-dmg.yml +++ b/.github/workflows/mac-dmg.yml @@ -77,7 +77,7 @@ jobs: --name Cryptomator --vendor "Skymatic GmbH" --copyright "(C) 2016 - 2022 Skymatic GmbH" - --app-version "${{ needs.get-version.outputs.semVerNum }} + --app-version "${{ needs.get-version.outputs.semVerNum }}" --java-options "-Xss5m" --java-options "-Xmx256m" --java-options "-Dfile.encoding=\"utf-8\"" From edaa2b7391118e8b8d841728c6794c9fac29aeaf Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Fri, 25 Nov 2022 18:07:07 +0100 Subject: [PATCH 32/35] Revert partially 9984b2af9b84ad9de3449336e67202c38a2fda4a --- .github/workflows/debian.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index 646c8e814..2e3188039 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -63,7 +63,7 @@ jobs: envsubst '${SEMVER_STR} ${VERSION_NUM} ${REVISION_NUM}' < dist/linux/debian/rules > pkgdir/debian/rules envsubst '${PPA_VERSION} ${RFC2822_TIMESTAMP}' < dist/linux/debian/changelog > pkgdir/debian/changelog find . -name "*.jar" >> pkgdir/debian/source/include-binaries - mv pkgdir cryptomator_${PPA_VERSION} + mv pkgdir cryptomator_${{ steps.versions.outputs.ppaVerStr }} env: SEMVER_STR: ${{ needs.get-version.outputs.semVerStr }} VERSION_NUM: ${{ needs.get-version.outputs.semVerNum }} From 11aea06ecfcec00f2887aa05a420c508e1bac394 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Mon, 28 Nov 2022 13:36:15 +0100 Subject: [PATCH 33/35] replace deprecated set-output command in ci --- .github/workflows/debian.yml | 2 +- .github/workflows/dl-stats.yml | 2 +- .github/workflows/get-version.yml | 8 ++++---- .github/workflows/release-check.yml | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index 2e3188039..a194d4ad1 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -42,7 +42,7 @@ jobs: cache: 'maven' - id: versions name: Create PPA version string - run: echo "::set-output name=ppaVerStr::${SEM_VER_STR/-/\~}-${REVCOUNT}" + run: echo "ppaVerStr=${SEM_VER_STR/-/\~}-${REVCOUNT}" >> $GITHUB_OUTPUT env: SEM_VER_STR: ${{ needs.get-version.outputs.semVerStr }} REVCOUNT: ${{ needs.get-version.outputs.revNum }} diff --git a/.github/workflows/dl-stats.yml b/.github/workflows/dl-stats.yml index 0d9ca5dd7..dc87a2bbd 100644 --- a/.github/workflows/dl-stats.yml +++ b/.github/workflows/dl-stats.yml @@ -48,7 +48,7 @@ jobs: jq -c 'select(.filename|endswith(".dmg")) | select(.filename|endswith("-arm64.dmg")|not) | {name: "github.releases.downloads", tags: ["file=dmg", "version=\(.release)", "arch=amd64"], value: .downloads, interval: .interval, time: .time}' input.json >> output.json RESULT=$(jq -s -c "." output.json) - echo "::set-output name=result::${RESULT}" + echo "result=${RESULT}" >> $GITHUB_OUTPUT env: INTERVAL: 900 JSON_DATA: ${{ steps.get-stats.outputs.result }} diff --git a/.github/workflows/get-version.yml b/.github/workflows/get-version.yml index 7ccb1b9a3..1791a48f5 100644 --- a/.github/workflows/get-version.yml +++ b/.github/workflows/get-version.yml @@ -67,10 +67,10 @@ jobs: elif [[ $SEM_VER_STR =~ [0-9]+\.[0-9]+\.[0-9]+-rc[1-9] ]]; then TYPE="rc" fi - echo "::set-output name=semVerStr::${SEM_VER_STR}" - echo "::set-output name=semVerNum::${SEM_VER_NUM}" - echo "::set-output name=revNum::${REVCOUNT}" - echo "::set-output name=type::${TYPE}" + echo "semVerStr=${SEM_VER_STR}" >> $GITHUB_OUTPUT + echo "semVerNum=${SEM_VER_NUM}" >> $GITHUB_OUTPUT + echo "revNum=${REVCOUNT}" >> $GITHUB_OUTPUT + echo "type=${TYPE}" >> $GITHUB_OUTPUT - name: Validate Version uses: skymatic/semver-validation-action@v1 with: diff --git a/.github/workflows/release-check.yml b/.github/workflows/release-check.yml index e2f116130..7309cb852 100644 --- a/.github/workflows/release-check.yml +++ b/.github/workflows/release-check.yml @@ -30,7 +30,7 @@ jobs: fi if [[ ${SEM_VER_STR} == `mvn help:evaluate -Dexpression=project.version -q -DforceStdout` ]]; then - echo "::set-output name=semVerStr::${SEM_VER_STR}" + echo "semVerStr=${SEM_VER_STR}" >> $GITHUB_OUTPUT else echo "Version not set in POM" exit 1 From db63a82d76b2b2272657b8ac2efb39f64f6313be Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Mon, 28 Nov 2022 13:46:02 +0100 Subject: [PATCH 34/35] bump version of skymatic actions --- .github/workflows/get-version.yml | 2 +- .github/workflows/win-exe.yml | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/get-version.yml b/.github/workflows/get-version.yml index 1791a48f5..e6131b835 100644 --- a/.github/workflows/get-version.yml +++ b/.github/workflows/get-version.yml @@ -72,6 +72,6 @@ jobs: echo "revNum=${REVCOUNT}" >> $GITHUB_OUTPUT echo "type=${TYPE}" >> $GITHUB_OUTPUT - name: Validate Version - uses: skymatic/semver-validation-action@v1 + uses: skymatic/semver-validation-action@v2 with: version: ${{ steps.versions.outputs.semVerStr }} \ No newline at end of file diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 055d5d194..0725c0329 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -107,7 +107,7 @@ jobs: run: attrib -r appdir/Cryptomator/Cryptomator.exe shell: pwsh - name: Codesign - uses: skymatic/code-sign-action@v1 + uses: skymatic/code-sign-action@v2 with: certificate: ${{ secrets.WIN_CODESIGN_P12_BASE64 }} password: ${{ secrets.WIN_CODESIGN_P12_PW }} @@ -150,7 +150,7 @@ jobs: env: JP_WIXWIZARD_RESOURCES: ${{ github.workspace }}/dist/win/resources # requires abs path, used in resources/main.wxs - name: Codesign MSI - uses: skymatic/code-sign-action@v1 + uses: skymatic/code-sign-action@v2 with: certificate: ${{ secrets.WIN_CODESIGN_P12_BASE64 }} password: ${{ secrets.WIN_CODESIGN_P12_PW }} @@ -250,7 +250,7 @@ jobs: -ib installer/unsigned/Cryptomator-Installer.exe -o tmp/engine.exe - name: Codesign burn engine - uses: skymatic/code-sign-action@v1 + uses: skymatic/code-sign-action@v2 with: certificate: ${{ secrets.WIN_CODESIGN_P12_BASE64 }} password: ${{ secrets.WIN_CODESIGN_P12_PW }} @@ -264,7 +264,7 @@ jobs: -ab tmp/engine.exe installer/unsigned/Cryptomator-Installer.exe -o installer/Cryptomator-Installer.exe - name: Codesign EXE - uses: skymatic/code-sign-action@v1 + uses: skymatic/code-sign-action@v2 with: certificate: ${{ secrets.WIN_CODESIGN_P12_BASE64 }} password: ${{ secrets.WIN_CODESIGN_P12_PW }} From 2f9818aadec270b3ac0df9a5a1204e100e40226f Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Tue, 29 Nov 2022 17:07:43 +0100 Subject: [PATCH 35/35] use new JavaFX 19 API --- .../ChooseExistingVaultController.java | 36 +++++++------------ 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java b/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java index 0a0dc3d2e..fe4ac3bd1 100644 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java +++ b/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java @@ -15,7 +15,6 @@ import org.slf4j.LoggerFactory; import javax.inject.Inject; import javafx.beans.property.ObjectProperty; -import javafx.beans.property.SimpleObjectProperty; import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; import javafx.scene.Scene; @@ -25,6 +24,7 @@ import javafx.stage.Stage; import java.io.File; import java.io.IOException; import java.nio.file.Path; +import java.util.Objects; import java.util.ResourceBundle; import static org.cryptomator.common.Constants.CRYPTOMATOR_FILENAME_GLOB; @@ -42,9 +42,7 @@ public class ChooseExistingVaultController implements FxController { private final ObjectProperty vault; private final VaultListManager vaultListManager; private final ResourceBundle resourceBundle; - private final FxApplicationStyle applicationStyle; - - private final ObjectProperty screenshot = new SimpleObjectProperty<>(); + private final ObservableValue screenshot; @Inject ChooseExistingVaultController(@AddVaultWizardWindow Stage window, @FxmlScene(FxmlFile.ADDVAULT_WELCOME) Lazy welcomeScene, @FxmlScene(FxmlFile.ADDVAULT_SUCCESS) Lazy successScene, FxApplicationWindows appWindows, ObjectProperty vaultPath, @AddVaultWizardWindow ObjectProperty vault, VaultListManager vaultListManager, ResourceBundle resourceBundle, FxApplicationStyle applicationStyle) { @@ -56,28 +54,20 @@ public class ChooseExistingVaultController implements FxController { this.vault = vault; this.vaultListManager = vaultListManager; this.resourceBundle = resourceBundle; - this.applicationStyle = applicationStyle; + this.screenshot = applicationStyle.appliedThemeProperty().map(this::selectScreenshot); } - @FXML - public void initialize() { + private Image selectScreenshot(Theme theme) { + String imageResourcePath; if (SystemUtils.IS_OS_MAC) { - applicationStyle.appliedThemeProperty().addListener(this::appliedThemeChanged); - setMacScreenshot(applicationStyle.appliedThemeProperty().get()); + imageResourcePath = switch (theme) { + case LIGHT -> "/img/select-masterkey-mac.png"; + case DARK -> "/img/select-masterkey-mac-dark.png"; + }; } else { - this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-win.png").toString())); - } - } - - private void appliedThemeChanged(@SuppressWarnings("unused") ObservableValue observable, @SuppressWarnings("unused") Theme oldValue, Theme newValue) { - setMacScreenshot(newValue); - } - - private void setMacScreenshot(Theme theme) { - switch (theme) { - case LIGHT -> this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-mac.png").toString())); - case DARK -> this.screenshot.set(new Image(getClass().getResource("/img/select-masterkey-mac-dark.png").toString())); + imageResourcePath = "/img/select-masterkey-win.png"; } + return new Image((Objects.requireNonNull(getClass().getResource(imageResourcePath)).toString())); } @FXML @@ -106,12 +96,12 @@ public class ChooseExistingVaultController implements FxController { /* Getter */ - public ObjectProperty screenshotProperty() { + public ObservableValue screenshotProperty() { return screenshot; } public Image getScreenshot() { - return screenshot.get(); + return screenshot.getValue(); }