From dbc0f52481bbccd186af63942225aa549d6664ca Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Wed, 21 Feb 2024 22:04:35 +0100 Subject: [PATCH 01/21] fix not-uploading artifacts on release --- .github/workflows/appimage.yml | 2 +- .github/workflows/debian.yml | 1 - .github/workflows/mac-dmg.yml | 2 +- .github/workflows/win-exe.yml | 8 ++++---- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/appimage.yml b/.github/workflows/appimage.yml index 6267aa792..a35029acc 100644 --- a/.github/workflows/appimage.yml +++ b/.github/workflows/appimage.yml @@ -168,7 +168,7 @@ jobs: cryptomator-*.asc if-no-files-found: error - name: Publish AppImage on GitHub Releases - if: startsWith(github.ref, 'refs/tags/') && github.event_name == 'published' + if: startsWith(github.ref, 'refs/tags/') && github.event.action == 'published' uses: softprops/action-gh-release@v1 with: fail_on_unmatched_files: true diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index 0512c25f8..dd7d2adf0 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -142,7 +142,6 @@ jobs: - name: Publish on PPA if: inputs.dput run: dput ppa:sebastian-stenzel/cryptomator-beta cryptomator_*_source.changes - # If ref is a tag, also upload to GitHub Releases: - name: Publish Debian package on GitHub Releases if: startsWith(github.ref, 'refs/tags/') && inputs.dput diff --git a/.github/workflows/mac-dmg.yml b/.github/workflows/mac-dmg.yml index c4edec9b4..b87d8c79a 100644 --- a/.github/workflows/mac-dmg.yml +++ b/.github/workflows/mac-dmg.yml @@ -258,7 +258,7 @@ jobs: Cryptomator-*.asc if-no-files-found: error - name: Publish dmg on GitHub Releases - if: startsWith(github.ref, 'refs/tags/') && github.event_name == 'published' + if: startsWith(github.ref, 'refs/tags/') && github.event.action == 'published' uses: softprops/action-gh-release@v1 with: fail_on_unmatched_files: true diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 260730127..d3720c76b 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -255,7 +255,7 @@ jobs: Cryptomator-*.asc if-no-files-found: error - name: Publish .msi on GitHub Releases - if: startsWith(github.ref, 'refs/tags/') && github.event_name == 'published' + if: startsWith(github.ref, 'refs/tags/') && github.event.action == 'published' uses: softprops/action-gh-release@v1 with: fail_on_unmatched_files: true @@ -366,7 +366,7 @@ jobs: Cryptomator-*.asc if-no-files-found: error - name: Publish .msi on GitHub Releases - if: startsWith(github.ref, 'refs/tags/') && github.event_name == 'published' + if: startsWith(github.ref, 'refs/tags/') && github.event.action == 'published' uses: softprops/action-gh-release@v1 with: fail_on_unmatched_files: true @@ -377,7 +377,7 @@ jobs: allowlist: name: Anti Virus Allowlisting - if: startsWith(github.ref, 'refs/tags/') && github.event_name == 'published' + if: startsWith(github.ref, 'refs/tags/') && github.event.action == 'published' runs-on: ubuntu-latest needs: [build-msi, build-exe] steps: @@ -416,7 +416,7 @@ jobs: local-dir: files/ notify-winget: name: Notify for winget-release - if: startsWith(github.ref, 'refs/tags/') && github.event_name == 'published' && needs.get-version.outputs.versionType == 'stable' + if: startsWith(github.ref, 'refs/tags/') && github.event.action == 'published' && needs.get-version.outputs.versionType == 'stable' needs: [build-msi, get-version] runs-on: ubuntu-latest steps: From fa63f3ca6702e35f0c08461fc941cb09e7bdf11a Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Thu, 22 Feb 2024 12:21:00 +0100 Subject: [PATCH 02/21] Reset develop to SNAPSHOT version --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index af81d1f78..49c6126e2 100644 --- a/pom.xml +++ b/pom.xml @@ -3,7 +3,7 @@ 4.0.0 org.cryptomator cryptomator - 1.12.3 + 1.13.0-SNAPSHOT Cryptomator Desktop App From 8412871090098f09fcefaa8356ac760d443ec749 Mon Sep 17 00:00:00 2001 From: Armin Schrenk Date: Thu, 22 Feb 2024 12:23:43 +0100 Subject: [PATCH 03/21] apply proper formatting and state to error dialog --- .../cryptomator/ui/error/ErrorController.java | 3 + src/main/resources/fxml/error.fxml | 139 ++++++++++-------- 2 files changed, 78 insertions(+), 64 deletions(-) diff --git a/src/main/java/org/cryptomator/ui/error/ErrorController.java b/src/main/java/org/cryptomator/ui/error/ErrorController.java index 45c940bcb..5b7dd9a60 100644 --- a/src/main/java/org/cryptomator/ui/error/ErrorController.java +++ b/src/main/java/org/cryptomator/ui/error/ErrorController.java @@ -75,6 +75,7 @@ public class ErrorController implements FxController { private final BooleanExpression errorSolutionFound = matchingErrorDiscussion.isNotNull(); private final BooleanProperty isLoadingHttpResponse = new SimpleBooleanProperty(); private final BooleanProperty askedForLookupDatabasePermission = new SimpleBooleanProperty(); + private final boolean formerSceneWasResizable; @Inject ErrorController(Application application, @Named("stackTrace") String stackTrace, ErrorCode errorCode, @Nullable Scene previousScene, Stage window, Environment environment, ExecutorService executorService) { @@ -85,12 +86,14 @@ public class ErrorController implements FxController { this.window = window; this.environment = environment; this.executorService = executorService; + this.formerSceneWasResizable = window.isResizable(); } @FXML public void back() { if (previousScene != null) { window.setScene(previousScene); + window.setResizable(formerSceneWasResizable); } } diff --git a/src/main/resources/fxml/error.fxml b/src/main/resources/fxml/error.fxml index aa0703d0c..91f7fff3e 100644 --- a/src/main/resources/fxml/error.fxml +++ b/src/main/resources/fxml/error.fxml @@ -9,86 +9,97 @@ + - + spacing="12"> - - - - - - - - - -