From 4761c58265d7d6ff633c8d92a13a5af0f4a53af0 Mon Sep 17 00:00:00 2001 From: Dhruv Bajpai <123343459+dhruvbajpai29@users.noreply.github.com> Date: Tue, 16 Sep 2025 17:49:59 +0530 Subject: [PATCH] specify JVM crash log path (#3951) Add jvm option `-XX:+ErrorFile=...` with a clear, but with high possibility not-existing path to use fallback path. --- .github/workflows/appimage.yml | 1 + .github/workflows/mac-dmg.yml | 1 + .github/workflows/win-exe.yml | 1 + dist/linux/appimage/build.sh | 1 + dist/mac/dmg/build.sh | 1 + dist/win/build.ps1 | 1 + 6 files changed, 6 insertions(+) diff --git a/.github/workflows/appimage.yml b/.github/workflows/appimage.yml index 26111c518..c088ebd58 100644 --- a/.github/workflows/appimage.yml +++ b/.github/workflows/appimage.yml @@ -133,6 +133,7 @@ jobs: --java-options "-Dcryptomator.integrationsLinux.trayIconsDir=\"@{appdir}/usr/share/icons/hicolor/symbolic/apps\"" --java-options "-Dcryptomator.buildNumber=\"appimage-${{ needs.get-version.outputs.revNum }}\"" --java-options "-Dcryptomator.networking.truststore.p12Path=\"/etc/cryptomator/certs.p12\"" + --java-options "-XX:ErrorFile=/cryptomator/cryptomator_crash.log" --resource-dir dist/linux/resources - name: Patch Cryptomator.AppDir run: | diff --git a/.github/workflows/mac-dmg.yml b/.github/workflows/mac-dmg.yml index 29b4a4b0c..94c320018 100644 --- a/.github/workflows/mac-dmg.yml +++ b/.github/workflows/mac-dmg.yml @@ -136,6 +136,7 @@ jobs: --java-options "-Dcryptomator.mountPointsDir=\"@{userhome}/Library/Application Support/Cryptomator/mnt\"" --java-options "-Dcryptomator.showTrayIcon=true" --java-options "-Dcryptomator.buildNumber=\"dmg-${{ needs.get-version.outputs.revNum }}\"" + --java-options "-XX:ErrorFile=/cryptomator/cryptomator_crash.log" --mac-package-identifier org.cryptomator --resource-dir dist/mac/resources - name: Patch Cryptomator.app diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 4b8f4d2d4..1d3de4f3a 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -163,6 +163,7 @@ jobs: --java-options "-Dcryptomator.integrationsWin.keychainPaths=\"@{appdata}/Cryptomator/keychain.json;@{userhome}/AppData/Roaming/Cryptomator/keychain.json\"" --java-options "-Dcryptomator.integrationsWin.windowsHelloKeychainPaths=\"@{appdata}/Cryptomator/windowsHelloKeychain.json\"" --java-options "-Dcryptomator.disableUpdateCheck=false" + --java-options "-XX:ErrorFile=C:/cryptomator/cryptomator_crash.log" --resource-dir dist/win/resources --icon dist/win/resources/Cryptomator.ico --add-launcher "Cryptomator (Debug)=dist/win/debug-launcher.properties" diff --git a/dist/linux/appimage/build.sh b/dist/linux/appimage/build.sh index 8d45739cb..f5edd2df5 100755 --- a/dist/linux/appimage/build.sh +++ b/dist/linux/appimage/build.sh @@ -98,6 +98,7 @@ ${JAVA_HOME}/bin/jpackage \ --java-options "-Dcryptomator.integrationsLinux.trayIconsDir=\"@{appdir}/usr/share/icons/hicolor/symbolic/apps\"" \ --java-options "-Dcryptomator.buildNumber=\"appimage-${REVISION_NO}\"" \ --java-options "-Dcryptomator.networking.truststore.p12Path=\"/etc/cryptomator/certs.p12\"" \ + --java-options "-XX:ErrorFile=/cryptomator/cryptomator_crash.log" \ --resource-dir ../resources # transform AppDir diff --git a/dist/mac/dmg/build.sh b/dist/mac/dmg/build.sh index c018c2d33..bf63505a5 100755 --- a/dist/mac/dmg/build.sh +++ b/dist/mac/dmg/build.sh @@ -115,6 +115,7 @@ ${JAVA_HOME}/bin/jpackage \ --java-options "-Dsun.java2d.metal=true" \ --java-options "-Dcryptomator.appVersion=\"${VERSION_NO}\"" \ --java-options "-Dcryptomator.logDir=\"@{userhome}/Library/Logs/${APP_NAME}\"" \ + --java-options "-XX:ErrorFile=/cryptomator/cryptomator_crash.log" \ --java-options "-Dcryptomator.pluginDir=\"@{userhome}/Library/Application Support/${APP_NAME}/Plugins\"" \ --java-options "-Dcryptomator.settingsPath=\"@{userhome}/Library/Application Support/${APP_NAME}/settings.json\"" \ --java-options "-Dcryptomator.ipcSocketPath=\"@{userhome}/Library/Application Support/${APP_NAME}/ipc.socket\"" \ diff --git a/dist/win/build.ps1 b/dist/win/build.ps1 index a5bbfa03f..841c1b2b6 100644 --- a/dist/win/build.ps1 +++ b/dist/win/build.ps1 @@ -154,6 +154,7 @@ $javaOptions = @( "--java-options", "-Dfile.encoding=`"utf-8`"" "--java-options", "-Djava.net.useSystemProxies=true" "--java-options", "-Dcryptomator.logDir=`"@{localappdata}/$AppName`"" +"--java-options", "-XX:ErrorFile=`"C:/cryptomator/cryptomator_crash.log`"" "--java-options", "-Dcryptomator.pluginDir=`"@{appdata}/$AppName/Plugins`"" "--java-options", "-Dcryptomator.settingsPath=`"@{appdata}/$AppName/settings.json;@{userhome}/AppData/Roaming/$AppName/settings.json`"" "--java-options", "-Dcryptomator.ipcSocketPath=`"@{localappdata}/$AppName/ipc.socket`""