Apply suggestions from code review

Co-authored-by: Sebastian Stenzel <overheadhunter@users.noreply.github.com>
This commit is contained in:
Armin Schrenk
2022-04-20 10:31:25 +02:00
parent 51d715caa1
commit 4d1d6f449e
9 changed files with 11 additions and 24 deletions

View File

@@ -102,7 +102,7 @@ jobs:
env:
VERSION_NO: ${{ steps.versions.outputs.semVerNum }}
REVISION_NO: ${{ steps.versions.outputs.revNum }}
- name: Generate license
- name: Generate license for dmg
run: >
mvn -B license:add-third-party
-Dlicense.thirdPartyFilename=license.rtf
@@ -111,7 +111,7 @@ jobs:
-Dlicense.includeScopes=compile
-Dlicense.excludedGroups=^org\.cryptomator
-Dlicense.failOnMissing=true
-Dlicense.licenseMergesUrl=dist/mac/dmg/resources/licenseMerges.xml
-Dlicense.licenseMergesUrl=license/merges.xml
- name: Install codesign certificate
run: |
# create variables

View File

@@ -115,7 +115,7 @@ jobs:
timestampUrl: 'http://timestamp.digicert.com'
folder: appdir/Cryptomator
recursive: true
- name: Generate license
- name: Generate license for MSI
run: >
mvn -B license:add-third-party
-Dlicense.thirdPartyFilename=license.rtf
@@ -124,7 +124,7 @@ jobs:
-Dlicense.includeScopes=compile
-Dlicense.excludedGroups=^org\.cryptomator
-Dlicense.failOnMissing=true
-Dlicense.licenseMergesUrl=dist/win/resources/license/licenseMerges.xml
-Dlicense.licenseMergesUrl=license/merges.xml
- name: Create MSI
run: >
${JAVA_HOME}/bin/jpackage
@@ -205,7 +205,7 @@ jobs:
distribution: 'temurin'
java-version: ${{ env.JAVA_VERSION }}
cache: 'maven'
- name: Generate license
- name: Generate license for exe
run: >
mvn -B license:add-third-party
-Dlicense.thirdPartyFilename=license.rtf
@@ -214,7 +214,7 @@ jobs:
-Dlicense.includeScopes=compile
-Dlicense.excludedGroups=^org\.cryptomator
-Dlicense.failOnMissing=true
-Dlicense.licenseMergesUrl=dist/win/resources/license/licenseMerges.xml
-Dlicense.licenseMergesUrl=license/merges.xml
- name: Download WinFsp
run:
curl --output dist/win/bundle/resources/winfsp.msi -L ${{ env.WINFSP_MSI }}