diff --git a/src/main/java/org/cryptomator/ui/dialogs/Dialogs.java b/src/main/java/org/cryptomator/ui/dialogs/Dialogs.java index 509c0d329..7adaaf2c7 100644 --- a/src/main/java/org/cryptomator/ui/dialogs/Dialogs.java +++ b/src/main/java/org/cryptomator/ui/dialogs/Dialogs.java @@ -7,12 +7,13 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import javax.inject.Inject; +import javax.inject.Singleton; import javafx.collections.ObservableList; import javafx.stage.Stage; import java.util.ResourceBundle; import java.util.function.Consumer; - +@Singleton public class Dialogs { private final ResourceBundle resourceBundle; diff --git a/src/main/java/org/cryptomator/ui/fxapp/FxApplicationModule.java b/src/main/java/org/cryptomator/ui/fxapp/FxApplicationModule.java index 3098d471d..af98e284c 100644 --- a/src/main/java/org/cryptomator/ui/fxapp/FxApplicationModule.java +++ b/src/main/java/org/cryptomator/ui/fxapp/FxApplicationModule.java @@ -7,7 +7,6 @@ package org.cryptomator.ui.fxapp; import dagger.Module; import dagger.Provides; -import org.cryptomator.ui.dialogs.Dialogs; import org.cryptomator.ui.error.ErrorComponent; import org.cryptomator.ui.health.HealthCheckComponent; import org.cryptomator.ui.lock.LockComponent; @@ -23,7 +22,6 @@ import org.cryptomator.ui.vaultoptions.VaultOptionsComponent; import javafx.scene.image.Image; import java.io.IOException; import java.io.InputStream; -import java.util.ResourceBundle; @Module(includes = {UpdateCheckerModule.class}, subcomponents = {TrayMenuComponent.class, // MainWindowComponent.class, // @@ -68,10 +66,4 @@ abstract class FxApplicationModule { return builder.build(); } - @Provides - @FxApplicationScoped - static Dialogs provideDialogs(ResourceBundle resourceBundle) { - return new Dialogs(resourceBundle); - } - } \ No newline at end of file diff --git a/src/main/java/org/cryptomator/ui/fxapp/FxApplicationWindows.java b/src/main/java/org/cryptomator/ui/fxapp/FxApplicationWindows.java index 8dd03b36c..54acf62a3 100644 --- a/src/main/java/org/cryptomator/ui/fxapp/FxApplicationWindows.java +++ b/src/main/java/org/cryptomator/ui/fxapp/FxApplicationWindows.java @@ -23,7 +23,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import javax.inject.Inject; -import javax.inject.Provider; import javafx.application.Platform; import javafx.collections.ListChangeListener; import javafx.collections.transformation.FilteredList; @@ -71,7 +70,7 @@ public class FxApplicationWindows { VaultOptionsComponent.Factory vaultOptionsWindow, // ShareVaultComponent.Factory shareVaultWindow, // ExecutorService executor, // - Provider dialogsProvider) { + Dialogs dialogs) { this.primaryStage = primaryStage; this.trayIntegration = trayIntegration; this.mainWindow = mainWindow; @@ -85,7 +84,7 @@ public class FxApplicationWindows { this.vaultOptionsWindow = vaultOptionsWindow; this.shareVaultWindow = shareVaultWindow; this.visibleWindows = Window.getWindows().filtered(Window::isShowing); - this.dialogs = dialogsProvider.get(); + this.dialogs = dialogs; } public void initialize() { diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailMissingVaultController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailMissingVaultController.java index 4831cb1a3..6f57a0d17 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailMissingVaultController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailMissingVaultController.java @@ -6,7 +6,6 @@ import org.cryptomator.ui.common.FxController; import org.cryptomator.ui.dialogs.Dialogs; import javax.inject.Inject; -import javax.inject.Provider; import javafx.beans.property.ObjectProperty; import javafx.collections.ObservableList; import javafx.fxml.FXML; @@ -31,12 +30,12 @@ public class VaultDetailMissingVaultController implements FxController { ObservableList vaults, // ResourceBundle resourceBundle, // @MainWindow Stage window, // - Provider dialogsProvider) { + Dialogs dialogs) { this.vault = vault; this.vaults = vaults; this.resourceBundle = resourceBundle; this.window = window; - this.dialogs = dialogsProvider.get(); + this.dialogs = dialogs; } @FXML diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailUnknownErrorController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailUnknownErrorController.java index 7da04f7cc..503e50ffd 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailUnknownErrorController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultDetailUnknownErrorController.java @@ -8,7 +8,6 @@ import org.cryptomator.ui.fxapp.FxApplicationWindows; import javax.inject.Inject; import javax.inject.Named; -import javax.inject.Provider; import javafx.beans.property.ObjectProperty; import javafx.collections.ObservableList; import javafx.fxml.FXML; @@ -30,13 +29,13 @@ public class VaultDetailUnknownErrorController implements FxController { ObservableList vaults, // FxApplicationWindows appWindows, // @Named("errorWindow") Stage errorWindow, // - Provider dialogsProvider) { + Dialogs dialogs) { this.mainWindow = mainWindow; this.vault = vault; this.vaults = vaults; this.appWindows = appWindows; this.errorWindow = errorWindow; - this.dialogs = dialogsProvider.get(); + this.dialogs = dialogs; } @FXML diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java index a63efae73..97c03194f 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultListContextMenuController.java @@ -11,7 +11,6 @@ import org.cryptomator.ui.vaultoptions.SelectedVaultOptionsTab; import org.cryptomator.ui.vaultoptions.VaultOptionsComponent; import javax.inject.Inject; -import javax.inject.Provider; import javafx.beans.property.ObjectProperty; import javafx.beans.property.ReadOnlyObjectProperty; import javafx.beans.value.ObservableValue; @@ -52,7 +51,7 @@ public class VaultListContextMenuController implements FxController { VaultService vaultService, // KeychainManager keychain, // VaultOptionsComponent.Factory vaultOptionsWindow, // - Provider dialogsProvider) { + Dialogs dialogs) { this.selectedVault = selectedVault; this.vaults = vaults; this.mainWindow = mainWindow; @@ -60,7 +59,7 @@ public class VaultListContextMenuController implements FxController { this.vaultService = vaultService; this.keychain = keychain; this.vaultOptionsWindow = vaultOptionsWindow; - this.dialogs = dialogsProvider.get(); + this.dialogs = dialogs; this.selectedVaultState = selectedVault.flatMap(Vault::stateProperty).orElse(null); this.selectedVaultPassphraseStored = selectedVault.map(this::isPasswordStored).orElse(false); diff --git a/src/main/java/org/cryptomator/ui/mainwindow/VaultListController.java b/src/main/java/org/cryptomator/ui/mainwindow/VaultListController.java index 4c8893278..1919d66ac 100644 --- a/src/main/java/org/cryptomator/ui/mainwindow/VaultListController.java +++ b/src/main/java/org/cryptomator/ui/mainwindow/VaultListController.java @@ -16,7 +16,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import javax.inject.Inject; -import javax.inject.Provider; import javafx.beans.binding.Bindings; import javafx.beans.binding.BooleanBinding; import javafx.beans.property.BooleanProperty; @@ -92,7 +91,7 @@ public class VaultListController implements FxController { ResourceBundle resourceBundle, // FxApplicationWindows appWindows, // Settings settings, // - Provider dialogsProvider) { + Dialogs dialogs) { this.mainWindow = mainWindow; this.vaults = vaults; this.selectedVault = selectedVault; @@ -102,7 +101,7 @@ public class VaultListController implements FxController { this.vaultListManager = vaultListManager; this.resourceBundle = resourceBundle; this.appWindows = appWindows; - this.dialogs = dialogsProvider.get(); + this.dialogs = dialogs; this.emptyVaultList = Bindings.isEmpty(vaults); diff --git a/src/main/java/org/cryptomator/ui/preferences/SupporterCertificateController.java b/src/main/java/org/cryptomator/ui/preferences/SupporterCertificateController.java index ec7676150..b36d7454e 100644 --- a/src/main/java/org/cryptomator/ui/preferences/SupporterCertificateController.java +++ b/src/main/java/org/cryptomator/ui/preferences/SupporterCertificateController.java @@ -8,7 +8,6 @@ import org.cryptomator.ui.common.FxController; import org.cryptomator.ui.dialogs.Dialogs; import javax.inject.Inject; -import javax.inject.Provider; import javafx.application.Application; import javafx.beans.value.ObservableValue; import javafx.fxml.FXML; @@ -38,12 +37,12 @@ public class SupporterCertificateController implements FxController { @PreferencesWindow Stage window, // LicenseHolder licenseHolder, // Settings settings, // - Provider dialogsProvider) { + Dialogs dialogs) { this.application = application; this.window = window; this.licenseHolder = licenseHolder; this.settings = settings; - this.dialogs = dialogsProvider.get(); + this.dialogs = dialogs; } @FXML