diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultModule.java b/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultModule.java index 4a9dba7ad..43ec4c200 100644 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultModule.java +++ b/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultModule.java @@ -90,13 +90,6 @@ public abstract class AddVaultModule { // ------------------ - @Provides - @FxmlScene(FxmlFile.ADDVAULT_WELCOME) - @AddVaultWizardScoped - static Scene provideWelcomeScene(@AddVaultWizardWindow FxmlLoaderFactory fxmlLoaders) { - return fxmlLoaders.createScene(FxmlFile.ADDVAULT_WELCOME); - } - @Provides @FxmlScene(FxmlFile.ADDVAULT_EXISTING) @AddVaultWizardScoped @@ -148,11 +141,6 @@ public abstract class AddVaultModule { // ------------------ - @Binds - @IntoMap - @FxControllerKey(AddVaultWelcomeController.class) - abstract FxController bindWelcomeController(AddVaultWelcomeController controller); - @Binds @IntoMap @FxControllerKey(ChooseExistingVaultController.class) diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultWelcomeController.java b/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultWelcomeController.java deleted file mode 100644 index 3c13aeb75..000000000 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultWelcomeController.java +++ /dev/null @@ -1,38 +0,0 @@ -package org.cryptomator.ui.addvaultwizard; - -import dagger.Lazy; -import org.cryptomator.ui.common.FxController; -import org.cryptomator.ui.common.FxmlFile; -import org.cryptomator.ui.common.FxmlScene; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import javax.inject.Inject; -import javafx.scene.Scene; -import javafx.stage.Stage; - -@AddVaultWizardScoped -public class AddVaultWelcomeController implements FxController { - - private static final Logger LOG = LoggerFactory.getLogger(AddVaultWelcomeController.class); - private final Stage window; - private final Lazy chooseExistingVaultScene; - private final Lazy createNewVaultScene; - - @Inject - AddVaultWelcomeController(@AddVaultWizardWindow Stage window, @FxmlScene(FxmlFile.ADDVAULT_EXISTING) Lazy chooseExistingVaultScene, @FxmlScene(FxmlFile.ADDVAULT_NEW_NAME) Lazy createNewVaultScene) { - this.window = window; - this.chooseExistingVaultScene = chooseExistingVaultScene; - this.createNewVaultScene = createNewVaultScene; - } - - public void createNewVault() { - LOG.debug("AddVaultWelcomeController.createNewVault()"); - window.setScene(createNewVaultScene.get()); - } - - public void chooseExistingVault() { - LOG.debug("AddVaultWelcomeController.chooseExistingVault()"); - window.setScene(chooseExistingVaultScene.get()); - } -} diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultWizardComponent.java b/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultWizardComponent.java index 9f4c1e007..3c6e684ee 100644 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultWizardComponent.java +++ b/src/main/java/org/cryptomator/ui/addvaultwizard/AddVaultWizardComponent.java @@ -20,20 +20,11 @@ public interface AddVaultWizardComponent { @AddVaultWizardWindow Stage window(); - @FxmlScene(FxmlFile.ADDVAULT_WELCOME) - Lazy scene(); @FxmlScene(FxmlFile.ADDVAULT_NEW_NAME) Lazy sceneNew(); @FxmlScene(FxmlFile.ADDVAULT_EXISTING) Lazy sceneExisting(); - default void showAddVaultWizard() { - Stage stage = window(); - stage.setScene(scene().get()); - stage.sizeToScene(); - stage.show(); - } - default void showAddNewVaultWizard() { Stage stage = window(); stage.setScene(sceneNew().get()); diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java b/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java index fe4ac3bd1..be9ea15c7 100644 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java +++ b/src/main/java/org/cryptomator/ui/addvaultwizard/ChooseExistingVaultController.java @@ -35,7 +35,6 @@ public class ChooseExistingVaultController implements FxController { private static final Logger LOG = LoggerFactory.getLogger(ChooseExistingVaultController.class); private final Stage window; - private final Lazy welcomeScene; private final Lazy successScene; private final FxApplicationWindows appWindows; private final ObjectProperty vaultPath; @@ -45,9 +44,15 @@ public class ChooseExistingVaultController implements FxController { private final ObservableValue screenshot; @Inject - ChooseExistingVaultController(@AddVaultWizardWindow Stage window, @FxmlScene(FxmlFile.ADDVAULT_WELCOME) Lazy welcomeScene, @FxmlScene(FxmlFile.ADDVAULT_SUCCESS) Lazy successScene, FxApplicationWindows appWindows, ObjectProperty vaultPath, @AddVaultWizardWindow ObjectProperty vault, VaultListManager vaultListManager, ResourceBundle resourceBundle, FxApplicationStyle applicationStyle) { + ChooseExistingVaultController(@AddVaultWizardWindow Stage window, // + @FxmlScene(FxmlFile.ADDVAULT_SUCCESS) Lazy successScene, // + FxApplicationWindows appWindows, // + ObjectProperty vaultPath, // + @AddVaultWizardWindow ObjectProperty vault, // + VaultListManager vaultListManager, // + ResourceBundle resourceBundle, // + FxApplicationStyle applicationStyle) { this.window = window; - this.welcomeScene = welcomeScene; this.successScene = successScene; this.appWindows = appWindows; this.vaultPath = vaultPath; @@ -70,11 +75,6 @@ public class ChooseExistingVaultController implements FxController { return new Image((Objects.requireNonNull(getClass().getResource(imageResourcePath)).toString())); } - @FXML - public void back() { - window.setScene(welcomeScene.get()); - } - @FXML public void chooseFileAndNext() { FileChooser fileChooser = new FileChooser(); diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultNameController.java b/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultNameController.java index 2ca73e172..18e0278a2 100644 --- a/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultNameController.java +++ b/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultNameController.java @@ -27,16 +27,17 @@ public class CreateNewVaultNameController implements FxController { public TextField textField; private final Stage window; - private final Lazy welcomeScene; private final Lazy chooseLocationScene; private final ObjectProperty vaultPath; private final StringProperty vaultName; private final BooleanBinding validVaultName; @Inject - CreateNewVaultNameController(@AddVaultWizardWindow Stage window, @FxmlScene(FxmlFile.ADDVAULT_WELCOME) Lazy welcomeScene, @FxmlScene(FxmlFile.ADDVAULT_NEW_LOCATION) Lazy chooseLocationScene, ObjectProperty vaultPath, @Named("vaultName") StringProperty vaultName, ResourceBundle resourceBundle) { + CreateNewVaultNameController(@AddVaultWizardWindow Stage window, // + @FxmlScene(FxmlFile.ADDVAULT_NEW_LOCATION) Lazy chooseLocationScene, // + ObjectProperty vaultPath, // + @Named("vaultName") StringProperty vaultName) { this.window = window; - this.welcomeScene = welcomeScene; this.chooseLocationScene = chooseLocationScene; this.vaultPath = vaultPath; this.vaultName = vaultName; @@ -58,11 +59,6 @@ public class CreateNewVaultNameController implements FxController { } } - @FXML - public void back() { - window.setScene(welcomeScene.get()); - } - @FXML public void next() { window.setScene(chooseLocationScene.get()); diff --git a/src/main/java/org/cryptomator/ui/common/FxmlFile.java b/src/main/java/org/cryptomator/ui/common/FxmlFile.java index cefd424ff..678795662 100644 --- a/src/main/java/org/cryptomator/ui/common/FxmlFile.java +++ b/src/main/java/org/cryptomator/ui/common/FxmlFile.java @@ -8,7 +8,6 @@ public enum FxmlFile { ADDVAULT_NEW_PASSWORD("/fxml/addvault_new_password.fxml"), // ADDVAULT_NEW_RECOVERYKEY("/fxml/addvault_new_recoverykey.fxml"), // ADDVAULT_SUCCESS("/fxml/addvault_success.fxml"), // - ADDVAULT_WELCOME("/fxml/addvault_welcome.fxml"), // CHANGEPASSWORD("/fxml/changepassword.fxml"), // CONVERTVAULT_HUBTOPASSWORD_START("/fxml/convertvault_hubtopassword_start.fxml"), // CONVERTVAULT_HUBTOPASSWORD_CONVERT("/fxml/convertvault_hubtopassword_convert.fxml"), // diff --git a/src/main/resources/fxml/addvault_existing.fxml b/src/main/resources/fxml/addvault_existing.fxml index c46ad6355..200eae4f9 100644 --- a/src/main/resources/fxml/addvault_existing.fxml +++ b/src/main/resources/fxml/addvault_existing.fxml @@ -24,9 +24,8 @@ - + - - - - - - -