From 6b7324723eda56b283198f077a21e4f7f4195f50 Mon Sep 17 00:00:00 2001 From: Sebastian Stenzel Date: Tue, 4 Nov 2025 22:07:05 +0100 Subject: [PATCH] apply more suggestions from code review --- src/main/java/org/cryptomator/ui/fxapp/UpdateChecker.java | 2 +- .../ui/preferences/UpdatesPreferencesController.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/cryptomator/ui/fxapp/UpdateChecker.java b/src/main/java/org/cryptomator/ui/fxapp/UpdateChecker.java index 99bb75a34..b759e9df8 100644 --- a/src/main/java/org/cryptomator/ui/fxapp/UpdateChecker.java +++ b/src/main/java/org/cryptomator/ui/fxapp/UpdateChecker.java @@ -85,9 +85,9 @@ public class UpdateChecker extends ScheduledService> { protected void succeeded() { var updateInfo = getValue(); super.succeeded(); // this will nil the value property! + lastSuccessfulUpdateCheck.set(Instant.now()); if (updateInfo != null) { LOG.info("Current version: {}, latest version: {}", getCurrentVersion(), updateInfo.version()); - lastSuccessfulUpdateCheck.set(Instant.now()); } } diff --git a/src/main/java/org/cryptomator/ui/preferences/UpdatesPreferencesController.java b/src/main/java/org/cryptomator/ui/preferences/UpdatesPreferencesController.java index 58bce5d1d..11ad41e7b 100644 --- a/src/main/java/org/cryptomator/ui/preferences/UpdatesPreferencesController.java +++ b/src/main/java/org/cryptomator/ui/preferences/UpdatesPreferencesController.java @@ -60,7 +60,7 @@ public class UpdatesPreferencesController implements FxController { public CheckBox checkForUpdatesCheckbox; @Inject - UpdatesPreferencesController(Application application, Environment environment, ResourceBundle resourceBundle, Settings settings, UpdateChecker updateChecker, FallbackUpdateMechanism fallbackUpdateMechanism) { + UpdatesPreferencesController(Application application, Environment environment, ResourceBundle resourceBundle, Settings settings, UpdateChecker updateChecker) { this.application = application; this.environment = environment; this.resourceBundle = resourceBundle;