some Windows WebDAV compatibility fixes

2026-09-20 23:14:39 +00:00 · 2016-02-29 12:25:24 +01:00
parent be4dab2773
commit a6c99c273e
6 changed files with 200 additions and 5 deletions
@@ -0,0 +1,49 @@
+/*******************************************************************************
+ * Copyright (c) 2016 Sebastian Stenzel and others.
+ * This file is licensed under the terms of the MIT license.
+ * See the LICENSE.txt file for more info.
+ *
+ * Contributors:
+ *     Sebastian Stenzel - initial API and implementation
+ *******************************************************************************/
+package org.cryptomator.frontend.webdav;
+
+import java.io.IOException;
+
+import javax.servlet.Servlet;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.eclipse.jetty.servlet.ServletHolder;
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+
+public class WindowsCompatibilityServletTest {
+	
+	@Test
+	public void testFactory() throws ServletException {
+		ServletHolder[] holders = WindowsCompatibilityServlet.createServletContextHandler().getServletHandler().getServlets();
+		Assert.assertEquals(1, holders.length);
+		ServletHolder holder = holders[0];
+		
+		Servlet servlet = holder.getServlet();
+		Assert.assertTrue(servlet instanceof WindowsCompatibilityServlet);
+	}
+	
+	@Test
+	public void testResponse() throws IOException, ServletException {
+		final WindowsCompatibilityServlet servlet = new WindowsCompatibilityServlet();
+		final HttpServletRequest request = Mockito.mock(HttpServletRequest.class);
+		final HttpServletResponse response = Mockito.mock(HttpServletResponse.class);
+		
+		servlet.doOptions(request, response);
+		
+		Mockito.verify(response).addHeader("MS-Author-Via", "DAV");
+		Mockito.verify(response).addHeader("DAV", "1, 2");
+		Mockito.verify(response).setStatus(204);
+	}
+
+}
@@ -0,0 +1,70 @@
+/*******************************************************************************
+ * Copyright (c) 2016 Sebastian Stenzel and others.
+ * This file is licensed under the terms of the MIT license.
+ * See the LICENSE.txt file for more info.
+ *
+ * Contributors:
+ *     Sebastian Stenzel - initial API and implementation
+ *******************************************************************************/
+package org.cryptomator.frontend.webdav.filters;
+
+import java.io.IOException;
+import java.net.InetAddress;
+import java.util.Arrays;
+
+import javax.servlet.FilterChain;
+import javax.servlet.ServletException;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import org.junit.Assert;
+import org.junit.Assume;
+import org.junit.Before;
+import org.junit.experimental.theories.DataPoints;
+import org.junit.experimental.theories.Theories;
+import org.junit.experimental.theories.Theory;
+import org.junit.runner.RunWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Mockito;
+
+@RunWith(Theories.class)
+public class LoopbackFilterTest {
+	
+	@DataPoints
+	public static final Iterable<String> HOST_NAMES = Arrays.asList("127.0.0.1", "0::1", "1.2.3.4", "google.com");
+
+	private LoopbackFilter filter;
+	private FilterChain chain;
+	private HttpServletRequest request;
+	private HttpServletResponse response;
+
+	@Before
+	public void setup() {
+		filter = new LoopbackFilter();
+		chain = Mockito.mock(FilterChain.class);
+		request = Mockito.mock(HttpServletRequest.class);
+		response = Mockito.mock(HttpServletResponse.class);
+	}
+	
+	@Theory
+	public void testWithLoopbackAddress(String hostname) throws IOException, ServletException {
+		Assume.assumeTrue(InetAddress.getByName(hostname).isLoopbackAddress());
+		Mockito.when(request.getRemoteAddr()).thenReturn(hostname);
+		
+		filter.doFilter(request, response, chain);
+		Mockito.verify(chain).doFilter(request, response);
+	}
+	
+	@Theory
+	public void testWithExternalAddress(String hostname) throws IOException, ServletException {
+		Assume.assumeFalse(InetAddress.getByName(hostname).isLoopbackAddress());
+		Mockito.when(request.getRemoteAddr()).thenReturn(hostname);
+		
+		filter.doFilter(request, response, chain);
+
+		ArgumentCaptor<Integer> statusCode = ArgumentCaptor.forClass(Integer.class);
+		Mockito.verify(response).sendError(statusCode.capture(), Mockito.anyString());
+		Assert.assertEquals(405, statusCode.getValue().intValue());
+	}
+
+}