From ac43efe14989aa1e1e1e92a3ab43683601133dc8 Mon Sep 17 00:00:00 2001
From: Armin Schrenk <armin.schrenk@skymatic.de>
Date: Wed, 8 Feb 2023 11:33:41 +0100
Subject: [PATCH] change UI to be not so clunky: * only use question mark icon
 * use tooltip at icon instead of explicit label * icon is the hyperlink

---
 .../ui/controls/FontAwesome5Icon.java         |  1 +
 .../resources/fxml/preferences_volume.fxml    | 20 +++++++++----------
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/src/main/java/org/cryptomator/ui/controls/FontAwesome5Icon.java b/src/main/java/org/cryptomator/ui/controls/FontAwesome5Icon.java
index 997bfa41f..60f37719b 100644
--- a/src/main/java/org/cryptomator/ui/controls/FontAwesome5Icon.java
+++ b/src/main/java/org/cryptomator/ui/controls/FontAwesome5Icon.java
@@ -42,6 +42,7 @@ public enum FontAwesome5Icon {
 	PLUS("\uF067"), //
 	PRINT("\uF02F"), //
 	QUESTION("\uF128"), //
+	QUESTION_CIRCLE("\uf059"), //
 	REDO("\uF01E"), //
 	SEARCH("\uF002"), //
 	SPINNER("\uF110"), //
diff --git a/src/main/resources/fxml/preferences_volume.fxml b/src/main/resources/fxml/preferences_volume.fxml
index ed41a746b..23aff9acf 100644
--- a/src/main/resources/fxml/preferences_volume.fxml
+++ b/src/main/resources/fxml/preferences_volume.fxml
@@ -10,6 +10,7 @@
 <?import javafx.scene.control.Separator?>
 <?import javafx.scene.layout.HBox?>
 <?import javafx.scene.layout.VBox?>
+<?import javafx.scene.control.Tooltip?>
 <VBox xmlns:fx="http://javafx.com/fxml"
 	  xmlns="http://javafx.com/javafx"
 	  fx:controller="org.cryptomator.ui.preferences.VolumePreferencesController"
@@ -21,6 +22,14 @@
 		<HBox spacing="12" alignment="CENTER_LEFT">
 			<Label text="%preferences.volume.type"/>
 			<ChoiceBox fx:id="volumeTypeChoiceBox"/>
+			<Hyperlink contentDisplay="GRAPHIC_ONLY" onAction="#openDocs">
+				<graphic>
+					<FontAwesome5IconView glyph="QUESTION_CIRCLE" styleClass="glyph-icon-muted"/>
+				</graphic>
+				<tooltip>
+					<Tooltip text="Open Cryptomator Docs to learn more about the different volume types." showDelay="100ms"/>
+				</tooltip>
+			</Hyperlink>
 		</HBox>
 
 		<HBox spacing="12" alignment="CENTER_LEFT" visible="${controller.loopbackPortSupported}" managed="${controller.loopbackPortSupported}">
@@ -59,16 +68,5 @@
 				</graphic>
 			</Label>
 		</VBox>
-
-		<Separator orientation="HORIZONTAL"/>
-
-		<VBox HBox.hgrow="ALWAYS" spacing="6">
-			<Label text="%preferences.volume.docs.description" wrapText="true" VBox.vgrow="ALWAYS"/>
-			<Hyperlink text="%preferences.volume.docs.linkText" onAction="#openDocs" contentDisplay="LEFT">
-				<graphic>
-					<FontAwesome5IconView glyph="LINK"/>
-				</graphic>
-			</Hyperlink>
-		</VBox>
 	</children>
 </VBox>