From cee0486d71037233b30672d0b5341b7e6417b3cb Mon Sep 17 00:00:00 2001
From: Armin Schrenk <armin.schrenk@skymatic.de>
Date: Thu, 29 Jun 2023 18:55:49 +0200
Subject: [PATCH] adding unit tests for getProperty

---
 .../common/LazyProcessedPropertiesTest.java   | 105 +++++++++++++-----
 1 file changed, 77 insertions(+), 28 deletions(-)

diff --git a/src/test/java/org/cryptomator/common/LazyProcessedPropertiesTest.java b/src/test/java/org/cryptomator/common/LazyProcessedPropertiesTest.java
index 00a1c49b8..b55e3bda4 100644
--- a/src/test/java/org/cryptomator/common/LazyProcessedPropertiesTest.java
+++ b/src/test/java/org/cryptomator/common/LazyProcessedPropertiesTest.java
@@ -2,47 +2,96 @@ package org.cryptomator.common;
 
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.ValueSource;
+import org.mockito.Mockito;
 
 import java.util.Map;
+import java.util.Properties;
 
 public class LazyProcessedPropertiesTest {
 
 	LazyProcessedProperties inTest;
-	@ParameterizedTest
-	@DisplayName("Test template replacement")
-	@CsvSource(value = {"unknown.@{testToken}.test, unknown.@{testToken}.test", //
-			"@{only*words*digits*under_score\\},@{only*words*digits*under_score\\}", //
-			"C:\\Users\\@{appdir}\\dir, C:\\Users\\foobar\\dir", //
-			"@{@{appdir}},@{foobar}", //
-			"Longer @{appdir} text with @{appdir}., Longer foobar text with foobar."})
-	public void test(String propertyValue, String expected) {
-		LazyProcessedProperties inTest = new LazyProcessedProperties(System.getProperties(), Map.of("APPDIR", "foobar"));
-		var result = inTest.process(propertyValue);
-		Assertions.assertEquals(result, expected);
+
+	@Nested
+	public class Processing {
+
+		@ParameterizedTest
+		@DisplayName("Test template replacement")
+		@CsvSource(value = {"unknown.@{testToken}.test, unknown.@{testToken}.test", //
+				"@{only*words*digits*under_score\\},@{only*words*digits*under_score\\}", //
+				"C:\\Users\\@{appdir}\\dir, C:\\Users\\foobar\\dir", //
+				"@{@{appdir}},@{foobar}", //
+				"Longer @{appdir} text with @{appdir}., Longer foobar text with foobar."})
+		public void test(String propertyValue, String expected) {
+			LazyProcessedProperties inTest = new LazyProcessedProperties(new Properties(), Map.of("APPDIR", "foobar"));
+			var result = inTest.process(propertyValue);
+			Assertions.assertEquals(result, expected);
+		}
+
+		@Test
+		@DisplayName("@{userhome} is replaced with the user home directory")
+		public void testPropSubstitutions() {
+			var props = new Properties();
+			props.setProperty("user.home", "OneUponABit");
+
+			inTest = new LazyProcessedProperties(props, Map.of());
+			var result = inTest.process("@{userhome}");
+			Assertions.assertEquals(result, "OneUponABit");
+		}
+
+		@DisplayName("Other keywords are replaced accordingly")
+		@ParameterizedTest(name = "Token \"{0}\" replaced with content of {1}")
+		@CsvSource(value = {"appdir, APPDIR, foobar", "appdata, APPDATA, bazbaz", "localappdata, LOCALAPPDATA, boboAlice"})
+		public void testEnvSubstitutions(String token, String envName, String expected) {
+			inTest = new LazyProcessedProperties(new Properties(), Map.of(envName, expected));
+			var result = inTest.process("@{" + token + "}");
+			Assertions.assertEquals(result, expected);
+		}
+
 	}
 
-	@Test
-	@DisplayName("@{userhome} is replaced with the user home directory")
-	public void testUserhome(){
-		var expected = System.getProperty("user.home");
 
-		inTest = new LazyProcessedProperties(System.getProperties(), Map.of());
-		var result = inTest.process("@{userhome}");
-		Assertions.assertEquals(result, expected);
-	}
+	@Nested
+	public class GetProperty {
 
-	@DisplayName("Other keywords are replaced accordingly")
-	@ParameterizedTest(name = "Token \"{0}\" replaced with content of {1}")
-	@CsvSource(value = {"appdir, APPDIR, foobar",
-						"appdata, APPDATA, bazbaz",
-						"localappdata, LOCALAPPDATA, boboAlice"})
-	public void testAppDir(String token, String envName, String expected){
-		inTest = new LazyProcessedProperties(System.getProperties(), Map.of(envName, expected));
-		var result = inTest.process("@{"+token+"}");
-		Assertions.assertEquals(result, expected);
+		@Test
+		@DisplayName("Undefined properties are not processed")
+		public void testNoProcessingOnNull() {
+			inTest = Mockito.spy(new LazyProcessedProperties(new Properties(), Map.of()));
+
+			var result = inTest.getProperty("some.prop");
+			Assertions.assertNull(result);
+			Mockito.verify(inTest, Mockito.never()).process(Mockito.anyString());
+		}
+
+		@ParameterizedTest
+		@DisplayName("Properties not starting with \"cryptomator.\" are not processed")
+		@ValueSource(strings = {"example.foo","cryptomatorSomething.foo","org.cryptomator.foo","cryPtoMAtor.foo"})
+		public void testNoProcessingOnNotCryptomator(String propKey) {
+			var props = new Properties();
+			props.setProperty(propKey, "someValue");
+			inTest = Mockito.spy(new LazyProcessedProperties(props, Map.of()));
+
+			var result = inTest.getProperty("some.prop");
+			Assertions.assertNull(result);
+			Mockito.verify(inTest, Mockito.never()).process(Mockito.anyString());
+		}
+
+		@Test
+		@DisplayName("Non-null property starting with \"cryptomator.\" is processed")
+		public void testProcessing() {
+			var props = new Properties();
+			props.setProperty("cryptomator.prop", "someValue");
+			inTest = Mockito.spy(new LazyProcessedProperties(props, Map.of()));
+			Mockito.doReturn("someValue").when(inTest).process(Mockito.anyString());
+
+			inTest.getProperty("cryptomator.prop");
+			Mockito.verify(inTest).process("someValue");
+		}
 	}
 
 }