From eebba459097543f20076d6ccc6c86965353cf078 Mon Sep 17 00:00:00 2001
From: Jan-Peter Klein <jan-peter.klein@skymatic.de>
Date: Tue, 11 Jul 2023 14:10:26 +0200
Subject: [PATCH] added comment to explain code that sets shorteningThreshold
 to 0 removed unnecessary introduction text

---
 .../CreateNewVaultExpertSettingsController.java              | 2 +-
 src/main/resources/fxml/addvault_new_expert_settings.fxml    | 5 ++---
 src/main/resources/i18n/strings.properties                   | 1 -
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultExpertSettingsController.java b/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultExpertSettingsController.java
index a9168deb6..dbf0a0c6e 100644
--- a/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultExpertSettingsController.java
+++ b/src/main/java/org/cryptomator/ui/addvaultwizard/CreateNewVaultExpertSettingsController.java
@@ -73,7 +73,7 @@ public class CreateNewVaultExpertSettingsController implements FxController {
 				int intValue = Integer.parseInt(newValue);
 				shorteningThreshold.set(intValue);
 			} catch (NumberFormatException e) {
-				shorteningThreshold.set(0);
+				shorteningThreshold.set(0); //the value is set to 0 to ensure that an invalid value assignment is detected during a NumberFormatException
 			}
 		});
 	}
diff --git a/src/main/resources/fxml/addvault_new_expert_settings.fxml b/src/main/resources/fxml/addvault_new_expert_settings.fxml
index 26b8822a3..0372f832f 100644
--- a/src/main/resources/fxml/addvault_new_expert_settings.fxml
+++ b/src/main/resources/fxml/addvault_new_expert_settings.fxml
@@ -25,15 +25,14 @@
 	</padding>
 	<children>
 		<Region prefHeight="12" VBox.vgrow="NEVER"/>
-		<Label text="%addvaultwizard.new.expertSettings.summary.introduction" wrapText="true"/>
 		<Label fx:id="vaultNameLabel" alignment="CENTER_RIGHT" graphicTextGap="6" wrapText="true">
 			<graphic>
-				<FontAwesome5IconView styleClass="glyph-icon-muted" glyph="PENCIL"/>
+				<FontAwesome5IconView styleClass="glyph-icon-muted" wrappingWidth="12" glyph="PENCIL"/>
 			</graphic>
 		</Label>
 		<Label fx:id="vaultPathLabel" alignment="CENTER_RIGHT" graphicTextGap="6" wrapText="true">
 			<graphic>
-				<FontAwesome5IconView styleClass="glyph-icon-muted" glyph="HDD"/>
+				<FontAwesome5IconView styleClass="glyph-icon-muted" wrappingWidth="12" glyph="HDD"/>
 			</graphic>
 		</Label>
 		<Region prefHeight="12" VBox.vgrow="NEVER"/>
diff --git a/src/main/resources/i18n/strings.properties b/src/main/resources/i18n/strings.properties
index df82c0e4a..194249400 100644
--- a/src/main/resources/i18n/strings.properties
+++ b/src/main/resources/i18n/strings.properties
@@ -59,7 +59,6 @@ addvaultwizard.new.expertSettings.shorteningThreshold.message=Enter a value betw
 addvaultwizard.new.expertSettings.shorteningThreshold.tooltip=Open the documentation to learn more.
 addvaultwizard.new.expertSettings.shorteningThreshold.title=Maximum length of encrypted file names
 addvaultwizard.new.expertSettings.shorteningThreshold.valid=Valid
-addvaultwizard.new.expertSettings.summary.introduction=This is a quick summary of your vault information
 addvaultwizard.new.fileAlreadyExists=A file or directory with the vault name already exists
 addvaultwizard.new.locationDoesNotExist=A directory in the specified path does not exist or cannot be accessed
 addvaultwizard.new.locationIsNotWritable=No write access at the specified path