From f054a1af03bec7b190d2b9ea58bf795c09ca1456 Mon Sep 17 00:00:00 2001 From: Jan-Peter Klein Date: Thu, 15 Jun 2023 10:54:44 +0200 Subject: [PATCH] optimized tests and some code docu --- .../cryptomator/ui/error/ErrorController.java | 8 ++++++++ .../ui/error/ErrorControllerTest.java | 16 +++------------- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/src/main/java/org/cryptomator/ui/error/ErrorController.java b/src/main/java/org/cryptomator/ui/error/ErrorController.java index fde9790d2..cc6ccf82f 100644 --- a/src/main/java/org/cryptomator/ui/error/ErrorController.java +++ b/src/main/java/org/cryptomator/ui/error/ErrorController.java @@ -152,6 +152,14 @@ public class ErrorController implements FxController { } } + /** + * Checks if an ErrorDiscussion object is a partial match based on the presence of the error code's method code in its title. + * + * @param errorDiscussion The ErrorDiscussion object to be checked. + * @return A boolean value indicating if the ErrorDiscussion object is a partial match: + * - true if the object's title contains the error code's method code, + * - false otherwise. + */ public boolean isPartialMatchFilter(ErrorDiscussion errorDiscussion) { return errorDiscussion.title.contains(" " + errorCode.methodCode()); } diff --git a/src/test/java/org/cryptomator/ui/error/ErrorControllerTest.java b/src/test/java/org/cryptomator/ui/error/ErrorControllerTest.java index 2fe3d93f7..0321a8493 100644 --- a/src/test/java/org/cryptomator/ui/error/ErrorControllerTest.java +++ b/src/test/java/org/cryptomator/ui/error/ErrorControllerTest.java @@ -55,23 +55,13 @@ class ErrorControllerTest { @CsvSource(textBlock = """ 10, 5, -1 8, 15, 1 + 10, 10, 0 """) - public void testCompareUpvoteCount1(int leftUpvoteCount, int rightUpvoteCount, int expectedResult) { + public void testCompareUpvoteCount(int leftUpvoteCount, int rightUpvoteCount, int expectedResult) { var left = createErrorDiscussion("", leftUpvoteCount, null); var right = createErrorDiscussion("", rightUpvoteCount, null); int result = errorController.compareUpvoteCount(left, right); - Assertions.assertTrue(result*expectedResult>0); - } - - @ParameterizedTest - @CsvSource(textBlock = """ - 10, 10 - """) - public void testCompareUpvoteCount2(int leftUpvoteCount, int rightUpvoteCount) { - var left = createErrorDiscussion("", leftUpvoteCount, null); - var right = createErrorDiscussion("", rightUpvoteCount, null); - int result = errorController.compareUpvoteCount(left, right); - Assertions.assertEquals(0,result); + Assertions.assertEquals(expectedResult,Integer.signum(result)); } @ParameterizedTest