diff --git a/.github/workflows/win-exe.yml b/.github/workflows/win-exe.yml index 2b72a50a8..07ae7dea4 100644 --- a/.github/workflows/win-exe.yml +++ b/.github/workflows/win-exe.yml @@ -18,6 +18,8 @@ env: JAVA_VERSION: 21 OPENJFX_JMODS_AMD64: 'https://download2.gluonhq.com/openjfx/20.0.2/openjfx-20.0.2_windows-x64_bin-jmods.zip' OPENJFX_JMODS_AMD64_HASH: '18625bbc13c57dbf802486564247a8d8cab72ec558c240a401bf6440384ebd77' + WINFSP_MSI: 'https://github.com/winfsp/winfsp/releases/download/v2.0/winfsp-2.0.23075.msi' + WINFSP_UNINSTALLER: 'https://github.com/cryptomator/winfsp-uninstaller/releases/download/1.0.0-beta9/winfsp-uninstaller.exe' defaults: run: @@ -292,8 +294,11 @@ jobs: shell: pwsh - name: Download WinFsp run: | - $winfspUrl = (Select-String -Path ".\dist\win\bundle\resources\winFspMetaData.wxi" -Pattern '<\?define BundledWinFspDownloadLink="(.+)".*?>').Matches.Groups[1].Value - curl --output dist/win/bundle/resources/winfsp.msi -L $winfspUrl + curl --output dist/win/bundle/resources/winfsp.msi -L ${{ env.WINFSP_MSI }} + shell: pwsh + - name: Download Legacy-WinFsp uninstaller + run: | + curl --output dist/win/bundle/resources/winfsp-uninstaller.exe -L ${{ env.WINFSP_UNINSTALLER }} shell: pwsh - name: Compile to wixObj file run: > diff --git a/dist/win/.gitignore b/dist/win/.gitignore index 9cce929df..32316fd59 100644 --- a/dist/win/.gitignore +++ b/dist/win/.gitignore @@ -4,4 +4,6 @@ installer *.wixobj *.pdb *.msi +*.exe +*.jmod license.rtf \ No newline at end of file diff --git a/dist/win/build.ps1 b/dist/win/build.ps1 index 9d2fb0def..2606a3778 100644 --- a/dist/win/build.ps1 +++ b/dist/win/build.ps1 @@ -176,10 +176,15 @@ $Env:JP_WIXHELPER_DIR = "." "-Dlicense.licenseMergesUrl=file:///$buildDir/../../license/merges" # download Winfsp -$winfspMsiUrl= (Select-String -Path ".\bundle\resources\winFspMetaData.wxi" -Pattern '<\?define BundledWinFspDownloadLink="(.+)".*?>').Matches.Groups[1].Value +$winfspMsiUrl= 'https://github.com/winfsp/winfsp/releases/download/v2.0/winfsp-2.0.23075.msi' Write-Output "Downloading ${winfspMsiUrl}..." Invoke-WebRequest $winfspMsiUrl -OutFile ".\bundle\resources\winfsp.msi" # redirects are followed by default +# download legacy-winfsp uninstaller +$winfspUninstaller= 'https://github.com/cryptomator/winfsp-uninstaller/releases/download/1.0.0-beta9/winfsp-uninstaller.exe' +Write-Output "Downloading ${winfspUninstaller}..." +Invoke-WebRequest $winfspUninstaller -OutFile ".\bundle\resources\winfsp-uninstaller.exe" # redirects are followed by default + # copy MSI to bundle resources Copy-Item ".\installer\$AppName-*.msi" -Destination ".\bundle\resources\$AppName.msi" diff --git a/dist/win/bundle/bundleWithWinfsp.wxs b/dist/win/bundle/bundleWithWinfsp.wxs index 90ac93802..8e009526e 100644 --- a/dist/win/bundle/bundleWithWinfsp.wxs +++ b/dist/win/bundle/bundleWithWinfsp.wxs @@ -1,5 +1,6 @@ + - - - (InstalledWinFspVersion = v0.0.0.0) OR ($(var.BundledWinFspVersion) <= InstalledWinFspVersion) + UpgradeCode="82F812D9-4083-4EF1-8BC8-0F1EDA05B46B"/> @@ -36,26 +26,41 @@ SuppressOptionsUI="yes" ThemeFile="bundle\customBootstrapperTheme.xml" LocalizationFile="bundle\customBootstrapperTheme.wxl" - LogoFile="bundle\resources\logo.png" - /> + LogoFile="bundle\resources\logo.png"/> + + + + + + + + + + + + + Visible="no"/> + Permanent="yes"/> diff --git a/dist/win/bundle/resources/winFspMetaData.wxi b/dist/win/bundle/resources/winFspMetaData.wxi deleted file mode 100644 index 53e0400e5..000000000 --- a/dist/win/bundle/resources/winFspMetaData.wxi +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - - \ No newline at end of file