From 34db13e60375d2dc62b0f2dc936348507f88f7c1 Mon Sep 17 00:00:00 2001 From: Catherine Date: Wed, 22 Oct 2025 10:44:25 +0000 Subject: [PATCH] Simplify observability code. NFC --- src/manifest.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/manifest.go b/src/manifest.go index de4eb43..4418393 100644 --- a/src/manifest.go +++ b/src/manifest.go @@ -26,7 +26,7 @@ import ( ) var ( - siteCompressionSpaceSaving = promauto.NewHistogramVec(prometheus.HistogramOpts{ + siteCompressionSpaceSaving = promauto.NewHistogram(prometheus.HistogramOpts{ Name: "git_pages_site_compression_space_saving", Help: "Reduction in site size after compression relative to the uncompressed size", Buckets: []float64{.01, .025, .05, .1, .25, .5, .75, 1, 1.25, 1.5, 1.75, 2, 2.5, 5, 10}, @@ -34,7 +34,7 @@ var ( NativeHistogramBucketFactor: 1.1, NativeHistogramMaxBucketNumber: 100, NativeHistogramMinResetDuration: 10 * time.Minute, - }, []string{}) + }) ) func IsManifestEmpty(manifest *Manifest) bool { @@ -188,7 +188,6 @@ func CompressFiles(ctx context.Context, manifest *Manifest) { datasize.ByteSize(transformedSize).HR(), ) siteCompressionSpaceSaving. - With(prometheus.Labels{}). Observe(spaceSaving) }