From 67fce4a5b3addd229f6f1dcc1387085ee150cab0 Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Sat, 28 Jan 2023 02:13:45 +0530 Subject: [PATCH] fix: dangling delete() upon success should return 404 (#16494) --- cmd/erasure-object.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmd/erasure-object.go b/cmd/erasure-object.go index c70a8d1ac..4c176d1e1 100644 --- a/cmd/erasure-object.go +++ b/cmd/erasure-object.go @@ -636,7 +636,10 @@ func (er erasureObjects) getObjectFileInfo(ctx context.Context, bucket, object s if reducedErr := reduceReadQuorumErrs(ctx, errs, objectOpIgnoredErrs, readQuorum); reducedErr != nil { if errors.Is(reducedErr, errErasureReadQuorum) && !strings.HasPrefix(bucket, minioMetaBucket) { - er.deleteIfDangling(ctx, bucket, object, metaArr, errs, nil, opts) + _, derr := er.deleteIfDangling(ctx, bucket, object, metaArr, errs, nil, opts) + if derr != nil { + reducedErr = derr + } } return fi, nil, nil, toObjectErr(reducedErr, bucket, object) }