From 7ce0d71a96c7c5ce18aa4b08671273a7e38f7fd3 Mon Sep 17 00:00:00 2001 From: Anis Eleuch Date: Thu, 18 Jan 2024 19:39:27 +0100 Subject: [PATCH] Do not log volume not empty when healing dangling buckets (#18822) Healing dangling buckets is conservative, and it is a typical use case to fail to remove a dangling bucket because it contains some data because healing danging bucket code is not allowed to remove data: only healing the dangling object is allowed to do so. --- cmd/peer-s3-server.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/peer-s3-server.go b/cmd/peer-s3-server.go index 1729e563c..f292e042f 100644 --- a/cmd/peer-s3-server.go +++ b/cmd/peer-s3-server.go @@ -165,7 +165,7 @@ func healBucketLocal(ctx context.Context, bucket string, opts madmin.HealOpts) ( return errDiskNotFound } err := globalLocalDrives[index].DeleteVol(ctx, bucket, false) - if errors.Is(err, errVolumeNotEmpty) { + if !errors.Is(err, errVolumeNotEmpty) { logger.LogOnceIf(ctx, fmt.Errorf("While deleting dangling Bucket (%s), Drive %s:%s returned an error (%w)", bucket, globalLocalDrives[index].Hostname(), globalLocalDrives[index], err), "delete-dangling-bucket-"+bucket) }