From 9511056f44f753db3ee9b6affd5b19fe45e9babd Mon Sep 17 00:00:00 2001 From: Mark Theunissen Date: Thu, 22 Aug 2024 19:43:48 +1000 Subject: [PATCH] fix: simplify error logged when logger target is unreachable (#20304) --- internal/logger/logger.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/internal/logger/logger.go b/internal/logger/logger.go index 432629bf2..e90cfc880 100644 --- a/internal/logger/logger.go +++ b/internal/logger/logger.go @@ -20,7 +20,6 @@ package logger import ( "context" "encoding/hex" - "encoding/json" "errors" "fmt" "go/build" @@ -422,9 +421,7 @@ func sendLog(ctx context.Context, entry log.Entry) { for _, t := range systemTgts { if err := t.Send(ctx, entry); err != nil { if consoleTgt != nil { // Sending to the console never fails - b, _ := json.Marshal(entry) - entry.Trace.Message = fmt.Sprintf("sendLog: event %s was not sent to Logger target (%v): %v", string(b), t.String(), err.Error()) - consoleTgt.Send(ctx, entry) + consoleTgt.Send(ctx, errToEntry(ctx, "logging", fmt.Errorf("unable to send log event to Logger target (%s): %v", t.String(), err), entry.Level)) } } }