From 9b35c7234947fe9b516a7848d9720e931e871ec4 Mon Sep 17 00:00:00 2001 From: Harshavardhana Date: Fri, 2 Dec 2022 11:19:05 -0800 Subject: [PATCH] fix: a crash in KMS cert reload function (#16158) --- internal/kms/kes.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/kms/kes.go b/internal/kms/kes.go index 8d7ab295d..33308fe6a 100644 --- a/internal/kms/kes.go +++ b/internal/kms/kes.go @@ -102,12 +102,12 @@ func NewWithConfig(config Config) (KMS, error) { if !ok { return } - sameCert := true + sameCert := len(certificate.Certificate) == len(prevCertificate.Certificate) for i, b := range certificate.Certificate { - if !bytes.Equal(b, prevCertificate.Certificate[i]) { - sameCert = false + if !sameCert { break } + sameCert = sameCert && bytes.Equal(b, prevCertificate.Certificate[i]) } // Do not reload if its the same cert as before. if !sameCert {