From cd7551031b0385fea529a27eb25d953f3d7987db Mon Sep 17 00:00:00 2001
From: Harshavardhana <harsha@minio.io>
Date: Tue, 5 Mar 2024 11:06:17 -0800
Subject: [PATCH] fix: a regression in loading replication creds (#19204)

fixes #19200

generating STS credentials fail with site-replicated
setup, with this error on a fresh environment.
---
 cmd/site-replication.go | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/cmd/site-replication.go b/cmd/site-replication.go
index 392c08c28..6b30c59ee 100644
--- a/cmd/site-replication.go
+++ b/cmd/site-replication.go
@@ -6207,12 +6207,11 @@ func (s *siteReplicatorCred) Get(ctx context.Context) (auth.Credentials, error)
 		return s.Creds, nil
 	}
 	s.RUnlock()
-	s.Lock()
-	defer s.Unlock()
-	var m map[string]UserIdentity
+	m := make(map[string]UserIdentity)
 	if err := globalIAMSys.store.loadUser(ctx, siteReplicatorSvcAcc, svcUser, m); err != nil {
 		return auth.Credentials{}, err
 	}
+	s.Set(m[siteReplicatorSvcAcc].Credentials)
 	return m[siteReplicatorSvcAcc].Credentials, nil
 }