fs/xl: Combine input checks into re-usable functions. (#3383)

Repeated code around both object layers are moved
and combined into simple re-usable functions.

cmd/object-api-common_test.go

@@ -0,0 +1,150 @@
+/*
+ * Minio Cloud Storage, (C) 2016 Minio, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package cmd
+
+import (
+	"runtime"
+	"sync"
+	"testing"
+)
+
+func TestHouseKeeping(t *testing.T) {
+	fsDirs, err := getRandomDisks(8)
+	if err != nil {
+		t.Fatalf("Failed to create disks for storage layer <ERROR> %v", err)
+	}
+	defer removeRoots(fsDirs)
+
+	noSpaceDirs, err := getRandomDisks(8)
+	if err != nil {
+		t.Fatalf("Failed to create disks for storage layer <ERROR> %v", err)
+	}
+	defer removeRoots(noSpaceDirs)
+
+	properStorage := []StorageAPI{}
+	for _, fsDir := range fsDirs {
+		var sd StorageAPI
+		sd, err = newPosix(fsDir)
+		if err != nil {
+			t.Fatalf("Failed to create a local disk-based storage layer <ERROR> %v", err)
+		}
+		properStorage = append(properStorage, sd)
+	}
+
+	noSpaceBackend := []StorageAPI{}
+	for _, noSpaceDir := range noSpaceDirs {
+		sd, err := newPosix(noSpaceDir)
+		if err != nil {
+			t.Fatalf("Failed to create a local disk-based storage layer <ERROR> %v", err)
+		}
+		noSpaceBackend = append(noSpaceBackend, sd)
+	}
+	noSpaceStorage := prepareNErroredDisks(noSpaceBackend, 5, errDiskFull, t)
+
+	// Create .minio.sys/tmp directory on all disks.
+	wg := sync.WaitGroup{}
+	errs := make([]error, len(properStorage))
+	for i, store := range properStorage {
+		wg.Add(1)
+		go func(index int, store StorageAPI) {
+			defer wg.Done()
+			errs[index] = store.MakeVol(minioMetaBucket)
+			if errs[index] != nil {
+				return
+			}
+			errs[index] = store.MakeVol(minioMetaTmpBucket)
+			if errs[index] != nil {
+				return
+			}
+			errs[index] = store.AppendFile(minioMetaTmpBucket, "hello.txt", []byte("hello"))
+		}(i, store)
+	}
+	wg.Wait()
+	for i := range errs {
+		if errs[i] != nil {
+			t.Fatalf("Failed to create .minio.sys/tmp directory on disk %v <ERROR> %v",
+				properStorage[i], errs[i])
+		}
+	}
+
+	nilDiskStorage := []StorageAPI{nil, nil, nil, nil, nil, nil, nil, nil}
+	testCases := []struct {
+		store       []StorageAPI
+		expectedErr error
+	}{
+		{properStorage, nil},
+		{noSpaceStorage, StorageFull{}},
+		{nilDiskStorage, nil},
+	}
+	for i, test := range testCases {
+		actualErr := errorCause(houseKeeping(test.store))
+		if actualErr != test.expectedErr {
+			t.Errorf("Test %d - actual error is %#v, expected error was %#v",
+				i+1, actualErr, test.expectedErr)
+		}
+	}
+}
+
+// Test getPath() - the path that needs to be passed to newPosix()
+func TestGetPath(t *testing.T) {
+	globalMinioHost = ""
+	var testCases []struct {
+		epStr string
+		path  string
+	}
+	if runtime.GOOS == "windows" {
+		testCases = []struct {
+			epStr string
+			path  string
+		}{
+			{"\\export", "\\export"},
+			{"D:\\export", "d:\\export"},
+			{"D:\\", "d:\\"},
+			{"D:", "d:"},
+			{"\\", "\\"},
+			{"http://localhost/d:/export", "d:/export"},
+			{"https://localhost/d:/export", "d:/export"},
+		}
+	} else {
+		testCases = []struct {
+			epStr string
+			path  string
+		}{
+			{"/export", "/export"},
+			{"http://localhost/export", "/export"},
+			{"https://localhost/export", "/export"},
+		}
+	}
+	testCasesCommon := []struct {
+		epStr string
+		path  string
+	}{
+		{"export", "export"},
+	}
+	testCases = append(testCases, testCasesCommon...)
+	for i, test := range testCases {
+		eps, err := parseStorageEndpoints([]string{test.epStr})
+		if err != nil {
+			t.Errorf("Test %d: %s - %s", i+1, test.epStr, err)
+			continue
+		}
+		path := getPath(eps[0])
+		if path != test.path {
+			t.Errorf("Test %d: For endpoing %s, getPath() failed, got: %s, expected: %s,", i+1, test.epStr, path, test.path)
+		}
+	}
+}