mirror of
https://github.com/google/nomulus
synced 2025-12-23 06:15:42 +00:00
Abort schema verifier when pg_dump fails (#2681)
Failed pg_dump may not leave a file, failing the subsequent diffing and causing the verifier to return success. The verifier should abort in this case.
This commit is contained in:
@@ -69,6 +69,14 @@ PGPASSWORD=${db_password} pg_dump -h localhost -U "${db_user}" \
|
||||
--exclude-table flyway_schema_history \
|
||||
postgres
|
||||
|
||||
if [ $? -ne 0 ]; then
|
||||
echo "Failed to dump schema."
|
||||
exit 1
|
||||
else
|
||||
echo "Schema dumped."
|
||||
fi
|
||||
|
||||
|
||||
raw_diff=$(diff /schema/nomulus.golden.sql /schema/nomulus.actual.sql)
|
||||
# Clean up the raw_diff:
|
||||
# - Remove diff locations (e.g. "5,6c5,6): grep "^[<>]"
|
||||
|
||||
Reference in New Issue
Block a user