mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-08-20 22:26:12 +00:00
Code Issues Releases Wiki Activity

Fix some low-hanging code quality issue fruits (#1047)

Browse Source 
* Fix some low-hanging code quality issue fruits

These include problems such as: use of raw types, unnecessary throw clauses,
unused variables, and more.
This commit is contained in:
Ben McIlwain
2021-04-01 18:04:21 -04:00
committed by GitHub
parent dc51019fd2
commit 0164bceb95
79 changed files with 163 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files
networking/src/test/java/google/registry/networking/handler/NettyExtension.java
+5 -5
View File
@@ -101,7 +101,7 @@ public final class NettyExtension implements AfterEachCallback {
ChannelInitializer<LocalChannel> clientInitializer =
new ChannelInitializer<LocalChannel>() {
@Override
protected void initChannel(LocalChannel ch) throws Exception {
protected void initChannel(LocalChannel ch) {
// Add the given handler
ch.pipeline().addLast(handler);
// Add the "dumpHandler" last to log the incoming message
@@ -178,7 +178,7 @@ public final class NettyExtension implements AfterEachCallback {
}
@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
public void channelRead(ChannelHandlerContext ctx, Object msg) {
// In the test we only send messages of type ByteBuf.
assertThat(msg).isInstanceOf(ByteBuf.class);
String request = ((ByteBuf) msg).toString(UTF_8);
@@ -189,7 +189,7 @@ public final class NettyExtension implements AfterEachCallback {
/** Saves any inbound error as the cause of the promise failure. */
@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception {
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
ChannelFuture unusedFuture =
ctx.channel().closeFuture().addListener(f -> requestFuture.completeExceptionally(cause));
}
@@ -205,7 +205,7 @@ public final class NettyExtension implements AfterEachCallback {
}
@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
public void channelRead(ChannelHandlerContext ctx, Object msg) {
// In the test we only send messages of type ByteBuf.
assertThat(msg).isInstanceOf(ByteBuf.class);
String response = ((ByteBuf) msg).toString(UTF_8);
@@ -218,7 +218,7 @@ public final class NettyExtension implements AfterEachCallback {
/** Saves any inbound error into the failure cause of the promise. */
@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception {
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
ctx.channel().closeFuture().addListener(f -> responseFuture.completeExceptionally(cause));
}
}