From 0472dda8606f3808eb54c7b24b9131c91724d993 Mon Sep 17 00:00:00 2001 From: gbrodman Date: Tue, 22 Apr 2025 14:53:21 -0400 Subject: [PATCH] Remove transaction duration logging (#2748) We suspected this could be a cause of optimistic locking failures (because long transactions would lead to optimistic locks not being released) but this didn't end up being the case. Let's remove this to reduce log spam. --- .../persistence/transaction/JpaTransactionManagerImpl.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java b/core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java index b84267e0a..5c0ebab80 100644 --- a/core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java +++ b/core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java @@ -276,10 +276,6 @@ public class JpaTransactionManagerImpl implements JpaTransactionManager { } T result = work.call(); txn.commit(); - long duration = clock.nowUtc().getMillis() - txnInfo.transactionTime.getMillis(); - if (duration >= 100) { - logger.atInfo().log("Transaction duration: %d milliseconds", duration); - } return result; } catch (Throwable e) { // Catch a Throwable here so even Errors would lead to a rollback.