mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-07-31 12:32:50 +00:00
Code Issues Releases Wiki Activity

Check the host is under registry suffix instead of public suffix

Browse Source 
Guava now has support to distinguish a registry suffix from a public suffix. Since we are only interested in registrable domains, registry suffix is the proper thing to check.

See:

https://github.com/google/guava/blob/692446a3031289a37db2d57b6eb77d95e2ae93bf/guava/src/com/google/common/net/InternetDomainName.java

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=176126916
This commit is contained in:
jianglai
2017-11-21 18:41:06 -05:00
parent 9ab68613a0
commit 0796a0ff1c
4 changed files with 50 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/flows.md
+2 -2
View File
@@ -1032,7 +1032,7 @@ allows creating a host name, and if necessary enqueues tasks to update DNS.
* 2304
* Superordinate domain for this hostname is in pending delete.
* 2306
* Host names must be at least two levels below the public suffix.
* Host names must be at least two levels below the registry suffix.
## HostDeleteFlow
@@ -1131,7 +1131,7 @@ are enqueued to update DNS accordingly.
* Cannot rename an external host.
* 2306
* Cannot add and remove the same value.
* Host names must be at least two levels below the public suffix.
* Host names must be at least two levels below the registry suffix.
## LoginFlow