mirror of
https://github.com/google/nomulus
synced 2026-07-19 14:32:44 +00:00
Remove obsolete TransferData.extendedRegistrationYears
Now that transfers are always restricted to 1 year, it's unnecessary to store extendedRegistrationYears on TransferData - it will always be equal to 1. This simplifies logic in a few other places, e.g. RdeDomainImportAction. I verified in BigQuery that no DomainBases exist with extendedRegistrationYears values that aren't either null or equal to 1. At some point we should remove the persisted fields from datastore via e.g. resaving all those domains, but it's low priority and can wait until we have some more pressing migration. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=150373897
This commit is contained in:
@@ -81,12 +81,6 @@ public class TransferData extends BaseTransferObject implements Buildable {
|
||||
/** The transaction id of the most recent transfer request (or null if there never was one). */
|
||||
Trid transferRequestTrid;
|
||||
|
||||
/**
|
||||
* The number of years to add to the registration expiration time if this transfer is approved.
|
||||
* Can be null if never transferred, or for resource types where it's not applicable.
|
||||
*/
|
||||
Integer extendedRegistrationYears;
|
||||
|
||||
public ImmutableSet<Key<? extends TransferServerApproveEntity>> getServerApproveEntities() {
|
||||
return nullToEmptyImmutableCopy(serverApproveEntities);
|
||||
}
|
||||
@@ -107,10 +101,6 @@ public class TransferData extends BaseTransferObject implements Buildable {
|
||||
return transferRequestTrid;
|
||||
}
|
||||
|
||||
public Integer getExtendedRegistrationYears() {
|
||||
return extendedRegistrationYears;
|
||||
}
|
||||
|
||||
@Override
|
||||
public Builder asBuilder() {
|
||||
return new Builder(clone(this));
|
||||
@@ -155,12 +145,6 @@ public class TransferData extends BaseTransferObject implements Buildable {
|
||||
getInstance().transferRequestTrid = transferRequestTrid;
|
||||
return this;
|
||||
}
|
||||
|
||||
/** Set the years to add to the registration if this transfer completes. */
|
||||
public Builder setExtendedRegistrationYears(Integer extendedRegistrationYears) {
|
||||
getInstance().extendedRegistrationYears = extendedRegistrationYears;
|
||||
return thisCastToDerived();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user