mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-09-18 22:14:23 +00:00
Code Issues Releases Wiki Activity

Fix proxy metrics instrumentation bug

Browse Source 
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=197209531
This commit is contained in:
jianglai
2018-05-30 12:18:54 -04:00
parent 68b24f0a54
commit 0cb303ed7f
4 changed files with 27 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
javatests/google/registry/proxy/metric/BackendMetricsTest.java
+4 -4
View File
@@ -47,7 +47,7 @@ public class BackendMetricsTest {
public void testSuccess_oneRequest() {
String content = "some content";
FullHttpRequest request = makeHttpPostRequest(content, host, "/");
metrics.requestSent(protocol, certHash, request);
metrics.requestSent(protocol, certHash, request.content().readableBytes());
assertThat(BackendMetrics.requestsCounter)
.hasValueForLabels(1, protocol, certHash)
@@ -68,8 +68,8 @@ public class BackendMetricsTest {
String content2 = "some other content";
FullHttpRequest request1 = makeHttpPostRequest(content1, host, "/");
FullHttpRequest request2 = makeHttpPostRequest(content2, host, "/");
metrics.requestSent(protocol, certHash, request1);
metrics.requestSent(protocol, certHash, request2);
metrics.requestSent(protocol, certHash, request1.content().readableBytes());
metrics.requestSent(protocol, certHash, request2.content().readableBytes());
assertThat(BackendMetrics.requestsCounter)
.hasValueForLabels(2, protocol, certHash)
@@ -146,7 +146,7 @@ public class BackendMetricsTest {
String responseContent = "the only response";
FullHttpRequest request = makeHttpPostRequest(requestContent, host, "/");
FullHttpResponse response = makeHttpResponse(responseContent, HttpResponseStatus.OK);
metrics.requestSent(protocol, certHash, request);
metrics.requestSent(protocol, certHash, request.content().readableBytes());
metrics.responseReceived(protocol, certHash, response, 10);
assertThat(BackendMetrics.requestsCounter)