mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-01-03 19:54:18 +00:00
Code Issues Releases Wiki Activity

Enable nested transaction warning in production (#2628)

Browse Source 
Knonw nested transact calls found in sandbox have been refactored away.
Enable logging in production to catch any missing cases. Logging is
throttled at 1 message per minute per VM.
This commit is contained in:
Weimin Yu
2025-01-03 15:52:25 -05:00
committed by GitHub
parent 7641b05f12
commit 10925f2447
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java
View File

@@ -71,6 +71,7 @@ import java.util.NoSuchElementException;
import java.util.Optional; import java.util.Optional;
import java.util.Set; import java.util.Set;
import java.util.concurrent.Callable; import java.util.concurrent.Callable;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong; import java.util.concurrent.atomic.AtomicLong;
import java.util.function.Supplier; import java.util.function.Supplier;
import java.util.stream.Stream; import java.util.stream.Stream;
@@ -177,9 +178,9 @@ public class JpaTransactionManagerImpl implements JpaTransactionManager {
if (!getHibernateAllowNestedTransactions()) { if (!getHibernateAllowNestedTransactions()) {
throw new IllegalStateException(NESTED_TRANSACTION_MESSAGE); throw new IllegalStateException(NESTED_TRANSACTION_MESSAGE);
} }
if (RegistryEnvironment.get() != RegistryEnvironment.PRODUCTION if (RegistryEnvironment.get() != RegistryEnvironment.UNITTEST) {
&& RegistryEnvironment.get() != RegistryEnvironment.UNITTEST) { logger.atWarning().withStackTrace(StackSize.MEDIUM).atMostEvery(1, TimeUnit.MINUTES).log(
logger.atWarning().withStackTrace(StackSize.MEDIUM).log(NESTED_TRANSACTION_MESSAGE); NESTED_TRANSACTION_MESSAGE);
} }
// This prevents inner transaction from retrying, thus avoiding a cascade retry effect. // This prevents inner transaction from retrying, thus avoiding a cascade retry effect.
return transactNoRetry(isolationLevel, work); return transactNoRetry(isolationLevel, work);