From 1dcc5e5cc60c7a79346082a53a4368104a622263 Mon Sep 17 00:00:00 2001 From: mcilwain Date: Tue, 27 Sep 2016 10:38:38 -0700 Subject: [PATCH] Remove non-batch async contact/host deletion actions They have been superseded by DeleteContactsAndHostsAction. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=134424453 --- .../ProductionRegistryConfigExample.java | 5 - .../registry/config/RegistryConfig.java | 21 -- .../registry/config/TestRegistryConfig.java | 5 - .../env/common/backend/WEB-INF/web.xml | 14 - .../flows/async/AsyncFlowsModule.java | 26 +- .../async/DeleteContactResourceAction.java | 81 ----- .../flows/async/DeleteEppResourceAction.java | 264 ---------------- .../flows/async/DeleteHostResourceAction.java | 82 ----- .../async/DnsRefreshForHostRenameAction.java | 1 + .../backend/BackendRequestComponent.java | 5 - .../DeleteContactResourceActionTest.java | 288 ------------------ .../DeleteEppResourceActionTestCase.java | 139 --------- .../async/DeleteHostResourceActionTest.java | 221 -------------- 13 files changed, 2 insertions(+), 1150 deletions(-) delete mode 100644 java/google/registry/flows/async/DeleteContactResourceAction.java delete mode 100644 java/google/registry/flows/async/DeleteEppResourceAction.java delete mode 100644 java/google/registry/flows/async/DeleteHostResourceAction.java delete mode 100644 javatests/google/registry/flows/async/DeleteContactResourceActionTest.java delete mode 100644 javatests/google/registry/flows/async/DeleteEppResourceActionTestCase.java delete mode 100644 javatests/google/registry/flows/async/DeleteHostResourceActionTest.java diff --git a/java/google/registry/config/ProductionRegistryConfigExample.java b/java/google/registry/config/ProductionRegistryConfigExample.java index 20a688d2d..b04dcb27b 100644 --- a/java/google/registry/config/ProductionRegistryConfigExample.java +++ b/java/google/registry/config/ProductionRegistryConfigExample.java @@ -219,11 +219,6 @@ public final class ProductionRegistryConfigExample implements RegistryConfig { return "TheRegistrar"; } - @Override - public Duration getAsyncDeleteFlowMapreduceDelay() { - return Duration.standardSeconds(90); - } - @Override public Duration getAsyncFlowFailureBackoff() { return Duration.standardMinutes(10); diff --git a/java/google/registry/config/RegistryConfig.java b/java/google/registry/config/RegistryConfig.java index 7a13d2237..6592469f8 100644 --- a/java/google/registry/config/RegistryConfig.java +++ b/java/google/registry/config/RegistryConfig.java @@ -211,27 +211,6 @@ public interface RegistryConfig { */ public String getCheckApiServletRegistrarClientId(); - /** - * Returns the delay before executing async delete flow mapreduces. - * - *

This delay should be sufficiently longer than a transaction, to solve the following problem: - *

- * - *

Although we try not to add references to a PENDING_DELETE resource, strictly speaking that - * is ok as long as the mapreduce eventually sees the new reference (and therefore asynchronously - * fails the delete). Without this delay, the mapreduce might have started before the domain flow - * committed, and could potentially miss the reference. - */ - // TODO(b/26140521): Remove this configuration option along with non-batched async operations. - public Duration getAsyncDeleteFlowMapreduceDelay(); - /** * Returns the amount of time to back off following an async flow task failure. * diff --git a/java/google/registry/config/TestRegistryConfig.java b/java/google/registry/config/TestRegistryConfig.java index e01a140d7..352f9ffdc 100644 --- a/java/google/registry/config/TestRegistryConfig.java +++ b/java/google/registry/config/TestRegistryConfig.java @@ -167,11 +167,6 @@ public class TestRegistryConfig implements RegistryConfig { return "TheRegistrar"; } - @Override - public Duration getAsyncDeleteFlowMapreduceDelay() { - return Duration.standardSeconds(90); - } - @Override public Duration getAsyncFlowFailureBackoff() { return Duration.standardMinutes(10); diff --git a/java/google/registry/env/common/backend/WEB-INF/web.xml b/java/google/registry/env/common/backend/WEB-INF/web.xml index 3f5b1db7a..766aa25ab 100644 --- a/java/google/registry/env/common/backend/WEB-INF/web.xml +++ b/java/google/registry/env/common/backend/WEB-INF/web.xml @@ -246,20 +246,6 @@ /_dr/task/deleteProberData - - - - backend-servlet - /_dr/task/deleteContactResource - - - - - - backend-servlet - /_dr/task/deleteHostResource - -