mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2025-12-23 14:25:44 +00:00
Code Issues Releases Wiki Activity

UrlConnectionException loses error info (#2648)

Browse Source 
It does not get the error message for 400+ status codes.

It fails to get the status code if the response has neither data nor
error.
This commit is contained in:
Weimin Yu
2025-01-23 11:27:03 -05:00
committed by GitHub
parent b775e4a178
commit 229fcf3946
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
util/src/main/java/google/registry/util/UrlConnectionException.java
View File

@@ -37,13 +37,14 @@ public class UrlConnectionException extends RuntimeException {
@Override @Override
public String getMessage() { public String getMessage() {
byte[] resultContent; byte[] resultContent;
int responseCode; int responseCode = 0;
try { try {
resultContent = ByteStreams.toByteArray(connection.getInputStream());
responseCode = connection.getResponseCode(); responseCode = connection.getResponseCode();
} catch (IOException e) { resultContent =
resultContent = new byte[] {}; ByteStreams.toByteArray(
responseCode = 0; responseCode < 400 ? connection.getInputStream() : connection.getErrorStream());
} catch (IOException | NullPointerException e) {
resultContent = "-- Response is missing or has malformed content --".getBytes(UTF_8);
} }
StringBuilder result = StringBuilder result =
new StringBuilder(2048 + resultContent.length) new StringBuilder(2048 + resultContent.length)