mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-02-07 21:41:03 +00:00
Code Issues Releases Wiki Activity

Remove some unnecessary loggings from the proxy

Browse Source 
We confirmed that the retry is working. Instead of logging the messages them
selves, we only need to log the message hash to ensure that the same message is
retried.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=208883712
This commit is contained in:
jianglai
2018-08-15 14:31:31 -07:00
parent 3dba385213
commit 301301cafe
3 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
java/google/registry/proxy/ProxyServer.java
View File

@@ -93,6 +93,7 @@ public class ProxyServer implements Runnable {
inboundChannel.attr(PROTOCOL_KEY).set(inboundProtocol);
inboundChannel.attr(RELAY_BUFFER_KEY).set(new ArrayDeque<>());
addHandlers(inboundChannel.pipeline(), inboundProtocol.handlerProviders());
logger.atInfo().log("Connection established: %s %s", inboundProtocol.name(), inboundChannel);
if (!inboundProtocol.hasBackend()) {
// If the frontend has no backend to relay to (health check, web WHOIS redirect, etc), start
@@ -146,10 +147,9 @@ public class ProxyServer implements Runnable {
.get()
.forEach(
msg -> {
// TODO (jianglai): do not log the message once retry behavior is
// confirmed.
logger.atWarning().log(
"Unfinished relay for connection %s: %s", inboundChannel, msg);
"Unfinished relay for connection %s\nHASH: %s",
inboundChannel, msg.hashCode());
ReferenceCountUtil.release(msg);
});
});
@@ -194,14 +194,13 @@ public class ProxyServer implements Runnable {
Object[] messages = relayBuffer.toArray();
relayBuffer.clear();
for (Object msg : messages) {
// TODO (jianglai): do not log the message once retry behavior is confirmed.
logger.atInfo().log(
"Relay retried: %s <-> %s\nFRONTEND: %s\nBACKEND: %s\nMESSAGE: %s",
"Relay retried: %s <-> %s\nFRONTEND: %s\nBACKEND: %s\nHASH: %s",
inboundProtocol.name(),
outboundProtocol.name(),
inboundChannel,
outboundChannel,
msg);
msg.hashCode());
writeToRelayChannel(inboundChannel, outboundChannel, msg, true);
}
// When this outbound connection is closed, try reconnecting if the inbound connection
@@ -220,6 +219,13 @@ public class ProxyServer implements Runnable {
outboundChannel);
connectOutboundChannel(
bootstrap, inboundProtocol, outboundProtocol, inboundChannel);
} else {
logger.atInfo().log(
"Relay terminated: %s <-> %s\nFRONTEND: %s\nBACKEND: %s",
inboundProtocol.name(),
outboundProtocol.name(),
inboundChannel,
outboundChannel);
}
});
} else {