mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-07-07 00:27:12 +00:00
Code Issues Releases Wiki Activity

Make async flow logic handle missing client transaction IDs

Browse Source 
Per EPP RFC 5730, the <clTRID> element is optional. However, we weren't handling
it not being specified in asynchronous contact/host deletions because we were
adding it directly as a parameter value on a task, which does not allow null and
thus threw a NullPointerException.

This fixes handling for nulls (the parameter isn't set at all) and adds a test.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=194123259
This commit is contained in:
mcilwain
2018-04-24 12:01:05 -07:00
committed by jianglai
parent f56355c9e8
commit 33505f4df7
16 changed files with 196 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/google/registry/flows/async/AsyncFlowEnqueuer.java
+3 -1
View File
@@ -83,10 +83,12 @@ public final class AsyncFlowEnqueuer {
.countdownMillis(asyncDeleteDelay.getMillis())
.param(PARAM_RESOURCE_KEY, resourceKey.getString())
.param(PARAM_REQUESTING_CLIENT_ID, requestingClientId)
.param(PARAM_CLIENT_TRANSACTION_ID, trid.getClientTransactionId())
.param(PARAM_SERVER_TRANSACTION_ID, trid.getServerTransactionId())
.param(PARAM_IS_SUPERUSER, Boolean.toString(isSuperuser))
.param(PARAM_REQUESTED_TIME, now.toString());
if (trid.getClientTransactionId().isPresent()) {
task.param(PARAM_CLIENT_TRANSACTION_ID, trid.getClientTransactionId().get());
}
addTaskToQueueWithRetry(asyncDeletePullQueue, task);
}