mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-02-10 06:50:30 +00:00
Code Issues Releases Wiki Activity

Improve some log messages for readability/consistency (#1333)

Browse Source 
* Improve some log messages for readability/consistency

* Address code review comments
This commit is contained in:
Ben McIlwain
2021-09-27 11:35:14 -04:00
committed by GitHub
parent ff3c848def
commit 3caee5fba7
100 changed files with 252 additions and 250 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/test/java/google/registry/flows/ExtensionManagerTest.java
View File

@@ -82,7 +82,7 @@ class ExtensionManagerTest {
assertThat(logMessages.build())
.contains(
"Client clientId is attempting to run HelloFlow without declaring "
+ "URIs [urn:google:params:xml:ns:metadata-1.0] on login");
+ "URIs [urn:google:params:xml:ns:metadata-1.0] on login.");
}
@Test

4
core/src/test/java/google/registry/model/replay/ReplicateToDatastoreActionTest.java
View File

@@ -213,7 +213,7 @@ public class ReplicateToDatastoreActionTest {
new IllegalStateException(
"Missing transaction: last txn id = -1, next available txn = 1"));
assertThat(response.getStatus()).isEqualTo(SC_INTERNAL_SERVER_ERROR);
assertThat(response.getPayload()).isEqualTo("Errored out replaying files");
assertThat(response.getPayload()).isEqualTo("Errored out replaying files.");
}
@Test
@@ -287,7 +287,7 @@ public class ReplicateToDatastoreActionTest {
action.run();
assertThat(response.getStatus()).isEqualTo(SC_OK);
assertThat(response.getPayload())
.isEqualTo("Replayed 1 transaction(s) from Cloud SQL -> Datastore");
.isEqualTo("Replayed 1 transaction(s) from Cloud SQL -> Datastore.");
}
private void resetAction() {

17
core/src/test/java/google/registry/whois/WhoisReaderTest.java
View File

@@ -343,7 +343,7 @@ class WhoisReaderTest {
assertAboutLogs()
.that(testLogHandler)
.hasLogAtLevelWithMessage(
Level.INFO, "Attempting domain lookup command using domain name example.tld");
Level.INFO, "Attempting domain lookup command using domain name 'example.tld'.");
}
@TestOfyAndSql
@@ -352,7 +352,8 @@ class WhoisReaderTest {
assertAboutLogs()
.that(testLogHandler)
.hasLogAtLevelWithMessage(
Level.INFO, "Attempting nameserver lookup command using 43.34.12.213 as an IP address");
Level.INFO,
"Attempting nameserver lookup command using 43.34.12.213 as an IP address.");
}
@TestOfyAndSql
@@ -361,7 +362,7 @@ class WhoisReaderTest {
assertAboutLogs()
.that(testLogHandler)
.hasLogAtLevelWithMessage(
Level.INFO, "Attempting nameserver lookup command using ns.example.tld as a hostname");
Level.INFO, "Attempting nameserver lookup command using ns.example.tld as a hostname.");
}
@TestOfyAndSql
@@ -380,7 +381,7 @@ class WhoisReaderTest {
assertAboutLogs()
.that(testLogHandler)
.hasLogAtLevelWithMessage(
Level.INFO, "Attempting nameserver lookup using 43.34.12.213 as an IP address");
Level.INFO, "Attempting nameserver lookup using 43.34.12.213 as an IP address.");
}
@TestOfyAndSql
@@ -389,7 +390,7 @@ class WhoisReaderTest {
assertAboutLogs()
.that(testLogHandler)
.hasLogAtLevelWithMessage(
Level.INFO, "Attempting registrar lookup using test as a registrar");
Level.INFO, "Attempting registrar lookup using test as a registrar.");
}
@TestOfyAndSql
@@ -398,7 +399,7 @@ class WhoisReaderTest {
assertAboutLogs()
.that(testLogHandler)
.hasLogAtLevelWithMessage(
Level.INFO, "Attempting domain lookup using example.tld as a domain name");
Level.INFO, "Attempting domain lookup using example.tld as a domain name.");
}
@TestOfyAndSql
@@ -407,7 +408,7 @@ class WhoisReaderTest {
assertAboutLogs()
.that(testLogHandler)
.hasLogAtLevelWithMessage(
Level.INFO, "Attempting nameserver lookup using ns.example.tld as a hostname");
Level.INFO, "Attempting nameserver lookup using ns.example.tld as a hostname.");
}
@TestOfyAndSql
@@ -417,6 +418,6 @@ class WhoisReaderTest {
.that(testLogHandler)
.hasLogAtLevelWithMessage(
Level.INFO,
"Attempting registrar lookup employing Example Registrar, Inc. as a registrar");
"Attempting registrar lookup employing Example Registrar, Inc. as a registrar.");
}
}