mirror of
https://github.com/google/nomulus
synced 2026-08-01 12:56:06 +00:00
Fix various Error Prone errors that were found by the FOSS build
Most common: - Unnecessary parentheses and operator precedence clarify (self-explanatory) - Reference equality--there were a few instances of using == or != improperly - Qualification of Builder (and similar) imports so that it's clear which type of Builder we're referring to - Marking some immutable classes with @Immutable since EP desires that all enums be deeply immutable - String.split() having "surprising behavior" ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=230971531
This commit is contained in:
@@ -43,7 +43,7 @@ public class UtcDateTimeAdapterTest {
|
||||
|
||||
@Test
|
||||
public void testMarshalEmpty() {
|
||||
assertThat((new UtcDateTimeAdapter()).marshal(null)).isEmpty();
|
||||
assertThat(new UtcDateTimeAdapter().marshal(null)).isEmpty();
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -60,14 +60,14 @@ public class UtcDateTimeAdapterTest {
|
||||
|
||||
@Test
|
||||
public void testUnmarshalEmpty() {
|
||||
assertThat((new UtcDateTimeAdapter()).unmarshal(null)).isNull();
|
||||
assertThat((new UtcDateTimeAdapter()).unmarshal("")).isNull();
|
||||
assertThat(new UtcDateTimeAdapter().unmarshal(null)).isNull();
|
||||
assertThat(new UtcDateTimeAdapter().unmarshal("")).isNull();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testUnmarshalInvalid() {
|
||||
assertThrows(
|
||||
IllegalArgumentException.class,
|
||||
() -> assertThat((new UtcDateTimeAdapter()).unmarshal("oh my goth")).isNull());
|
||||
() -> assertThat(new UtcDateTimeAdapter().unmarshal("oh my goth")).isNull());
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user