mirrors/nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus synced 2026-01-07 05:56:49 +00:00
Code Issues Releases Wiki Activity

Add success exception for TestExtraLogicManager

Browse Source 
TestExtraLogicManager is pretty kludgy, and should be replaced with injection, mocking, etc. But in the meantime, using a dedicated error to signal its success, rather than IllegalArgumentException as was done before, at least makes things a little easier to follow.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=134832315
This commit is contained in:
mountford
2016-09-30 15:05:11 -07:00
committed by Ben McIlwain
parent 237e588d6c
commit 3d5ab8d068
7 changed files with 36 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javatests/google/registry/flows/domain/DomainTransferRequestFlowTest.java
View File

@@ -63,6 +63,7 @@ import google.registry.model.domain.DomainAuthInfo;
import google.registry.model.domain.DomainResource;
import google.registry.model.domain.GracePeriod;
import google.registry.model.domain.TestExtraLogicManager;
import google.registry.model.domain.TestExtraLogicManager.TestExtraLogicManagerSuccessException;
import google.registry.model.domain.rgp.GracePeriodStatus;
import google.registry.model.eppcommon.AuthInfo.PasswordAuth;
import google.registry.model.eppcommon.StatusValue;
@@ -769,7 +770,8 @@ public class DomainTransferRequestFlowTest
setEppInput("domain_transfer_request_flags.xml");
setupDomain("example", "flags");
eppLoader.replaceAll("JD1234-REP", contact.getRepoId());
thrown.expect(IllegalArgumentException.class, "add:flag1,flag2;remove:flag3,flag4");
thrown.expect(
TestExtraLogicManagerSuccessException.class, "add:flag1,flag2;remove:flag3,flag4");
runFlow();
}
}