Bypass SCRYPT hashing in tests (#2262)

SCRYPT is much computationally heavier than SHA265 (by design), which
resulted in test run time doubling due to most tests initializing canned
data that uses hashing.

Since out tests are not verifying the correctness of a specific hashing
algorithm anyway, this PR makes it so that simple concatenation is used
in tests.

Also moved RegistryEnvironment to the util subproject so it can be called by
PasswordUtils, which makes sense as it is a utility class.

util/src/main/java/google/registry/util/PasswordUtils.java

@@ -22,6 +22,7 @@ import static java.nio.charset.StandardCharsets.US_ASCII;
 import com.google.common.base.Supplier;
 import com.google.common.base.Suppliers;
 import com.google.common.flogger.FluentLogger;
+import com.google.common.primitives.Bytes;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.security.SecureRandom;
@@ -68,15 +69,22 @@ public final class PasswordUtils {
             .digest((new String(password, US_ASCII) + base64().encode(salt)).getBytes(US_ASCII));
       }
     },
+
     /**
      * Memory-hard hashing algorithm, preferred over SHA-256.
      *
+     * <p>Note that in tests, we simply concatenate the password and salt which is much faster and
+     * reduces the overall test run time by a half. Our tests are not verifying that SCRYPT is
+     * implemented correctly anyway.
+     *
      * @see <a href="https://en.wikipedia.org/wiki/Scrypt">Scrypt</a>
      */
     SCRYPT {
       @Override
       byte[] hash(byte[] password, byte[] salt) {
-        return SCrypt.generate(password, salt, 32768, 8, 1, 256);
+        return RegistryEnvironment.get() == RegistryEnvironment.UNITTEST
+            ? Bytes.concat(password, salt)
+            : SCrypt.generate(password, salt, 32768, 8, 1, 256);
       }
     };
 

util/src/main/java/google/registry/util/RegistryEnvironment.java

@@ -0,0 +1,71 @@
+// Copyright 2017 The Nomulus Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package google.registry.util;
+
+import com.google.common.base.Ascii;
+
+/** Registry environments. */
+public enum RegistryEnvironment {
+
+  /** Production environment. */
+  PRODUCTION,
+
+  /** Development environment. */
+  ALPHA,
+
+  /** Load/Backup/Restore Testing environment. */
+  CRASH,
+
+  /** Local machine environment. */
+  LOCAL,
+
+  /** Quality Assurance environment. */
+  QA,
+
+  /** Sandbox environment. */
+  SANDBOX,
+
+  /**
+   * Unit testing environment.
+   *
+   * <p>This is the default enum value. This is because it's non-trivial to configure the system
+   * property that specifies the environment in our unit tests.
+   *
+   * <p>Do not use this environment outside of unit tests.
+   */
+  UNITTEST;
+
+  /** Sets this enum as the name of the registry environment. */
+  public RegistryEnvironment setup() {
+    return setup(SystemPropertySetter.PRODUCTION_IMPL);
+  }
+
+  /**
+   * Sets this enum as the name of the registry environment using specified {@link
+   * SystemPropertySetter}.
+   */
+  public RegistryEnvironment setup(SystemPropertySetter systemPropertySetter) {
+    systemPropertySetter.setProperty(PROPERTY, name());
+    return this;
+  }
+
+  /** Returns environment configured by system property {@value #PROPERTY}. */
+  public static RegistryEnvironment get() {
+    return valueOf(Ascii.toUpperCase(System.getProperty(PROPERTY, UNITTEST.name())));
+  }
+
+  /** System property for configuring which environment we should use. */
+  private static final String PROPERTY = "google.registry.environment";
+}

util/src/main/java/google/registry/util/SystemPropertySetter.java

@@ -0,0 +1,47 @@
+// Copyright 2018 The Nomulus Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package google.registry.util;
+
+import javax.annotation.Nullable;
+
+/**
+ * Wrapper interface around {@link System#setProperty(String, String)} and {@link
+ * System#clearProperty(String)}. Tests that modify system properties may provide custom
+ * implementations that keeps track of changes and restores original property values on test
+ * completion.
+ */
+public interface SystemPropertySetter {
+
+  /**
+   * Updates the system property specified by {@code key}. If {@code value} is not null, {@link
+   * System#setProperty(String, String)} is invoked; otherwise {@link System#clearProperty(String)}
+   * is invoked.
+   */
+  SystemPropertySetter setProperty(String key, @Nullable String value);
+
+  /** Production implementation of {@link SystemPropertySetter}. */
+  SystemPropertySetter PRODUCTION_IMPL =
+      new SystemPropertySetter() {
+        @Override
+        public SystemPropertySetter setProperty(String key, @Nullable String value) {
+          if (value == null) {
+            System.clearProperty(key);
+          } else {
+            System.setProperty(key, value);
+          }
+          return this;
+        }
+      };
+}

util/src/test/java/google/registry/util/RegistryEnvironmentTest.java

@@ -0,0 +1,26 @@
+// Copyright 2017 The Nomulus Authors. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package google.registry.util;
+
+import org.junit.jupiter.api.Test;
+
+/** Unit tests for {@link RegistryEnvironment}. */
+class RegistryEnvironmentTest {
+
+  @Test
+  void testGet() {
+    RegistryEnvironment.get();
+  }
+}