From 49484c06d3f8463216427347bf73d97f55195e51 Mon Sep 17 00:00:00 2001 From: Ben McIlwain Date: Mon, 5 Jan 2026 16:20:11 -0500 Subject: [PATCH] Filter out registrars of type OT&E from RDE escrow deposits (#2921) The RDE XML schema (which is verified by ICANN's RST) requires the presence of a numeric IANA identifier, which is always null for OT&E registrars. This change synchronizes the three types of registrars that must have a null IANA identifier (see https://cs.opensource.google/nomulus/nomulus/+/master:core/src/main/java/google/registry/model/registrar/Registrar.java;l=109-142;drc=b1266c95e8d9f8206415d2821929d4161869b699 ) with the registrars that are excluded from the RDE deposit. Note that there are no registrars of type OT&E in prod and I can't think of a reason they would need to be included in escrow deposits on sandbox. --- .../src/main/java/google/registry/beam/rde/RdePipeline.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/google/registry/beam/rde/RdePipeline.java b/core/src/main/java/google/registry/beam/rde/RdePipeline.java index 08c0e2ca2..f6441ba8e 100644 --- a/core/src/main/java/google/registry/beam/rde/RdePipeline.java +++ b/core/src/main/java/google/registry/beam/rde/RdePipeline.java @@ -184,10 +184,10 @@ public class RdePipeline implements Serializable { private final CloudTasksUtils cloudTasksUtils; private final RdeMarshaller marshaller; - // Registrars to be excluded from data escrow. Not including the sandbox-only OTE type so that - // if sneaks into production we would get an extra signal. + // Registrars to be excluded from data escrow (i.e. all registrar types that have a null IANA + // identifier and thus would not be valid according to the RDE schema). private static final ImmutableSet IGNORED_REGISTRAR_TYPES = - Sets.immutableEnumSet(Registrar.Type.MONITORING, Registrar.Type.TEST); + Sets.immutableEnumSet(Registrar.Type.MONITORING, Registrar.Type.OTE, Registrar.Type.TEST); private static final FluentLogger logger = FluentLogger.forEnclosingClass();