1
0
mirror of https://github.com/google/nomulus synced 2026-02-09 22:40:55 +00:00

Set payload response in happy path of ReplayCommitLogsToSqlAction (#1229)

* Set payload response in happy path of ReplayCommitLogsToSqlAction

I suspect this may be the reason the logs are missing on the happy path (when it
runs successfully), but are visible on the exception paths (which do set the
payload response). I don't think App Engine likes it when a Web request
terminates without a response.

This also adds more logging and error handling.
This commit is contained in:
Ben McIlwain
2021-07-01 18:21:17 -04:00
committed by GitHub
parent 047444831b
commit 4e30d020ca
2 changed files with 21 additions and 3 deletions

View File

@@ -494,6 +494,8 @@ public class ReplayCommitLogsToSqlActionTest {
private void runAndAssertSuccess(DateTime expectedCheckpointTime) {
action.run();
assertThat(response.getStatus()).isEqualTo(SC_OK);
assertThat(response.getPayload())
.isEqualTo("ReplayCommitLogsToSqlAction completed successfully.");
assertThat(jpaTm().transact(SqlReplayCheckpoint::get)).isEqualTo(expectedCheckpointTime);
}